From: Dinar Temirbulatov <dinar@kugelworks.com>
To: Rong Xu <xur@google.com>
Cc: Xinliang David Li <davidxl@google.com>,
Teresa Johnson <tejohnson@google.com>,
GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [Google] Fix profiledbootstrap failure
Date: Wed, 31 Jul 2013 17:09:00 -0000 [thread overview]
Message-ID: <CANoaTN3p5_GoxTrhxEDh3jzY+BLNYBZFqCP+fjMnFi8jgnY-Zw@mail.gmail.com> (raw)
In-Reply-To: <CAF1bQ=S3spF_8hW5ZtGshUY0XO3yshLuirE9nPC=mMfPRXhuPA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2123 bytes --]
Hi,
Here is the patch, Tested by profiledbootstrap. Ok for google gcc-4.8?
thanks, Dinar.
On Wed, Jul 31, 2013 at 12:01 AM, Rong Xu <xur@google.com> wrote:
> Will do.
>
> The patch was in gcc-4_7 by Dehao.
>
> r194713 | dehao | 2012-12-24 16:49:06 -0800 (Mon, 24 Dec 2012) | 5 lines
>
> Fix the profiled bootstrap:
>
> 1. Set the default value of gcov-debug to be 0.
> 2. Merge profile summaries from different instrumented binaries.
>
> On Tue, Jul 30, 2013 at 12:58 PM, Xinliang David Li <davidxl@google.com> wrote:
>> Ok. Rong, can you help commit the parameter default setting patch?
>>
>> thanks,
>>
>> David
>>
>> On Tue, Jul 30, 2013 at 12:48 PM, Rong Xu <xur@google.com> wrote:
>>> We have seen the issue before. It does fail the profile boostrap as it
>>> reads a wrong gcda file.
>>> I thought it had been fixed. (The fix was as David mentioned, setting
>>> the default value of the parameter to 0).
>>>
>>> -Rong
>>>
>>> On Tue, Jul 30, 2013 at 12:02 PM, Xinliang David Li <davidxl@google.com> wrote:
>>>> I need to understand why this affects profile bootstrap -- is this due
>>>> to file name conflict?
>>>>
>>>> The fix is wrong -- please do not remove the parameter. If it is a
>>>> problem, a better fix is to change the default parameter value to 0.
>>>>
>>>> David
>>>>
>>>>
>>>> On Tue, Jul 30, 2013 at 11:56 AM, Teresa Johnson <tejohnson@google.com> wrote:
>>>>> cc'ing Rong and David since this came from LIPO support.
>>>>>
>>>>> The patch as-is removes the one use of PARAM_GCOV_DEBUG (which is on
>>>>> by default) without removing the parameter itself. What is the failure
>>>>> mode you see from this code?
>>>>>
>>>>> Thanks,
>>>>> Teresa
>>>>>
>>>>> On Tue, Jul 30, 2013 at 11:50 AM, Dinar Temirbulatov
>>>>> <dinar@kugelworks.com> wrote:
>>>>>> Hello
>>>>>>
>>>>>> This change allows to complete profiledbootstrap on the google gcc-4.8
>>>>>> branch, tested with make bootstrap with no new regressions. OK for
>>>>>> google 4.8?
>>>>>> thanks, Dinar.
>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> Teresa Johnson | Software Engineer | tejohnson@google.com | 408-460-2413
[-- Attachment #2: profiledbootstrap-fix1.patch --]
[-- Type: application/octet-stream, Size: 396 bytes --]
Index: gcc/params.def
===================================================================
--- gcc/params.def (revision 201372)
+++ gcc/params.def (working copy)
@@ -1026,7 +1026,7 @@
DEFPARAM (PARAM_GCOV_DEBUG,
"gcov-debug",
"Looking for gcda file in current dir.",
- 1, 0, 1)
+ 0, 0, 1)
/* Avoid SLP vectorization of large basic blocks. */
DEFPARAM (PARAM_SLP_MAX_INSNS_IN_BB,
next prev parent reply other threads:[~2013-07-31 17:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-30 18:51 Dinar Temirbulatov
2013-07-30 19:02 ` Teresa Johnson
2013-07-30 19:13 ` Xinliang David Li
2013-07-30 19:50 ` Rong Xu
2013-07-30 20:01 ` Xinliang David Li
2013-07-30 20:18 ` Rong Xu
2013-07-31 17:09 ` Dinar Temirbulatov [this message]
2013-07-30 19:58 ` Dinar Temirbulatov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANoaTN3p5_GoxTrhxEDh3jzY+BLNYBZFqCP+fjMnFi8jgnY-Zw@mail.gmail.com \
--to=dinar@kugelworks.com \
--cc=davidxl@google.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=tejohnson@google.com \
--cc=xur@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).