From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 59703 invoked by alias); 20 Nov 2019 20:45:40 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 59686 invoked by uid 89); 20 Nov 2019 20:45:40 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.8 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy=sk:kernels X-HELO: mail-yw1-f44.google.com Received: from mail-yw1-f44.google.com (HELO mail-yw1-f44.google.com) (209.85.161.44) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 20 Nov 2019 20:45:39 +0000 Received: by mail-yw1-f44.google.com with SMTP id 4so79104ywx.4; Wed, 20 Nov 2019 12:45:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=e8V9RDgYhyp6u+VnVgFRrUTu/43g6VnkM6uCXSEwMTY=; b=oQ20GTPCYJ5EsV9ZlJFGAo6IHqFRTU3GPvcrluFj9lr3F4VBNRdylovBDN9oUxKXzx tmkaI5/QikgsVGrY2YVuVZDeuamiuPVmWNd995YfFy9T9oxchHl7XflR9fudU2f7ickI g4bfMDWbbJw7bv+M4qPtXoBWmGdI6L9bFDU+jofxruqi5/V5MKgAquhvMQEfu3Jzy3JR o3UA2iS93Nivkfu2fp0ECHJTi1avIt/FE9jwznpakJC5jZ56tcjfG2x3D0G9R7x1xwcx Za5VNdXBeyxWktDIvH/OZco5XX71OMuBvVFIwBiJaQi/ryKwtI63BZ0U5RdMq1GXEjnV YJmQ== MIME-Version: 1.0 References: <48286910-ebbb-10e4-488b-8c96e505375c@tkoenig.net> <43b9fcf0-f457-90a7-c807-4aebc65cb045@tkoenig.net> <2981fd67-007e-7327-8208-27e8fd18d9db@netcologne.de> In-Reply-To: <2981fd67-007e-7327-8208-27e8fd18d9db@netcologne.de> From: Janne Blomqvist Date: Wed, 20 Nov 2019 20:46:00 -0000 Message-ID: Subject: Re: [patch, fortran] Load scalar intent-in variables at the beginning of procedures To: Thomas Koenig Cc: =?UTF-8?Q?Thomas_K=C3=B6nig?= , Tobias Burnus , "fortran@gcc.gnu.org" , gcc-patches Content-Type: text/plain; charset="UTF-8" X-SW-Source: 2019-11/txt/msg02019.txt.bz2 On Sat, Nov 16, 2019 at 10:34 PM Thomas Koenig wrote: > > Hello world, > > here is an update to the patch. > > I have now included variables where the user did not specify INTENT(IN) > by checking that the dummy variables to be replaced by temporaries > are not, indeed, assigned a value. This also includes being passed > as an actual argument to a non-INTENT(IN) dummy argument. > > Extending this led to being able to catch a few more bugs. > > I have addes one test case to check where the new temporaries are added. > > Regression-tested. The only change I see in the testsuite now is > > XPASS: gfortran.dg/goacc/kernels-loop-n.f95 -O scan-tree-dump-times > parloops1 "(?n)__attribute__\\(\\(oacc kernels parallelized, oacc > function \\(, , \\), oacc kernels, omp target entrypoint\\)\\)" 1 BTW, since this is done for the purpose of optimization, have you done testing on some suitable benchmark suite such as polyhedron, whether it a) generates any different code b) does it make it go faster? Is there a risk of performance regressions due to higher register pressure? -- Janne Blomqvist