From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <blomqvist.janne@gmail.com>
Received: from mail-wr1-x42b.google.com (mail-wr1-x42b.google.com [IPv6:2a00:1450:4864:20::42b])
	by sourceware.org (Postfix) with ESMTPS id 6EA1E385842E;
	Sun, 13 Nov 2022 10:13:39 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 6EA1E385842E
Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com
Received: by mail-wr1-x42b.google.com with SMTP id y16so12198574wrt.12;
        Sun, 13 Nov 2022 02:13:39 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:from:to:cc:subject:date:message-id:reply-to;
        bh=ga+Pmyr/pDHAQKZMYH8M5RbUulXMcrj0NEeziaNiPgk=;
        b=V+iLCAfb+L8K7zenQpuxcWUiA4/+v1I5n+kdPkdgcSAFrToCh/tFdnUy8Mdfmc9kSU
         2Wg4azbSS/Finq3C3gJO6+a7EIZOBGQ1lzchTcMEQzsS7WP+yl/u6h1d36J4B/Kpn9kd
         BnRTuyIVzMWnhmAeEI82MhEBLj5KH2/a3wH1LJYdKJi+a22Xko5FNcXXK2tZu1uxCRmb
         ixGjni6Z84+BIGP1BCckGf98tMaEGq7w7aSoUrjpkEQnDTSndjaRTg6A1ma3jDz7QZZZ
         spVSWFWzgERgh8dDTQ5bi8mDf7nQilsd1UaUi5+oK99lPEke5E373vcN2mOygMw5l9G/
         Ab2Q==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id
         :reply-to;
        bh=ga+Pmyr/pDHAQKZMYH8M5RbUulXMcrj0NEeziaNiPgk=;
        b=m4Cr54lr1aOy+FV7eYgZj0FBnaLS3MrYpG9KsUOmLqkDBuAxRXdUuU18sGzRCx46aX
         A9WTRVLzDQko+3JZ8SHo4ueJUUuqNXA3EOAVslPAw+OfL3ltE3uCddNtNtzWpg87oU42
         N+KtQBM42PKoOgFzRYUCZpppv2Myw6v0WQq1HpJisIN+HKTP4bkR5yTLoj2poGmlESf2
         Nv/PoAbq1rE8d3Grr5/ZqJ4Ln7ujcYDGNKydFRclq7SEk9KT6cFbW6ukzriNLH4TtaQz
         ZRHOv39Y+Dp+RPo/AkqDkNHziUdojMq44czcCSv0y1wXL/03g52ECwks6hYObSclT2tz
         uo4Q==
X-Gm-Message-State: ANoB5pk25Zo6u17UcihrnUrxhciPLx0sqwriPL3JIGS9XoEGQmzYhycS
	nLI/qL4enRwDYWzEjvdbTp6fPZOjhm4QnwSLlPk=
X-Google-Smtp-Source: AA0mqf78ONh0bUV9ISFNIV0bvUbRIho7zwQLyf2wmlbHixlTkwjZpOQncWUq8t/mpjaaATEvnIbORp0+B4XY7ga5SYg=
X-Received: by 2002:adf:f5c5:0:b0:22e:597:8541 with SMTP id
 k5-20020adff5c5000000b0022e05978541mr5210750wrp.612.1668334418025; Sun, 13
 Nov 2022 02:13:38 -0800 (PST)
MIME-Version: 1.0
References: <20221112234543.95441-1-aldot@gcc.gnu.org> <20221112234543.95441-4-aldot@gcc.gnu.org>
In-Reply-To: <20221112234543.95441-4-aldot@gcc.gnu.org>
From: Janne Blomqvist <blomqvist.janne@gmail.com>
Date: Sun, 13 Nov 2022 12:13:26 +0200
Message-ID: <CAO9iq9F0zveVgy13TPWAqw-T7hGU3qvT91W_Drc4CC3WGHa-qg@mail.gmail.com>
Subject: Re: [PATCH 3/5] Fortran: Narrow return types [PR78798]
To: Bernhard Reutner-Fischer <rep.dot.nop@gmail.com>
Cc: gcc-patches@gcc.gnu.org, Bernhard Reutner-Fischer <aldot@gcc.gnu.org>, fortran@gcc.gnu.org
Content-Type: text/plain; charset="UTF-8"
X-Spam-Status: No, score=-0.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <gcc-patches.gcc.gnu.org>

On Sun, Nov 13, 2022 at 1:47 AM Bernhard Reutner-Fischer via Fortran
<fortran@gcc.gnu.org> wrote:
> --- a/gcc/fortran/arith.cc
> +++ b/gcc/fortran/arith.cc
> @@ -1135,7 +1135,7 @@ compare_complex (gfc_expr *op1, gfc_expr *op2)
>     strings.  We return -1 for a < b, 0 for a == b and 1 for a > b.
>     We use the processor's default collating sequence.  */
>
> -int
> +signed char
>  gfc_compare_string (gfc_expr *a, gfc_expr *b)
>  {
>    size_t len, alen, blen, i;
> @@ -1162,7 +1162,7 @@ gfc_compare_string (gfc_expr *a, gfc_expr *b)
>  }

Hmm, really? PR 78798 mentions changing int to bool, where
appropriate, which I think is uncontroversial, but this?


-- 
Janne Blomqvist