From: Janne Blomqvist <blomqvist.janne@gmail.com>
To: Thomas Koenig <tkoenig@netcologne.de>
Cc: "fortran@gcc.gnu.org" <fortran@gcc.gnu.org>,
gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [patch, fortran] Implement maxloc and minloc for character
Date: Thu, 23 Nov 2017 13:25:00 -0000 [thread overview]
Message-ID: <CAO9iq9FSybi=rK04ah07MiS9K1v4KKhP=d3X7+20BQKzA8H4PA@mail.gmail.com> (raw)
In-Reply-To: <781c7918-5600-c488-0528-0c351ea04442@netcologne.de>
On Wed, Nov 22, 2017 at 8:10 PM, Thomas Koenig <tkoenig@netcologne.de> wrote:
> Hi Janne,
>
>>> So, attached is a new version of the patch. No update
>>> on the ChangeLog. OK for trunk?
>>
>> Yup, just really fix the copyright and string length stuff first. Thanks!
>
>
> Committed as rev 255070 with the fixes.
>
> There are still some files which mention Fortran 95, that can be fixed
> later.
That's ok, I wasn't expecting you to fix all such occurences, just the
new files you added.
However, to continue my nitpicking (sorry!), it seems that in many
cases compare_fcn still takes an integer length argument. Could you
make that gfc_charlen_type as well? Or maybe size_t, since the
argument is passed straight to memcmp{_char4} anyway? Please consider
such a patch pre-approved. Thanks!
--
Janne Blomqvist
next prev parent reply other threads:[~2017-11-23 12:56 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-19 22:04 Thomas Koenig
2017-11-20 8:41 ` Janne Blomqvist
2017-11-20 18:33 ` Thomas Koenig
2017-11-21 16:25 ` Janne Blomqvist
2017-11-21 19:53 ` Thomas Koenig
2017-11-21 20:47 ` Janne Blomqvist
2017-11-22 18:16 ` Thomas Koenig
2017-11-23 13:25 ` Janne Blomqvist [this message]
2017-11-23 14:03 ` Janne Blomqvist
2017-11-23 14:06 ` Ramana Radhakrishnan
2017-11-23 14:10 ` Janne Blomqvist
2017-11-23 18:40 ` Thomas Koenig
2017-11-24 9:33 ` Janne Blomqvist
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAO9iq9FSybi=rK04ah07MiS9K1v4KKhP=d3X7+20BQKzA8H4PA@mail.gmail.com' \
--to=blomqvist.janne@gmail.com \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=tkoenig@netcologne.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).