From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 98325 invoked by alias); 23 Nov 2017 12:56:41 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 98300 invoked by uid 89); 23 Nov 2017 12:56:40 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,KB_WAM_FROM_NAME_SINGLEWORD,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=no version=3.3.2 spammy=HTo:U*tkoenig, Hx-languages-length:877 X-Spam-User: qpsmtpd, 2 recipients X-HELO: mail-yb0-f177.google.com Received: from mail-yb0-f177.google.com (HELO mail-yb0-f177.google.com) (209.85.213.177) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 23 Nov 2017 12:56:39 +0000 Received: by mail-yb0-f177.google.com with SMTP id 188so7166570ybd.13; Thu, 23 Nov 2017 04:56:39 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=nd+cuMeZZFuFA5p3uKZkpI5pb6DhqrJeLLcKaS2hALI=; b=fESL2pm4PwEDFIl5alsyl3l2Qam6dM3jwX5k4iM9JIIt/pnFDww6RrQSdBhWc91u7R s4INNBb2x//JtfIG1/chz83RM/8M9aZ43eq8yax/w2aFCwdTzbnkbiUQ43XhKSt77Teo S8Wzzacca1koz6DC94bX4ypkdYBf5pB4v3kL0TJTkskxAcTS/feEg1oF+vgbeSe9kcb0 dqUKaErp7cAhdLyF9UJZrcmPcQrVVd2vJLxsWwFC6Mb78+nYm9irCKefcld0a0q1BJZx nOd6CitBomRU+ca1NbQ7AyyKZnEN2PSuOZ/KNbxx7hRlX+s807K7jC7PIiBVpspfAqIz WoWA== X-Gm-Message-State: AJaThX5bBiNPZQC/wKPCV1mv6FsD2eY/PLefL+bboodblnUROAp7wd55 A6LchalhEmQOHxrVhl7ysmobpedj0AJtQJXHnPA= X-Google-Smtp-Source: AGs4zMb/wwQooHKAYmnvDPpni0AelkIg6pxM8DD56yTLmqoB4/ciczTzF5LRvQ8z5Ytt3+/5hUUjVGQwjzctiG+yV2A= X-Received: by 10.37.50.151 with SMTP id y145mr14747563yby.61.1511441797676; Thu, 23 Nov 2017 04:56:37 -0800 (PST) MIME-Version: 1.0 Received: by 10.129.163.146 with HTTP; Thu, 23 Nov 2017 04:56:37 -0800 (PST) In-Reply-To: <781c7918-5600-c488-0528-0c351ea04442@netcologne.de> References: <44c7b39b-d849-e31a-7175-80bf1a348908@netcologne.de> <03e85917-b506-0d8b-78b0-263c371cba6a@netcologne.de> <09d35ad1-6883-0372-7a1a-840c8c4b07f9@netcologne.de> <781c7918-5600-c488-0528-0c351ea04442@netcologne.de> From: Janne Blomqvist Date: Thu, 23 Nov 2017 13:25:00 -0000 Message-ID: Subject: Re: [patch, fortran] Implement maxloc and minloc for character To: Thomas Koenig Cc: "fortran@gcc.gnu.org" , gcc-patches Content-Type: text/plain; charset="UTF-8" X-SW-Source: 2017-11/txt/msg02128.txt.bz2 On Wed, Nov 22, 2017 at 8:10 PM, Thomas Koenig wrote: > Hi Janne, > >>> So, attached is a new version of the patch. No update >>> on the ChangeLog. OK for trunk? >> >> Yup, just really fix the copyright and string length stuff first. Thanks! > > > Committed as rev 255070 with the fixes. > > There are still some files which mention Fortran 95, that can be fixed > later. That's ok, I wasn't expecting you to fix all such occurences, just the new files you added. However, to continue my nitpicking (sorry!), it seems that in many cases compare_fcn still takes an integer length argument. Could you make that gfc_charlen_type as well? Or maybe size_t, since the argument is passed straight to memcmp{_char4} anyway? Please consider such a patch pre-approved. Thanks! -- Janne Blomqvist