From: Janne Blomqvist <blomqvist.janne@gmail.com>
To: Steve Kargl <sgk@troutmask.apl.washington.edu>
Cc: Fortran List <fortran@gcc.gnu.org>,
GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] PR fortran/84922 -- Check MODULE prefix is used
Date: Thu, 22 Mar 2018 08:35:00 -0000 [thread overview]
Message-ID: <CAO9iq9F_gfGND_8tF9ibOVaYCU-mRRE_7HdFV4RwNLZeysHPaw@mail.gmail.com> (raw)
In-Reply-To: <20180321221906.GA76669@troutmask.apl.washington.edu>
On Thu, Mar 22, 2018 at 12:19 AM, Steve Kargl <
sgk@troutmask.apl.washington.edu> wrote:
> If an interface body includes a MODULE prefix on a subroutine
> or function, then the prefix must appear on the contained
> subprogram. This patch does that check, and issues an error
> message.
>
> 2018-03-21 Steven G. Kargl <kargl@gcc.gnu.org>
>
> PR fortran/84922
> * decl.c (get_proc_name): If the MODULE prefix appears in interface
> body, then it must appear on the contained subroutine or function.
> While here, fix nearby mis-indented code.
>
> 2018-03-21 Steven G. Kargl <kargl@gcc.gnu.org
>
> PR fortran/84922
> * gfortran.dg/interface_42.f90: New test.
> * gfortran.dg/interface_43.f90: New test.
> --
> Steve
>
In the testcase, please change the "modified by me" comment to specify who
"me" is.
Otherwise Ok.
--
Janne Blomqvist
next prev parent reply other threads:[~2018-03-22 8:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-21 22:30 Steve Kargl
2018-03-22 8:35 ` Janne Blomqvist [this message]
2018-03-22 19:35 ` Steve Kargl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAO9iq9F_gfGND_8tF9ibOVaYCU-mRRE_7HdFV4RwNLZeysHPaw@mail.gmail.com \
--to=blomqvist.janne@gmail.com \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=sgk@troutmask.apl.washington.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).