From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 91796 invoked by alias); 23 Nov 2017 13:53:30 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 91774 invoked by uid 89); 23 Nov 2017 13:53:30 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,KB_WAM_FROM_NAME_SINGLEWORD,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=no version=3.3.2 spammy=HTo:U*tkoenig, IRC, Hx-languages-length:1490, minloc2s.m4 X-Spam-User: qpsmtpd, 2 recipients X-HELO: mail-yw0-f171.google.com Received: from mail-yw0-f171.google.com (HELO mail-yw0-f171.google.com) (209.85.161.171) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 23 Nov 2017 13:53:28 +0000 Received: by mail-yw0-f171.google.com with SMTP id r186so8501377ywe.13; Thu, 23 Nov 2017 05:53:28 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=MlATRL8F5Fqk5NyMf+igUsOSVJIudyNN2AkCgggZ3wk=; b=QdNcjVvirZX9cw7IiBeKcWmS/Inb7IBh+8GCU978qWCgR8hdu0emZmgp6g46BsGz8o ZgIJ+L7nQwoOBbWf28H4fHstzdG7O7RBQ/zq5SCv1PKuMwwE5uF2n1vJRS94AhluCN0t 9Nxk/yzOufyPAEj2P/19eGXSct6bZr1E0VTk3fFhDfbmrQSjGavU6ur+qFSnTJBWYlvE vCXmcjJwyvwRLhd3P0NS3XT62YkcU7OVIQQ4eDL4nhSPMs2+Ibz0e//7DVwdj/un8POy QobqxDXH1kNPGwQVg7cW1Vko4eSuyVt99wPuOxS61FbSQgC96EoxegIV8RXekuEutNUF 29YQ== X-Gm-Message-State: AJaThX67Ckh2ahVhiUUW5Tz3sUFZBBx2AjxoW0UJXviSVCTWT5btrUEt 0CpDngdI0egCx6tOrXJ01oIm8fjc62qBuOhRy0YIOg== X-Google-Smtp-Source: AGs4zMY31aYDZspB2Q19CDWZooBidpsomDAR8xhZ0YZyVQHEKuNV2h+rsLpOf3dsN9D/zUyQdwm/P2VK09SAFGCNA8k= X-Received: by 10.129.174.76 with SMTP id g12mr16381805ywk.153.1511445207007; Thu, 23 Nov 2017 05:53:27 -0800 (PST) MIME-Version: 1.0 Received: by 10.129.163.146 with HTTP; Thu, 23 Nov 2017 05:53:26 -0800 (PST) In-Reply-To: References: <44c7b39b-d849-e31a-7175-80bf1a348908@netcologne.de> <03e85917-b506-0d8b-78b0-263c371cba6a@netcologne.de> <09d35ad1-6883-0372-7a1a-840c8c4b07f9@netcologne.de> <781c7918-5600-c488-0528-0c351ea04442@netcologne.de> From: Janne Blomqvist Date: Thu, 23 Nov 2017 14:03:00 -0000 Message-ID: Subject: Re: [patch, fortran] Implement maxloc and minloc for character To: Thomas Koenig Cc: "fortran@gcc.gnu.org" , gcc-patches Content-Type: text/plain; charset="UTF-8" X-SW-Source: 2017-11/txt/msg02133.txt.bz2 On Thu, Nov 23, 2017 at 2:56 PM, Janne Blomqvist wrote: > On Wed, Nov 22, 2017 at 8:10 PM, Thomas Koenig wrote: >> Hi Janne, >> >>>> So, attached is a new version of the patch. No update >>>> on the ChangeLog. OK for trunk? >>> >>> Yup, just really fix the copyright and string length stuff first. Thanks! >> >> >> Committed as rev 255070 with the fixes. >> >> There are still some files which mention Fortran 95, that can be fixed >> later. > > That's ok, I wasn't expecting you to fix all such occurences, just the > new files you added. > > However, to continue my nitpicking (sorry!), it seems that in many > cases compare_fcn still takes an integer length argument. Could you > make that gfc_charlen_type as well? Or maybe size_t, since the > argument is passed straight to memcmp{_char4} anyway? Please consider > such a patch pre-approved. Thanks! To continue, the prototypes are inconsistent too, e.g. m4/minloc2s.m4: extern 'rtype_name` 'name`'rtype_qual`_'atype_code` ('atype` * const restrict, int); export_proto('name`'rtype_qual`_'atype_code`); 'rtype_name` 'name`'rtype_qual`_'atype_code` ('atype` * const restrict array, gfc_charlen_type len) See also lines 77/82, and in maxloc2s.m4 lines 42/46 and 144/149. Thanks to James and Ramana on IRC, who are working on some target where gfc_charlen_type != int and reported build failures. -- Janne Blomqvist