From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 82641 invoked by alias); 11 Aug 2016 15:39:21 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 82615 invoked by uid 89); 11 Aug 2016 15:39:20 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.1 required=5.0 tests=AWL,BAYES_50,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1342, sk:sparc-s, sk:sparcs, sk:i386pc X-Spam-User: qpsmtpd, 2 recipients X-HELO: mail-wm0-f46.google.com Received: from mail-wm0-f46.google.com (HELO mail-wm0-f46.google.com) (74.125.82.46) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 11 Aug 2016 15:39:10 +0000 Received: by mail-wm0-f46.google.com with SMTP id i5so4163230wmg.0; Thu, 11 Aug 2016 08:39:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=tzdWM2CdViwat+ml5/IGuxozD1a0niXnUeZ/4gJGgaQ=; b=FPYC9Zys13h/DoRN5MYDgiwqDUI9uY5icyh+B1B8IEfX+7GIGuLv/bNR1U8aKQcHTX 6NF4DCkUW4QomHY8TeQnCuxrdf8li5TwYWLWck0L6Seefg9e0YfvEGL2ovZgl5XnMdzs s15sSDKwnIoBeJoD2ivah5r2DTZv4CiB/9tNvY/5Ri7mewEEqNOmz3VC3nJ4VaYqtH5S CL53zVglCBYiIRVRePiiEojFYcGhlX/XW6yj1cxUCXnj1WeMTpVggvtIn8l2NtWAxhKp gKo+YsqkLDtIoiWXVKvrqRm4XmdAKqiDa0AbHBOOt5fKPjo+Bhf/RMJGAOr91+qpZoWR D5BQ== X-Gm-Message-State: AEkoousFPEbY0p3bjmcc/BLphdd6p8/zQqaAYG7hAuNDk4bLWTAGt2nQ4ohf1x+HfgyjEQdwKVoFfMoisxbuiw== X-Received: by 10.194.40.166 with SMTP id y6mr10241448wjk.171.1470929948199; Thu, 11 Aug 2016 08:39:08 -0700 (PDT) MIME-Version: 1.0 Received: by 10.194.173.40 with HTTP; Thu, 11 Aug 2016 08:39:07 -0700 (PDT) In-Reply-To: References: <710d21ad-f79e-a681-bf1a-9be40c0382d6@charter.net> From: Janne Blomqvist Date: Thu, 11 Aug 2016 15:39:00 -0000 Message-ID: Subject: Re: [Patch, libfortran] Multi-threaded random_number To: Rainer Orth Cc: Jerry DeLisle , Fortran List , GCC Patches Content-Type: text/plain; charset=UTF-8 X-SW-Source: 2016-08/txt/msg00934.txt.bz2 On Thu, Aug 11, 2016 at 5:54 PM, Rainer Orth wrote: > Hi Janne, > >> committed a slightly modified patch as r239356. Changes from the >> submitted patch attached. To my surprise, it turned out that my >> fallback code using __gthread_key_{create,delete} and >> __ghtread_{get,set}_specific was faster than my TLS code, so I removed >> the TLS configure magic and the TLS code and just left the __gthread >> stuff in. > > this patch broke Solaris bootstrap: > > /vol/gcc/src/hg/trunk/local/libgfortran/intrinsics/random.c: In function 'constructor_random': > /vol/gcc/src/hg/trunk/local/libgfortran/intrinsics/ > random.c:915:45: error: 'free' undeclared (first use in this function); did you mean 'frexp'? > __gthread_key_create (&rand_state_key, &free); > ^~~~ > frexp > /vol/gcc/src/hg/trunk/local/libgfortran/intrinsics/random.c:915:45: note: each undeclared identifier is reported only once for each function it appears in > > You need to include for the free declaration, as this patch > does. Allowed i386-pc-solaris2.12 and sparc-sun-solaris2.12 to > continue. I'm going to install this as obvious. Oh, I (incorrectly, obviously!) remembered that stdlib.h would be included via libgfortran.h. Thanks for the quick fix! -- Janne Blomqvist