From: Janne Blomqvist <blomqvist.janne@gmail.com>
To: Andreas Schwab <schwab@suse.de>
Cc: Fortran List <fortran@gcc.gnu.org>,
GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [Patch, libfortran] Multi-threaded random_number
Date: Mon, 01 Aug 2016 11:00:00 -0000 [thread overview]
Message-ID: <CAO9iq9FwbcKBTpBOofu9F4YrDGTHD0=LN0CsFF7abPXTim8TzA@mail.gmail.com> (raw)
In-Reply-To: <mvmshuozrw4.fsf@hawking.suse.de>
On Mon, Aug 1, 2016 at 1:48 PM, Andreas Schwab <schwab@suse.de> wrote:
> On Mo, Aug 01 2016, Janne Blomqvist <blomqvist.janne@gmail.com> wrote:
>
>> PING?
>>
>> Also, a minor bugfix on top of the previous patch:
>>
>> diff --git a/libgfortran/intrinsics/random.c b/libgfortran/intrinsics/random.c
>> index 9b54a02..21395ea 100644
>> --- a/libgfortran/intrinsics/random.c
>> +++ b/libgfortran/intrinsics/random.c
>> @@ -787,7 +787,7 @@ random_seed_i4 (GFC_INTEGER_4 *size, gfc_array_i4
>> *put, gfc_array_i4 *get)
>> init_rand_state (true);
>>
>> /* Copy p & 15 */
>> - rand_state.p = put->base_addr[SZ * GFC_DESCRIPTOR_STRIDE(put, 0)] & 15;
>> + rand_state.p = put->base_addr[SZ * GFC_DESCRIPTOR_STRIDE(put, 0)] % 15;
>
> The comment no longer fits.
Indeed, thanks. I've fixed it in my own tree.
--
Janne Blomqvist
next prev parent reply other threads:[~2016-08-01 11:00 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-24 13:45 Janne Blomqvist
2016-08-01 10:42 ` Janne Blomqvist
2016-08-01 10:48 ` Andreas Schwab
2016-08-01 11:00 ` Janne Blomqvist [this message]
2016-08-08 11:01 ` Janne Blomqvist
2016-08-09 5:01 ` Jerry DeLisle
2016-08-10 11:12 ` Janne Blomqvist
2016-08-11 9:02 ` Janne Blomqvist
2016-08-11 14:55 ` Rainer Orth
2016-08-11 15:39 ` Janne Blomqvist
2016-08-12 10:07 ` Thomas Schwinge
2016-08-12 10:37 ` Janne Blomqvist
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAO9iq9FwbcKBTpBOofu9F4YrDGTHD0=LN0CsFF7abPXTim8TzA@mail.gmail.com' \
--to=blomqvist.janne@gmail.com \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=schwab@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).