From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 68741 invoked by alias); 23 Aug 2015 19:59:08 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 68722 invoked by uid 89); 23 Aug 2015 19:59:07 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_05,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-Spam-User: qpsmtpd, 2 recipients X-HELO: mail-io0-f177.google.com Received: from mail-io0-f177.google.com (HELO mail-io0-f177.google.com) (209.85.223.177) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Sun, 23 Aug 2015 19:59:06 +0000 Received: by iodb91 with SMTP id b91so128038229iod.1; Sun, 23 Aug 2015 12:59:04 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.107.3.19 with SMTP id 19mr16307982iod.132.1440359944624; Sun, 23 Aug 2015 12:59:04 -0700 (PDT) Received: by 10.79.35.102 with HTTP; Sun, 23 Aug 2015 12:59:04 -0700 (PDT) In-Reply-To: References: Date: Sun, 23 Aug 2015 20:14:00 -0000 Message-ID: Subject: Re: [patch,libgfortran,toplevel] Use libbacktrace in libgfortran From: Janne Blomqvist To: FX Cc: Uros Bizjak , "gcc-patches@gcc.gnu.org" , Fortran List Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-SW-Source: 2015-08/txt/msg01377.txt.bz2 On Fri, Aug 14, 2015 at 5:18 PM, FX wrote: >>> Use libbacktrace (instead of our own unwind-based code) to display back= traces from libgfortran >>> upon error or user request. >>> >>> 1. In toplevel Makefile.def, make libgfortran depend on libbacktrace (n= eeds global reviewer >>> approval) >>> 2. In gcc/fortran/config-lang.in, add libbacktrace to target_libs >>> 3. In libgfortran, we remove our own code and substitute calls to libb= acktrace >>> >>> Bootstrapped and regtested on x86_64-pc-linux-gnu (which has full libba= cktrace support) and >>> x86_64-apple-darwin14 (which has minimal libbacktrace support). OK to c= ommit to trunk? >> >> backtrace.ChangeLog is unreadable for me =E2=80=A6 > > Sending again, this time with .txt extension, hoping this makes it go thr= ough OK. Awesome! Looks good. I only have one small bikeshed request: Can you make the output format match the existing code? (As there seems to be no GNU (or otherwise) standard how backtraces should look, in order to minimize user confusion I made the current code produce output matching gdb backtraces as close as seemed reasonable.) Ok with that change. --=20 Janne Blomqvist