From: Janne Blomqvist <blomqvist.janne@gmail.com>
To: Thomas Koenig <tkoenig@netcologne.de>
Cc: "Joseph S. Myers" <joseph@codesourcery.com>,
GCC Patches <gcc-patches@gcc.gnu.org>,
Fortran List <fortran@gcc.gnu.org>,
libstdc++@gcc.gnu.org, bkorb@gnu.org, ibuclaw@gdcproject.org,
Ian Lance Taylor <ian@airs.com>, Jakub Jelinek <jakub@redhat.com>,
cmtice@google.com, simon.marchi@ericsson.com
Subject: Re: Update GCC to autoconf 2.69, automake 1.15.1
Date: Wed, 31 Oct 2018 09:14:00 -0000 [thread overview]
Message-ID: <CAO9iq9GdZqa0M5TrsZ1oWHWS0pEbai-ANFG2NZgjC+XXZQUL+w@mail.gmail.com> (raw)
In-Reply-To: <b55b056d-30d4-1c3d-48c4-1b1429135347@netcologne.de>
On Wed, Oct 31, 2018 at 9:12 AM Thomas Koenig <tkoenig@netcologne.de> wrote:
> > Makefile.am:48: warning: source file 'caf/single.c' is in a subdirectory,
> > Makefile.am:48: but option 'subdir-objects' is disabled
> > automake: warning: possible forward-incompatibility.
> > automake: At least a source file is in a subdirectory, but the
> 'subdir-objects'
> > automake: automake option hasn't been enabled. For now, the
> corresponding output
> > automake: object file(s) will be placed in the top-level directory.
> However,
> > automake: this behaviour will change in future Automake versions: they
> > will
> > automake: unconditionally cause object files to be placed in the same
> subdirectory
> > automake: of the corresponding sources.
> > automake: You are advised to start using 'subdir-objects' option
> throughout your
> > automake: project, to avoid future incompatibilities.
> >
> > I think it's best for the relevant maintainers to add subdir-objects
> > and do any other associated Makefile.am changes needed. In some cases
> > the paths in the warnings involved ../; I don't know if that adds any
> > extra complications to the use of subdir-objects.
>
> I'm not an automake expert, but I hope to be able to figure out
> what is needed. If not, I guess I'll just ask :-)
>
My understanding is that we need to add 'subdir-objects' to
AM_INIT_AUTOMAKE in configure.ac.
See e.g. https://autotools.io/automake/options.html
(that site is pretty good for describing 'best practices' for modern
autotools; there's unfortunately a lot of very outdated autotools tutorials
around)
What is the plan for the previous branches? Currently, it is necessary
> to keep around a special version of automake etc for
> --enable-maintainer-mode to work. Backporting a patch which
> involves regeneration of files in libgfortran/generated from
> the files in libgfortan/m4 would then require keeping two versions
> of the relevant tools around, and switching between them.
>
> Would it make sense to backport because of this?
>
+1
--
Janne Blomqvist
next prev parent reply other threads:[~2018-10-31 8:37 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-31 6:35 Joseph Myers
2018-10-31 8:47 ` Thomas Koenig
2018-10-31 9:14 ` Janne Blomqvist [this message]
2018-10-31 10:04 ` Richard Biener
2018-10-31 17:34 ` Joseph Myers
2018-10-31 21:55 ` Ian Lance Taylor
2018-11-01 19:43 ` Janne Blomqvist
2023-05-15 19:07 ` Back to requiring "Perl version 5.6.1 (or later)" [PR82856] (was: Update GCC to autoconf 2.69, automake 1.15.1) Thomas Schwinge
2018-10-31 10:09 ` Update GCC to autoconf 2.69, automake 1.15.1 Richard Biener
2018-10-31 14:36 ` Ian Lance Taylor
2018-10-31 14:41 ` Simon Marchi
2018-10-31 17:40 ` Joseph Myers
2018-10-31 17:22 ` Eric Gallager
2018-10-31 18:39 ` Joseph Myers
2018-12-03 3:39 ` Iain Buclaw
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAO9iq9GdZqa0M5TrsZ1oWHWS0pEbai-ANFG2NZgjC+XXZQUL+w@mail.gmail.com \
--to=blomqvist.janne@gmail.com \
--cc=bkorb@gnu.org \
--cc=cmtice@google.com \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=ian@airs.com \
--cc=ibuclaw@gdcproject.org \
--cc=jakub@redhat.com \
--cc=joseph@codesourcery.com \
--cc=libstdc++@gcc.gnu.org \
--cc=simon.marchi@ericsson.com \
--cc=tkoenig@netcologne.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).