Re: [libgfortran, patch] Rename numeric STOP runtime functions

[Janne Blomqvist <blomqvist.janne@gmail.com>]

On Mon, Dec 19, 2016 at 4:13 PM, FX <fxcoudert@gmail.com> wrote:
> When support for F2008 requirements on numeric STOP statements was implemented, the old _gfortran_stop_numeric() runtime function was made obsolete and a new _gfortran_stop_numeric_f08() function was created, which is the only one used in the front-end nowadays. The old _gfortran_stop_numeric() was kept in libgfortran for ABI compatibility.
>
> Now that we are breaking the ABI, the attached patch removes the older _gfortran_stop_numeric() function, and renames the _gfortran_stop_numeric_f08() function into _gfortran_stop_numeric(). That way, it is in line with the names of all other PAUSE/STOP/ERROR STOP runtime functions.
>
> Bootstrapped and regtested on x86_64-apple-darwin16.3.0.
> OK to commit?

The patch you posted contains some apparently unrelated changes to
gfortran.map. Without those, Ok.

As a minor cosmetic improvement, you could fold_convert the argument
to integer_type_node instead of gfc_int4_type_node and change the
library functions to take plain C int arguments, since the exit()
argument is a C int anyways.



-- 
Janne Blomqvist