From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32265 invoked by alias); 3 Jul 2011 20:36:14 -0000 Received: (qmail 32183 invoked by uid 22791); 3 Jul 2011 20:36:13 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW X-Spam-Check-By: sourceware.org Received: from mail-pz0-f47.google.com (HELO mail-pz0-f47.google.com) (209.85.210.47) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 03 Jul 2011 20:35:36 +0000 Received: by pzk36 with SMTP id 36so2271916pzk.20 for ; Sun, 03 Jul 2011 13:35:36 -0700 (PDT) MIME-Version: 1.0 Received: by 10.68.15.134 with SMTP id x6mr2995968pbc.217.1309725336111; Sun, 03 Jul 2011 13:35:36 -0700 (PDT) Received: by 10.68.62.103 with HTTP; Sun, 3 Jul 2011 13:35:36 -0700 (PDT) In-Reply-To: <4E0E1269.2070007@netcologne.de> References: <4E0A4C94.7030602@netcologne.de> <4E0CBBF3.8040809@netcologne.de> <4E0E1269.2070007@netcologne.de> Date: Sun, 03 Jul 2011 20:36:00 -0000 Message-ID: Subject: Re: [patch, fortran] Always return malloc(1) for empty arrays in the library From: Janne Blomqvist To: Thomas Koenig Cc: "fortran@gcc.gnu.org" , gcc-patches Content-Type: text/plain; charset=UTF-8 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-07/txt/msg00157.txt.bz2 On Fri, Jul 1, 2011 at 21:31, Thomas Koenig wrote: > Is this better? Index: runtime/memory.c =================================================================== --- runtime/memory.c (Revision 175598) +++ runtime/memory.c (Arbeitskopie) @@ -54,8 +54,8 @@ get_mem (size_t n) void * internal_malloc_size (size_t size) { - if (size == 0) - return NULL; + if (unlikely (size <= 0)) + size = 1; return get_mem (size); } Since size_t is unsigned, just test (size == 0). Otherwise Ok. Thanks for the patch. -- Janne Blomqvist