From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-473621-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 59094 invoked by alias); 20 Feb 2018 19:10:40 -0000
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
Received: (qmail 59075 invoked by uid 89); 20 Feb 2018 19:10:40 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=
X-Spam-User: qpsmtpd, 2 recipients
X-HELO: mail-yb0-f170.google.com
Received: from mail-yb0-f170.google.com (HELO mail-yb0-f170.google.com) (209.85.213.170) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 20 Feb 2018 19:10:39 +0000
Received: by mail-yb0-f170.google.com with SMTP id p77-v6so2808501yba.5;        Tue, 20 Feb 2018 11:10:38 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;        d=1e100.net; s=20161025;        h=x-gm-message-state:mime-version:in-reply-to:references:from:date         :message-id:subject:to:cc;        bh=x8yURmze+DurGFy96nwNagITpeEwkN2rgydDa9hmPU0=;        b=EWD4ODPz7ljYgQ5Nt6u8kOAW7iw6T9rLtGzQXj/95UpwS4za1/vB7eLPFtoaUVw06U         5JC7JhddVgBrvRlP9YUPTLXn4VytUqGBFKCYcuA2nAd6SoB2LK1Cl8CitwNeVBUBK6dU         ro4POBspknJxu9wJNR4Ty2AstYr8g80iuIWXHr1FLaEkIztglPALkVGF9UUW+29E8xC4         xAm3elw5O7t//ZXgCMoyVf/17dXvLvl64ZlDeU+gbH66KopCzRXZK8N1tXgUvjhK81lz         GAGBs3S2fO7WsQCFtfwvTXJWqAl3eN1DEJ5bD5opuH/Ux/w7Rik2x31KOYulO3+llBKz         3CiQ==
X-Gm-Message-State: APf1xPC+p6kX7jJNcLSB5w/TJo96XmEiwKB09RqQ8lBawh0XDClO9ojp	gH1N/04792R1ws5xgDZKhKWJOjjdlp+WWFHSQHw=
X-Google-Smtp-Source: AH8x227Gn0fh6qwAh532P42X6hptuxM88kkjhkCWBx/neqNOTZdr7cQ1phFhEYX4+tpkbW3I4mfSQ43GGeACKCDDqVY=
X-Received: by 2002:a25:dc51:: with SMTP id y78-v6mr564648ybe.385.1519153837344; Tue, 20 Feb 2018 11:10:37 -0800 (PST)
MIME-Version: 1.0
Received: by 10.129.241.4 with HTTP; Tue, 20 Feb 2018 11:10:36 -0800 (PST)
In-Reply-To: <51ac36d5-cc4a-eebe-f454-fdb355ffc0ad@netcologne.de>
References: <a4470f1d-a946-a5bf-7934-5ef8e88ac3d9@netcologne.de> <CAO9iq9EdSx-07ni3CbBrUzxnVLme-ynSfTrt-r+D_zx95PgU8Q@mail.gmail.com> <51ac36d5-cc4a-eebe-f454-fdb355ffc0ad@netcologne.de>
From: Janne Blomqvist <blomqvist.janne@gmail.com>
Date: Tue, 20 Feb 2018 19:10:00 -0000
Message-ID: <CAO9iq9HaZZojdokA+=BOpuwNZk=KEj2Etc-Sy7Q_Vx0bCWc5tA@mail.gmail.com>
Subject: Re: [patch, fortran] Fix character length in constructors
To: Thomas Koenig <tkoenig@netcologne.de>
Cc: "fortran@gcc.gnu.org" <fortran@gcc.gnu.org>, gcc-patches <gcc-patches@gcc.gnu.org>
Content-Type: text/plain; charset="UTF-8"
X-SW-Source: 2018-02/txt/msg01189.txt.bz2

On Tue, Feb 20, 2018 at 8:59 PM, Thomas Koenig <tkoenig@netcologne.de> wrote:
> Am 20.02.2018 um 08:51 schrieb Janne Blomqvist:
>
>> It's better to use gfc_mpz_get_hwi() instead of mpz_get_si().
>> mpz_get_si() returns a long, which is a 32-bit type on win64.
>>
>> Otherwise Ok with the spelling fix suggested by Steve.
>
>
> Committed as r257856.
>
> Thanks to you and Steve for the review and the heads_up about
> gfc_mpz_get_hwi.
>
> I also changed the "call abort" to "STOP 1" at the last second
> (old habits are hard to break, it seems :-)

Shouldn't the second one be "stop 2"?


-- 
Janne Blomqvist