From: Janne Blomqvist <blomqvist.janne@gmail.com>
To: Steve Kargl <sgk@troutmask.apl.washington.edu>
Cc: Fortran List <fortran@gcc.gnu.org>,
GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] fortran/69121 -- Make IEEE_SCALB generic
Date: Fri, 21 Dec 2018 09:08:00 -0000 [thread overview]
Message-ID: <CAO9iq9Hch7+rLFOfYZWHVQUoD3dkcGTNmjN_toLnCoUkRt=6LQ@mail.gmail.com> (raw)
In-Reply-To: <20181221062240.GA99794@troutmask.apl.washington.edu>
On Fri, Dec 21, 2018 at 8:22 AM Steve Kargl <
sgk@troutmask.apl.washington.edu> wrote:
> On Thu, Dec 20, 2018 at 01:47:39PM -0800, Steve Kargl wrote:
> > The attached patch has been tested on x86_64-*-freebsd.
> >
> > OK to commit?
> >
> > 2018-12-20 Steven G. Kargl <kargl@gcc.gnu.org>
> >
> > PR fortran/69121
> > * libgfortran/ieee/ieee_arithmetic.F90: Provide missing functions
> > in interface for IEEE_SCALB.
> >
> > 2018-12-20 Steven G. Kargl <kargl@gcc.gnu.org>
> >
> > PR fortran/69121
> > * gfortran.dg/ieee/ieee_9.f90: New test.
>
> Now, tested on i586-*-freebsd.
>
> --
> Steve
>
Hi, looks ok for trunk.
A few questions popped into my mind while looking into this:
1) Why are none of the _gfortran_ieee_scalb_X_Y functions mentioned in
gfortran.map? I guess they should all be there?
2) Currently all the intrinsics map to the scalbn{,f,l} builtins. However,
when the integer argument is of kind int64 or int128 we should instead use
scalbln{,f,l}. This also applies to other intrinsics that use scalbn under
the hood.
To clarify, fixing these is not a prerequisite for accepting the patch (I
already accepted it), but more like topics for further work.
--
Janne Blomqvist
next prev parent reply other threads:[~2018-12-21 9:07 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-20 21:53 Steve Kargl
2018-12-21 6:46 ` Steve Kargl
2018-12-21 9:08 ` Janne Blomqvist [this message]
2018-12-21 15:55 ` Steve Kargl
2018-12-21 17:35 ` Thomas Koenig
2018-12-21 18:57 ` Steve Kargl
2018-12-21 17:59 ` Steve Kargl
2018-12-21 19:11 ` Janne Blomqvist
2018-12-21 19:33 ` Steve Kargl
2018-12-21 20:01 ` Joseph Myers
2018-12-21 20:29 ` Steve Kargl
2018-12-24 14:14 ` Sudakshina Das
2018-12-24 18:05 ` Steve Kargl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAO9iq9Hch7+rLFOfYZWHVQUoD3dkcGTNmjN_toLnCoUkRt=6LQ@mail.gmail.com' \
--to=blomqvist.janne@gmail.com \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=sgk@troutmask.apl.washington.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).