From: Janne Blomqvist <blomqvist.janne@gmail.com>
To: Thomas Koenig <tkoenig@netcologne.de>
Cc: "fortran@gcc.gnu.org" <fortran@gcc.gnu.org>,
gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [patch, fortran] Implement maxloc and minloc for character
Date: Mon, 20 Nov 2017 08:41:00 -0000 [thread overview]
Message-ID: <CAO9iq9HtY-p2KB9E4o8bf0gsasqyoEx-kFh+sANVhLzz7stWGA@mail.gmail.com> (raw)
In-Reply-To: <44c7b39b-d849-e31a-7175-80bf1a348908@netcologne.de>
On Sun, Nov 19, 2017 at 11:11 PM, Thomas Koenig <tkoenig@netcologne.de> wrote:
> There is one question regarding the ABI. Apparently, the string length
> is passed as an int even on a 64-bit system. I verified that this
> is indeed the case by doing the actual work on a
> powerpc64-unknown-linux-gnu box (gcc110 on the gcc compile farm),
> which is big-endian. If we were actually passing an eight-byte
> quantity, and only getting the upper bytes, we would crash & burn.
>
> Now, I _thought_ we were passing string lengths as size_t now (Janne?),
> but maybe something was missing in that change.
Unfortunately I had to revert the charlen->size_t patch since it
caused regressions on aix/power (presumably due to endianness issues).
I did fix a potential bug there, but I never got any response to my
request to get an account on the gcc compile farm to test it, and gcc
7 stage3 was closing so I ran out of time.
There's apparently some other process for getting compile farm
accounts nowadays, and we have broken the ABI again for gcc 8, so
maybe I should dust off the patch and try again. Or what do you think?
--
Janne Blomqvist
next prev parent reply other threads:[~2017-11-20 8:31 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-19 22:04 Thomas Koenig
2017-11-20 8:41 ` Janne Blomqvist [this message]
2017-11-20 18:33 ` Thomas Koenig
2017-11-21 16:25 ` Janne Blomqvist
2017-11-21 19:53 ` Thomas Koenig
2017-11-21 20:47 ` Janne Blomqvist
2017-11-22 18:16 ` Thomas Koenig
2017-11-23 13:25 ` Janne Blomqvist
2017-11-23 14:03 ` Janne Blomqvist
2017-11-23 14:06 ` Ramana Radhakrishnan
2017-11-23 14:10 ` Janne Blomqvist
2017-11-23 18:40 ` Thomas Koenig
2017-11-24 9:33 ` Janne Blomqvist
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAO9iq9HtY-p2KB9E4o8bf0gsasqyoEx-kFh+sANVhLzz7stWGA@mail.gmail.com \
--to=blomqvist.janne@gmail.com \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=tkoenig@netcologne.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).