From: Martin Galvan <martin.galvan@tallertechnologies.com>
To: ramrad01@arm.com
Cc: gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PING 2][PATCH] libgcc: Add CFI directives to the soft floating point support code for ARM
Date: Mon, 04 May 2015 20:51:00 -0000 [thread overview]
Message-ID: <CAOKbPbazm2KdLXwS_vbrHa+jTZM2e0nEjhGqBfM1367qUWwkdg@mail.gmail.com> (raw)
In-Reply-To: <CAOKbPbaxj69gvdMbWvMLdDhixevw9RO0J8XWE6Y7qFqQfqTG1w@mail.gmail.com>
Hi Ramana! Sorry to bother, but I looked at the repository and didn't
see this committed. As I don't have write access could you please
commit this for me?
Thanks a lot!
On Tue, Apr 28, 2015 at 2:07 PM, Martin Galvan
<martin.galvan@tallertechnologies.com> wrote:
> Thanks a lot. I don't have write access to the repository, could you
> commit this for me?
>
> On Tue, Apr 28, 2015 at 1:21 PM, Ramana Radhakrishnan
> <ramana.gcc@googlemail.com> wrote:
>> On Tue, Apr 28, 2015 at 4:19 PM, Martin Galvan
>> <martin.galvan@tallertechnologies.com> wrote:
>>> This patch adds CFI directives to the soft floating point support code for ARM.
>>>
>>> Previously, if we tried to do a backtrace from that code in a debug session we'd
>>> get something like this:
>>>
>>> (gdb) bt
>>> #0 __nedf2 () at ../../../../../../gcc-4.9.2/libgcc/config/arm/ieee754-df.S:1082
>>> #1 0x00000db6 in __aeabi_cdcmple () at ../../../../../../gcc-4.9.2/libgcc/config/arm/ieee754-df.S:1158
>>> #2 0xf5c28f5c in ?? ()
>>> Backtrace stopped: previous frame identical to this frame (corrupt stack?)
>>>
>>> Now we'll get something like this:
>>>
>>> (gdb) bt
>>> #0 __nedf2 () at ../../../../../../gcc-4.9.2/libgcc/config/arm/ieee754-df.S:1156
>>> #1 0x00000db6 in __aeabi_cdcmple () at ../../../../../../gcc-4.9.2/libgcc/config/arm/ieee754-df.S:1263
>>> #2 0x00000dc8 in __aeabi_dcmpeq () at ../../../../../../gcc-4.9.2/libgcc/config/arm/ieee754-df.S:1285
>>> #3 0x00000504 in main ()
>>>
>>> I have a company-wide copyright assignment. I don't have commit access, though, so it would be great if anyone could commit this for me.
>>>
>>> Thanks a lot!
>>>
>>
>> this is OK , thanks. Sorry about the delay in reviewing this.
>>
>> Ramana
next prev parent reply other threads:[~2015-05-04 20:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-28 15:51 Martin Galvan
2015-04-28 16:22 ` Ramana Radhakrishnan
2015-04-28 17:10 ` Martin Galvan
2015-05-04 20:51 ` Martin Galvan [this message]
2015-05-10 22:16 ` Fwd: " Martin Galvan
2015-05-11 7:45 ` Ramana Radhakrishnan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOKbPbazm2KdLXwS_vbrHa+jTZM2e0nEjhGqBfM1367qUWwkdg@mail.gmail.com \
--to=martin.galvan@tallertechnologies.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=ramrad01@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).