From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 72030 invoked by alias); 4 May 2015 20:51:23 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 72019 invoked by uid 89); 4 May 2015 20:51:22 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-la0-f54.google.com Received: from mail-la0-f54.google.com (HELO mail-la0-f54.google.com) (209.85.215.54) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Mon, 04 May 2015 20:51:21 +0000 Received: by layy10 with SMTP id y10so113171263lay.0 for ; Mon, 04 May 2015 13:51:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type; bh=BgN9fuxuHuAUJ48lT2InzslHelTjJZunoToRmqxYuns=; b=aTq1fL3sSR2p2UYpHO2lqvwTQyJ1pFl71Y50pWLfVjNvi/uzrjREOOeCJm4513FPLg IFOQ2U911AdMgJRwbv/kjjolN915dg2vEWLJ4yE9MEFxDqVDWF8zQlE0/OhWg/Buv9VZ 66Kx3OsU9sO++ee9JM97S7hBbSqVJECWuBEQDdnEC56bu6JPzo6/ipT1CiTLijvCGmWl EtAVlKoJLzqBtfDPPfDS/lz42e0qExAj1mjfmDLN2dirujoIQPvDlZnNi1jRWe9vrrHA SZ1M5IkEwQo9CrscCHwvSK/6SRkUSTwLawYOeLAEiyiUY5S4ORAYrLad2hO5jt4buB9E USNQ== X-Gm-Message-State: ALoCoQlFyLPtSJ8/l0X6hwJyDckqWTnaDxbwX9vW87z2bwpsqrS7BdLhU+MSXjgBeKVioK6Sb8Kj X-Received: by 10.152.42.211 with SMTP id q19mr21537526lal.78.1430772678163; Mon, 04 May 2015 13:51:18 -0700 (PDT) MIME-Version: 1.0 Received: by 10.112.52.71 with HTTP; Mon, 4 May 2015 13:50:37 -0700 (PDT) In-Reply-To: References: <1430234381-7900-1-git-send-email-martin.galvan@tallertechnologies.com> From: Martin Galvan Date: Mon, 04 May 2015 20:51:00 -0000 Message-ID: Subject: Re: [PING 2][PATCH] libgcc: Add CFI directives to the soft floating point support code for ARM To: ramrad01@arm.com Cc: gcc-patches Content-Type: text/plain; charset=UTF-8 X-SW-Source: 2015-05/txt/msg00257.txt.bz2 Hi Ramana! Sorry to bother, but I looked at the repository and didn't see this committed. As I don't have write access could you please commit this for me? Thanks a lot! On Tue, Apr 28, 2015 at 2:07 PM, Martin Galvan wrote: > Thanks a lot. I don't have write access to the repository, could you > commit this for me? > > On Tue, Apr 28, 2015 at 1:21 PM, Ramana Radhakrishnan > wrote: >> On Tue, Apr 28, 2015 at 4:19 PM, Martin Galvan >> wrote: >>> This patch adds CFI directives to the soft floating point support code for ARM. >>> >>> Previously, if we tried to do a backtrace from that code in a debug session we'd >>> get something like this: >>> >>> (gdb) bt >>> #0 __nedf2 () at ../../../../../../gcc-4.9.2/libgcc/config/arm/ieee754-df.S:1082 >>> #1 0x00000db6 in __aeabi_cdcmple () at ../../../../../../gcc-4.9.2/libgcc/config/arm/ieee754-df.S:1158 >>> #2 0xf5c28f5c in ?? () >>> Backtrace stopped: previous frame identical to this frame (corrupt stack?) >>> >>> Now we'll get something like this: >>> >>> (gdb) bt >>> #0 __nedf2 () at ../../../../../../gcc-4.9.2/libgcc/config/arm/ieee754-df.S:1156 >>> #1 0x00000db6 in __aeabi_cdcmple () at ../../../../../../gcc-4.9.2/libgcc/config/arm/ieee754-df.S:1263 >>> #2 0x00000dc8 in __aeabi_dcmpeq () at ../../../../../../gcc-4.9.2/libgcc/config/arm/ieee754-df.S:1285 >>> #3 0x00000504 in main () >>> >>> I have a company-wide copyright assignment. I don't have commit access, though, so it would be great if anyone could commit this for me. >>> >>> Thanks a lot! >>> >> >> this is OK , thanks. Sorry about the delay in reviewing this. >> >> Ramana