From: Ulrich Drepper <drepper.fsp@gmail.com>
To: Michael Collison <Michael.Collison@arm.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>, nd <nd@arm.com>
Subject: Re: PATCH v2][Aarch64] Add vectorized mersenne twister
Date: Tue, 18 Jul 2017 07:25:00 -0000 [thread overview]
Message-ID: <CAOPLpQfqtQZH-hOejwXN=R0Ga_OhbpMUNk1fvdY_Kki2ag5sxg@mail.gmail.com> (raw)
In-Reply-To: <HE1PR0802MB23775781E0A58467C040B0F995A10@HE1PR0802MB2377.eurprd08.prod.outlook.com>
On Tue, Jul 18, 2017 at 7:57 AM, Michael Collison
<Michael.Collison@arm.com> wrote:
> This is the second version of a patch for Aarc64 to add a vectorized mersenne twister to libstdc++. The first version used intrinsics and included "arm_neon.h". After feedback from the community this version uses only GCC vector extensions and Aarch64 simd data types.
Looks OK. Just stylistically, why do you have
+#ifdef __ARM_NEON
+#ifdef __aarch64__
(in more than one place) instead of one preprocessor line?
next prev parent reply other threads:[~2017-07-18 7:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-18 5:58 Michael Collison
2017-07-18 7:25 ` Ulrich Drepper [this message]
2017-07-18 7:26 ` Michael Collison
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOPLpQfqtQZH-hOejwXN=R0Ga_OhbpMUNk1fvdY_Kki2ag5sxg@mail.gmail.com' \
--to=drepper.fsp@gmail.com \
--cc=Michael.Collison@arm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=nd@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).