From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-458368-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 106038 invoked by alias); 18 Jul 2017 07:25:08 -0000
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
Received: (qmail 99244 invoked by uid 89); 18 Jul 2017 07:24:27 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.2 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy=Hx-languages-length:558
X-HELO: mail-qk0-f169.google.com
Received: from mail-qk0-f169.google.com (HELO mail-qk0-f169.google.com) (209.85.220.169) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 18 Jul 2017 07:24:26 +0000
Received: by mail-qk0-f169.google.com with SMTP id t2so6638281qkc.1        for <gcc-patches@gcc.gnu.org>; Tue, 18 Jul 2017 00:24:23 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;        d=1e100.net; s=20161025;        h=x-gm-message-state:mime-version:sender:in-reply-to:references:from         :date:message-id:subject:to:cc:content-transfer-encoding;        bh=vRpY/l51sUxX3Ivds5LeZBqBFvybqGTHvSVyHutDIC4=;        b=WK6stUWAwzecVgTiClPNOhJjTBeKFJL+iG1wDpSN6t+IlMhYMT77FO3ufBOiVFlf1c         T8tXkzvP9d1Ji5SEQmW6y+TuKke4xFjWDfXqBJOYtp5/TKgApmn1Cn5MnAsmyOjsYSwm         ow60wlqSaQiL/Qh2nyHdjMvTtnzr17mu6C8Iqe2oFkxqVnrMxJkmnQu661gCA7qQL/6n         zkFBi3gpa4XWLntNBJ6lwHwlCiYev60jGurdQK23vsw2aX/pd7zckVHa6quSk2sSq3Yn         /O56xsf9JdujDV1qtEnXYzPrIfuwgCoCWmS3JsuSSCAJVPsEKgHlSmJqctZvsW3eNUIg         0Icg==
X-Gm-Message-State: AIVw110gn9PsTKqHlu2u7XBlCZjjpehFV2+9v/eO5SVS4GppbQh/gdAo	pCjFV/+iyAXTsdPNytcQiw2lP6/LAJ0G9Fw=
X-Received: by 10.55.190.134 with SMTP id o128mr352116qkf.58.1500362662338; Tue, 18 Jul 2017 00:24:22 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.237.63.21 with HTTP; Tue, 18 Jul 2017 00:24:01 -0700 (PDT)
In-Reply-To: <HE1PR0802MB23775781E0A58467C040B0F995A10@HE1PR0802MB2377.eurprd08.prod.outlook.com>
References: <HE1PR0802MB23775781E0A58467C040B0F995A10@HE1PR0802MB2377.eurprd08.prod.outlook.com>
From: Ulrich Drepper <drepper.fsp@gmail.com>
Date: Tue, 18 Jul 2017 07:25:00 -0000
Message-ID: <CAOPLpQfqtQZH-hOejwXN=R0Ga_OhbpMUNk1fvdY_Kki2ag5sxg@mail.gmail.com>
Subject: Re: PATCH v2][Aarch64] Add vectorized mersenne twister
To: Michael Collison <Michael.Collison@arm.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>, nd <nd@arm.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-IsSubscribed: yes
X-SW-Source: 2017-07/txt/msg01017.txt.bz2

On Tue, Jul 18, 2017 at 7:57 AM, Michael Collison
<Michael.Collison@arm.com> wrote:
> This is the second version of a patch for Aarc64 to add a vectorized mers=
enne twister to libstdc++. The first version used intrinsics and included "=
arm_neon.h". After feedback from the community this version uses only GCC v=
ector extensions and Aarch64 simd data types.

Looks OK.  Just stylistically, why do you have

+#ifdef __ARM_NEON
+#ifdef __aarch64__

(in more than one place) instead of one preprocessor line?