* [PATCH] arm: unified syntax for libgcc clear_cache
@ 2022-08-11 13:35 Seija Kijin
2022-09-06 14:48 ` Kyrylo Tkachov
0 siblings, 1 reply; 4+ messages in thread
From: Seija Kijin @ 2022-08-11 13:35 UTC (permalink / raw)
To: gcc-patches
The patch to convert all thumb1 code in libgcc to unified syntax
omitted changing all swi instructions to the current name: svc.
This patch fixes this case.
---
libgcc/config/arm/lib1funcs.S | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libgcc/config/arm/lib1funcs.S b/libgcc/config/arm/lib1funcs.S
index 8c39c9f20a2b..19fa1462ccf3 100644
--- a/libgcc/config/arm/lib1funcs.S
+++ b/libgcc/config/arm/lib1funcs.S
@@ -1522,7 +1522,7 @@ LSYM(Lover12):
add r7, r7, #2
#endif
mov r2, #0
- swi 0
+ svc 0
do_pop {r7}
RET
FUNC_END clear_cache
^ permalink raw reply [flat|nested] 4+ messages in thread* RE: [PATCH] arm: unified syntax for libgcc clear_cache
2022-08-11 13:35 [PATCH] arm: unified syntax for libgcc clear_cache Seija Kijin
@ 2022-09-06 14:48 ` Kyrylo Tkachov
2022-09-30 15:30 ` Seija Kijin
0 siblings, 1 reply; 4+ messages in thread
From: Kyrylo Tkachov @ 2022-09-06 14:48 UTC (permalink / raw)
To: Seija Kijin, gcc-patches
Hi Seija,
> -----Original Message-----
> From: Gcc-patches <gcc-patches-
> bounces+kyrylo.tkachov=arm.com@gcc.gnu.org> On Behalf Of Seija Kijin via
> Gcc-patches
> Sent: Thursday, August 11, 2022 2:36 PM
> To: gcc-patches@gcc.gnu.org
> Subject: [PATCH] arm: unified syntax for libgcc clear_cache
>
> The patch to convert all thumb1 code in libgcc to unified syntax
> omitted changing all swi instructions to the current name: svc.
>
> This patch fixes this case.
This is ok, thanks.
Do you need someone to commit this for you?
Kyrill
>
> ---
> libgcc/config/arm/lib1funcs.S | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libgcc/config/arm/lib1funcs.S b/libgcc/config/arm/lib1funcs.S
> index 8c39c9f20a2b..19fa1462ccf3 100644
> --- a/libgcc/config/arm/lib1funcs.S
> +++ b/libgcc/config/arm/lib1funcs.S
> @@ -1522,7 +1522,7 @@ LSYM(Lover12):
> add r7, r7, #2
> #endif
> mov r2, #0
> - swi 0
> + svc 0
> do_pop {r7}
> RET
> FUNC_END clear_cache
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] arm: unified syntax for libgcc clear_cache
2022-09-06 14:48 ` Kyrylo Tkachov
@ 2022-09-30 15:30 ` Seija Kijin
2023-01-13 13:05 ` Richard Earnshaw
0 siblings, 1 reply; 4+ messages in thread
From: Seija Kijin @ 2022-09-30 15:30 UTC (permalink / raw)
To: Kyrylo Tkachov; +Cc: gcc-patches
Yes, please!
On Tue, Sep 6, 2022 at 10:48 AM Kyrylo Tkachov <Kyrylo.Tkachov@arm.com> wrote:
>
> Hi Seija,
>
> > -----Original Message-----
> > From: Gcc-patches <gcc-patches-
> > bounces+kyrylo.tkachov=arm.com@gcc.gnu.org> On Behalf Of Seija Kijin via
> > Gcc-patches
> > Sent: Thursday, August 11, 2022 2:36 PM
> > To: gcc-patches@gcc.gnu.org
> > Subject: [PATCH] arm: unified syntax for libgcc clear_cache
> >
> > The patch to convert all thumb1 code in libgcc to unified syntax
> > omitted changing all swi instructions to the current name: svc.
> >
> > This patch fixes this case.
>
> This is ok, thanks.
> Do you need someone to commit this for you?
>
> Kyrill
>
> >
> > ---
> > libgcc/config/arm/lib1funcs.S | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/libgcc/config/arm/lib1funcs.S b/libgcc/config/arm/lib1funcs.S
> > index 8c39c9f20a2b..19fa1462ccf3 100644
> > --- a/libgcc/config/arm/lib1funcs.S
> > +++ b/libgcc/config/arm/lib1funcs.S
> > @@ -1522,7 +1522,7 @@ LSYM(Lover12):
> > add r7, r7, #2
> > #endif
> > mov r2, #0
> > - swi 0
> > + svc 0
> > do_pop {r7}
> > RET
> > FUNC_END clear_cache
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] arm: unified syntax for libgcc clear_cache
2022-09-30 15:30 ` Seija Kijin
@ 2023-01-13 13:05 ` Richard Earnshaw
0 siblings, 0 replies; 4+ messages in thread
From: Richard Earnshaw @ 2023-01-13 13:05 UTC (permalink / raw)
To: Seija Kijin, Kyrylo Tkachov; +Cc: gcc-patches
I've just noticed that this was never committed. Presumably that's
because the patch did not apply cleanly. I've cleaned it up and pushed
it now.
R.
On 30/09/2022 16:30, Seija Kijin via Gcc-patches wrote:
> Yes, please!
>
> On Tue, Sep 6, 2022 at 10:48 AM Kyrylo Tkachov <Kyrylo.Tkachov@arm.com> wrote:
>>
>> Hi Seija,
>>
>>> -----Original Message-----
>>> From: Gcc-patches <gcc-patches-
>>> bounces+kyrylo.tkachov=arm.com@gcc.gnu.org> On Behalf Of Seija Kijin via
>>> Gcc-patches
>>> Sent: Thursday, August 11, 2022 2:36 PM
>>> To: gcc-patches@gcc.gnu.org
>>> Subject: [PATCH] arm: unified syntax for libgcc clear_cache
>>>
>>> The patch to convert all thumb1 code in libgcc to unified syntax
>>> omitted changing all swi instructions to the current name: svc.
>>>
>>> This patch fixes this case.
>>
>> This is ok, thanks.
>> Do you need someone to commit this for you?
>>
>> Kyrill
>>
>>>
>>> ---
>>> libgcc/config/arm/lib1funcs.S | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/libgcc/config/arm/lib1funcs.S b/libgcc/config/arm/lib1funcs.S
>>> index 8c39c9f20a2b..19fa1462ccf3 100644
>>> --- a/libgcc/config/arm/lib1funcs.S
>>> +++ b/libgcc/config/arm/lib1funcs.S
>>> @@ -1522,7 +1522,7 @@ LSYM(Lover12):
>>> add r7, r7, #2
>>> #endif
>>> mov r2, #0
>>> - swi 0
>>> + svc 0
>>> do_pop {r7}
>>> RET
>>> FUNC_END clear_cache
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-01-13 13:05 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-11 13:35 [PATCH] arm: unified syntax for libgcc clear_cache Seija Kijin
2022-09-06 14:48 ` Kyrylo Tkachov
2022-09-30 15:30 ` Seija Kijin
2023-01-13 13:05 ` Richard Earnshaw
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).