From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 86224 invoked by alias); 4 Feb 2018 14:53:15 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 86199 invoked by uid 89); 4 Feb 2018 14:53:14 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-11.1 required=5.0 tests=BAYES_00,FREEMAIL_FROM,GIT_PATCH_2,GIT_PATCH_3,KAM_ASCII_DIVIDERS,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=HX-Received:10.80.142.25 X-HELO: mail-wm0-f46.google.com Received: from mail-wm0-f46.google.com (HELO mail-wm0-f46.google.com) (74.125.82.46) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 04 Feb 2018 14:53:11 +0000 Received: by mail-wm0-f46.google.com with SMTP id r78so21178796wme.0 for ; Sun, 04 Feb 2018 06:53:11 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=rgxF0wkhf45Yn4WnBNiv1mHnSxL2KKvaCOIpmNrQhlA=; b=mnjZ+5cG8RpphhSc1BiHd5Tpr1oeJ0qCoK9mLZhHjcVtc9fu119p3X8/3f+dXpVC4w t2I6LL0WCewR7OKZwhH5y+vqgD69cAXLdl4SS23oaqoYfm95CBerNVMrevYuMxtVB2o0 3LIZaj3f8EA6MVPFhwblZnVlIgb3ahOD15PtyZH/LYwbjW2S7nEAf8tox2IrPM3HejXd /B/DXf57LVkYlvfHO+RqqS5UzrmxGFTON/RjCrTktbJUH7cEIJuRVgA1dDlMnD5Fkmyx UXCoGfsVHDhMhUEOGozPnMufoKNUNXdL8MCkjW2MFEL9jDO2FK5eM4mr78L6bAVb+PdX nPtg== X-Gm-Message-State: AKwxytcuAae28FqGJvi+3CXLd0TTB+ebRlgCGC0acreN7POtX1BWn4FL GArJTLkXy5/+eQ7OuxG7yDO9efAz7oA7j6o1yIM= X-Google-Smtp-Source: AH8x225O+ZpJeT2b27U9JbGJF458W0GPN6K9HDPUcMtHSCyN3aKKv8bvITJzirpEwFaqH0TMlm0scuFirKGHgVR/2LU= X-Received: by 10.80.142.25 with SMTP id 25mr58256981edw.127.1517755989798; Sun, 04 Feb 2018 06:53:09 -0800 (PST) MIME-Version: 1.0 Received: by 10.80.179.214 with HTTP; Sun, 4 Feb 2018 06:52:29 -0800 (PST) In-Reply-To: References: From: Pip Cet Date: Sun, 04 Feb 2018 14:53:00 -0000 Message-ID: Subject: Re: [PATCH] WebAssembly: Disable subdirectory configuration for unsupported LD To: "Maciej W. Rozycki" Cc: binutils@sourceware.org, gdb-patches@sourceware.org, gcc-patches@gcc.gnu.org Content-Type: text/plain; charset="UTF-8" X-IsSubscribed: yes X-SW-Source: 2018-02/txt/msg00151.txt.bz2 Hello Maciej, thank you for looking at this code! The change looks obviously correct to me. Regards Pip On Sat, Feb 3, 2018 at 3:16 PM, Maciej W. Rozycki wrote: > Remove an LD subdirectory configuration error: > > *** ld does not support target wasm32-unknown-none > *** see ld/configure.tgt for supported targets > make[1]: *** [configure-ld] Error 1 > > which prevents binutils for the WebAssembly target from being built > unless an explicit `--disable-ld' configuration option has been given. > Users must not have to disable features selected by default to get a > working configuration. > > / > * configure.ac (noconfigdirs): Add `ld'. > * configure: Regenerate. > --- > Hi, > > It should be obvious. Also this causes troubles with cross-target > testing. OK to apply? > > Maciej > --- > configure | 3 +++ > configure.ac | 3 +++ > 2 files changed, 6 insertions(+) > > binutils-wasm32-no-ld.diff > Index: binutils/configure > =================================================================== > --- binutils.orig/configure 2018-01-28 00:48:43.000000000 +0000 > +++ binutils/configure 2018-02-02 05:48:19.239569799 +0000 > @@ -3860,6 +3860,9 @@ case "${target}" in > vax-*-*) > noconfigdirs="$noconfigdirs target-newlib target-libgloss" > ;; > + wasm32-*-*) > + noconfigdirs="$noconfigdirs ld" > + ;; > esac > > # If we aren't building newlib, then don't build libgloss, since libgloss > Index: binutils/configure.ac > =================================================================== > --- binutils.orig/configure.ac 2018-01-28 00:48:43.000000000 +0000 > +++ binutils/configure.ac 2018-02-02 05:48:09.444938712 +0000 > @@ -1191,6 +1191,9 @@ case "${target}" in > vax-*-*) > noconfigdirs="$noconfigdirs target-newlib target-libgloss" > ;; > + wasm32-*-*) > + noconfigdirs="$noconfigdirs ld" > + ;; > esac > > # If we aren't building newlib, then don't build libgloss, since libgloss