From: Evgeny Stupachenko <evstupac@gmail.com>
To: "H.J. Lu" <hjl.tools@gmail.com>
Cc: Uros Bizjak <ubizjak@gmail.com>,
"Zamyatin, Igor" <igor.zamyatin@intel.com>,
"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
Jan Hubicka <hubicka@ucw.cz>
Subject: Re: [PATCH, i386]: Switch x86 to TARGET_SUPPORTS_WIDE_INT
Date: Tue, 05 May 2015 12:23:00 -0000 [thread overview]
Message-ID: <CAOvf_xxWYCsy4LLjQTj2zW-St1fPQ3S8zcwZ49m2u+WDdgeqSA@mail.gmail.com> (raw)
In-Reply-To: <CAMe9rOq4ujaxs+M2at7BNC1DKy27NghkFS1uzjb1HzjRkk79kQ@mail.gmail.com>
Hi HJ,
I've checked spec2000 performance.
Only few spec binaries differ. Anyway performance is unchanged.
Thanks,
Evgeny
On Thu, Apr 30, 2015 at 10:08 PM, H.J. Lu <hjl.tools@gmail.com> wrote:
> On Thu, Apr 30, 2015 at 12:01 PM, Uros Bizjak <ubizjak@gmail.com> wrote:
>> Hello!
>>
>> Attached patch switches x86 to TARGET_SUPPORTS_WIDE_INT.
>>
>> The patch builds on the fact that build requires
>> HOST_BITS_PER_WIDE_INT = 64 capable host. Taking this in account,
>> noticeable blocks of code can be removed, and all but one
>> immed_double_const can be removed.
>>
>> The only wide-int mode that remains is TImode.
>>
>> 2015-04-30 Uros Bizjak <ubizjak@gmail.com>
>>
>> * config/i386/i386.h (TARGET_SUPPORTS_WIDE_INT): New define.
>> * config/i386/i386.c (ix86_legitimate_constant_p): Handle TImode
>> as CONST_WIDE_INT, not CONST_DOUBLE.
>> (ix86_cannot_force_const_mem): Handle CONST_WIDE_INT.
>> (output_pic_addr_const): Do not handle VOIDmode CONST_DOUBLEs.
>> (ix86_find_base_term): Do not check for CONST_DOUBLE.
>> (ix86_print_operand): Do not handle non-FPmode CONST_DOUBLEs.
>> (ix86_build_signbit_mask): Rewrite using wide ints.
>> (ix86_split_to_parts) [HOST_BITS_PER_WIDE_INT < 64]: Remove.
>> (ix86_rtx_costs): Handle CONST_WIDE_INT.
>> (find_constant): Ditto.
>> * config/i386/i386.md (bts, btr, btc peepholes): Rewrite
>> using gen_int_mode.
>> * config/i386/predicates.md (x86_64_immediate_operand)
>> <case CONST_INT>: Remove HOST_BITS_PER_WIDE_INT == 32 code.
>> (x86_64_zext_immediate_operand): Remove CONST_DOUBLE handling.
>> <case CONST_INT>: Remove HOST_BITS_PER_WIDE_INT == 32 code.
>> (const0_operand): Also match const_wide_int.
>> (constm1_operand): Ditto.
>> (const1_operand): Ditto.
>>
>> Patch was bootstrapped and regression tested on x86_64-linux-gnu
>> {,-m32} and i686-linux-gnu.
>>
>> I won't be able to commit the patch until Monday. H.J., can you please
>> test it on your SPEC testers, so there won't be any surprises w.r.t.
>> performance issues.
>
> Hi Igor,
>
> Can your team run SPEC CPU on this patch?
>
> Thanks.
>
> --
> H.J.
next prev parent reply other threads:[~2015-05-05 12:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-30 19:09 Uros Bizjak
2015-04-30 19:13 ` H.J. Lu
2015-05-05 12:23 ` Evgeny Stupachenko [this message]
2015-05-05 16:16 ` Uros Bizjak
2015-05-05 18:10 ` Richard Biener
2015-05-05 20:00 ` Uros Bizjak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOvf_xxWYCsy4LLjQTj2zW-St1fPQ3S8zcwZ49m2u+WDdgeqSA@mail.gmail.com \
--to=evstupac@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=hjl.tools@gmail.com \
--cc=hubicka@ucw.cz \
--cc=igor.zamyatin@intel.com \
--cc=ubizjak@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).