From: Ian Lance Taylor <iant@golang.org>
To: "CHIGOT, CLEMENT" <clement.chigot@atos.net>
Cc: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
David Edelsohn <dje.gcc@gmail.com>
Subject: Re: [PATCH] gcc: handle double quotes in symbol name during stabstrings generation
Date: Wed, 2 Dec 2020 07:55:04 -0800 [thread overview]
Message-ID: <CAOyqgcU++Xy9iB3w4dcsVCcPr_UPyoD+j4oGPvnMz0joNR_FgQ@mail.gmail.com> (raw)
In-Reply-To: <PR3PR02MB6380A2FBD200EB9078E038CDEAF30@PR3PR02MB6380.eurprd02.prod.outlook.com>
On Wed, Dec 2, 2020 at 4:24 AM CHIGOT, CLEMENT <clement.chigot@atos.net> wrote:
>
> Since the new gccgo mangling scheme, libgo compilation is broken on AIX (or in Linux with -gstabs) because of a type symbol having a " in its name. I've made a patch (see attachment) in order to fix stabstring generation, because, IMO, it should be handled anyway.
> However, it happens only once in the whole libgo so I don't know if this " is intended or not. The problematic type is there: https://github.com/golang/go/blob/master/src/crypto/x509/x509.go#L2674. Other similar types don't trigger the bug though.
>
> I've a minimal test which might can be added if you wish, in Golang tests or in Gcc Go tests or in both ?
>
> If the patch is okay, could you please apply it for me ?
Could you show me the small test case? I don't think I understand the
problem. In DWARF I don't see any symbol names with quotation marks.
I'm not yet sure that your patch is the right fix. Thanks.
Ian
next prev parent reply other threads:[~2020-12-02 15:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-02 12:24 CHIGOT, CLEMENT
2020-12-02 15:55 ` Ian Lance Taylor [this message]
2020-12-02 16:14 ` CHIGOT, CLEMENT
2020-12-08 13:15 ` CHIGOT, CLEMENT
2020-12-11 5:09 ` Ian Lance Taylor
2020-12-11 17:58 ` Ian Lance Taylor
2020-12-14 13:36 ` CHIGOT, CLEMENT
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOyqgcU++Xy9iB3w4dcsVCcPr_UPyoD+j4oGPvnMz0joNR_FgQ@mail.gmail.com \
--to=iant@golang.org \
--cc=clement.chigot@atos.net \
--cc=dje.gcc@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).