From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x642.google.com (mail-ej1-x642.google.com [IPv6:2a00:1450:4864:20::642]) by sourceware.org (Postfix) with ESMTPS id 942E2385802A for ; Wed, 2 Dec 2020 15:55:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 942E2385802A Received: by mail-ej1-x642.google.com with SMTP id g20so5153818ejb.1 for ; Wed, 02 Dec 2020 07:55:16 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=4R8SQT3uF0JYZwVobSrtvLXWAikG62qaXF8KblSTVWU=; b=kLRBDI4zKtOtPq3iJxCf1i754HGgoneu5ShdiQcYdgakrzVkSYgLwfK7M0F3JdgbqW I1uR33Rb86z1KyDudHvxq90zPpVecbHqC4rQ9D33csA+nL7aJ7eK+di4Igr7YNgZYsGH hMpcSkrhxCBivDaPnUQfBhVG+C4oz7ua5HxQP17eU0V4R5L1ZOUB6lFDZ68e4prBwpTH UQXXNKiwPGjwOKaPSAuzQUSP6hB/B4AuUZGQbKjT96bOEMObVIs5kINzvOXAwEVBd9lp DYEuuYRgdpfR0CrV5jXum3VLBt+o8r5yot7JuLUPtgNwXE7fs815tjqJC+z2zOOeL9r7 zbhQ== X-Gm-Message-State: AOAM532qO5twk8uTA9mV0yvnZAUrsKhPwa3NqzU6r0XVfIzAR53fzLPK aehuc55WkO0ZXTz/vqzdWi2T2ToeiSLiCROgmCMWMQ== X-Google-Smtp-Source: ABdhPJzV9YoYeTSx6eNVhYsqokehCSSVr/bfs9o+9LC7LiueuiZcVwK1QDNpoIUSdnuOJfJB2jVw0CS3jviub+k8gFM= X-Received: by 2002:a17:906:e093:: with SMTP id gh19mr395491ejb.510.1606924515692; Wed, 02 Dec 2020 07:55:15 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Ian Lance Taylor Date: Wed, 2 Dec 2020 07:55:04 -0800 Message-ID: Subject: Re: [PATCH] gcc: handle double quotes in symbol name during stabstrings generation To: "CHIGOT, CLEMENT" Cc: "gcc-patches@gcc.gnu.org" , David Edelsohn Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Dec 2020 15:55:18 -0000 On Wed, Dec 2, 2020 at 4:24 AM CHIGOT, CLEMENT wr= ote: > > Since the new gccgo mangling scheme, libgo compilation is broken on AIX (= or in Linux with -gstabs) because of a type symbol having a " in its name. = I've made a patch (see attachment) in order to fix stabstring generation, b= ecause, IMO, it should be handled anyway. > However, it happens only once in the whole libgo so I don't know if this = " is intended or not. The problematic type is there: https://github.com/gol= ang/go/blob/master/src/crypto/x509/x509.go#L2674. Other similar types don't= trigger the bug though. > > I've a minimal test which might can be added if you wish, in Golang tests= or in Gcc Go tests or in both ? > > If the patch is okay, could you please apply it for me ? Could you show me the small test case? I don't think I understand the problem. In DWARF I don't see any symbol names with quotation marks. I'm not yet sure that your patch is the right fix. Thanks. Ian