From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yb1-xb2a.google.com (mail-yb1-xb2a.google.com [IPv6:2607:f8b0:4864:20::b2a]) by sourceware.org (Postfix) with ESMTPS id 4A330385701A for ; Thu, 30 Nov 2023 19:58:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4A330385701A Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=golang.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=golang.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 4A330385701A Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::b2a ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701374320; cv=none; b=rhTYyk40TyoghjJI7ns76O+1LVEa8UlxxT8n66o9TLJIO+dt5dg1qpp9l0Hu0GyIxcS7uoKpbzGuKMyNaFY/o35mR7rsoYnfd47zOCNZfoQchM3R7r3mbH1G8HP5C0MPBaxrldHnaE4uo6KqEPXw6uHULAaZqr5y6q1+Jcy5N/0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701374320; c=relaxed/simple; bh=xPpzomXsmL84MIPX2kJl5soiSerHS75au8zr9ZnViGc=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=fUC+U8pbSPc+8tTnSqhRA8BERbT7mGYqaGS4Vw+U5yw13aLYIe9jYLTdvCZSamdGP/PIddM0SsMR9SKz7tJYK0DfiB671Ek+VDf6x9ein4za4aFTZ7NDCzbcEggW2ZYy2j3dbDP5guzEtcv6kb7IY1afNNoWf/+gavVD2UqmmHo= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-yb1-xb2a.google.com with SMTP id 3f1490d57ef6-db510605572so1321437276.0 for ; Thu, 30 Nov 2023 11:58:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=golang-org.20230601.gappssmtp.com; s=20230601; t=1701374317; x=1701979117; darn=gcc.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=bXulpUjGCjL01Pkytnd4XeNIfqOaP3d+YBH1k4dgWH0=; b=PRQabSUb/tCoXiJvNHcXvhwfTQK8iyWaVH200af0aCTP+W+yDyF8439cinNg8uFVpz wKzJJPx8YL89kXHzyoWHeSMbobrGRbf05/NWFXkvMMUcdXcjsLLngUBvqxuTgFfTgSaR iHQMhgujOPslXimW72+LIl7M2x7HREf5WmF31vHFrZjfN8FGPbysP+oYOH+FzHj1K29L 5kHLNAE+bUtqN9yiUa2zaOOkdFUn8jON0BciQTmciPSST73+lfoD8oS1YwAkZxrIkB5E dtLwNpfueXnXWlIaMKwMv7QQeR7ARFEnfwfrkVbsVJM2gwlShj3kUAymo4gCPpQlSKGh VVzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701374317; x=1701979117; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bXulpUjGCjL01Pkytnd4XeNIfqOaP3d+YBH1k4dgWH0=; b=YTOaAoHRsLOj6TpfZ0ShAq5fiGmdChYw9GxnrsFHIbd9SLJ5aVa4j0sGeN70Swl/Sz 7R15EuR0SRQeR2Zx0rZgdw48PLEwZKk9KvY5KYCgfzG2qnsuux9uxS4vuiUkVAh7U38Q VrKyXms0eKhO5DgwStlEc9A1lz8hYDe1zWyDBlDAYQe76jt/7rsz6qfIdt9Nu7tdzWQm mcymK7ASR1WyHYneCKkWlMoUkvwB0P+4eW1+BV0NH5w+E0h/N04TurjV77Buk9nvbOqY qcQC4Dglo72BwJADzXiAOnvJQ2QhgJ0CRpdZ3d8kcTnayS2prB2TWQmE7x/q6fhbiXYX xwIA== X-Gm-Message-State: AOJu0YzjZ2yc04G+EDvzDfEGvQW0DYdSVppRloDoAyajSqCJotBxJhSQ QHhphtRszZongOSEjecA7KOkRVrUaq+6x74Kmimxag== X-Google-Smtp-Source: AGHT+IFOrPaEoHAFL/NUEcwczkc10qFH5MD24LtCB1RZU1d7l14AoHbeM7ototwxErdQK7xW7X6DMSGidbF5R3cOwFI= X-Received: by 2002:a25:1908:0:b0:da0:cc14:b66 with SMTP id 8-20020a251908000000b00da0cc140b66mr19067797ybz.9.1701374316890; Thu, 30 Nov 2023 11:58:36 -0800 (PST) MIME-Version: 1.0 References: <92993a50-9667-45da-a62-5089e7e052f8@codesourcery.com> <14111ba7-615b-b2e9-6fba-e7bee3728182@codesourcery.com> <9B1D2B19-B4EB-48B0-91EE-9AC33B392875@gmail.com> <2abef445-3ba3-7b8a-29e7-ba736592e325@codesourcery.com> <3CB9E78B-65BF-4706-B13B-01422C42830B@gmail.com> <11A36820-BC70-4A8C-8EAE-85E5CA6FD9F6@gmail.com> In-Reply-To: From: Ian Lance Taylor Date: Thu, 30 Nov 2023 11:58:25 -0800 Message-ID: Subject: Re: Darwin: Replace environment runpath with embedded [PR88590] To: Iain Sandoe Cc: FX Coudert , GCC Patches Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-3.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, Nov 30, 2023 at 11:56=E2=80=AFAM Iain Sandoe wr= ote: > > > On 30 Nov 2023, at 19:43, Ian Lance Taylor wrote: > > > > On Sun, Oct 22, 2023 at 2:18=E2=80=AFPM FX Coudert wrote: > >> > >> Thanks a lot Alexandre for the review! > > > > This patch changed the files lingo/configure.ac and libgo/configure. > > Those files live in an upstream repository and should be changed there > > and then merged into the GCC repo, as described in libgo/README.gcc. > > This is not a big deal, and I can take care of changing the upstream > > repository. But I don't understand the changes in libgo. As far as I > > can tell, all they do is add an automake conditional that is never > > used. Is there any reason for that? > > It=E2=80=99s not used (yet) because we do not build libgo on Darwin, if/w= hen we > do it would be used in the same way as for the other runtimes. > > > Should I just revert the changes to libgo? > > That is also fine (because we do not yet build it on Darwin), it seems un= likely > we=E2=80=99d forget to re-add it. Thanks, I'll make the change upstream. Ian