From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15181 invoked by alias); 8 Jan 2015 01:20:14 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 15151 invoked by uid 89); 8 Jan 2015 01:20:09 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-yk0-f169.google.com Received: from mail-yk0-f169.google.com (HELO mail-yk0-f169.google.com) (209.85.160.169) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Thu, 08 Jan 2015 01:20:06 +0000 Received: by mail-yk0-f169.google.com with SMTP id 79so3347ykr.0 for ; Wed, 07 Jan 2015 17:20:04 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=hirwLmaE7U1eMhVULFom+vw71mi630j3tKSuw/yg7jQ=; b=FdJFqvQwVQcboam0TTEtzI8yaOGQNiSdvQN+PpLMxe1flwYVfXQdTFHmdPvHBLoQ2+ NrvUDfEhA5dSKmlHaLceZ4VtIXULtdv4AruFyHvOnrvO/t3hxzn6U6TH6dL+8nBZGWvZ sW97mDhGPD0bpJfikJjIpLK7tmhA0Vaecp1KLa61AogBjfqVT1rIKLuwcw3l1ZRvYjRs JSnJyDPoCupvZAFHQCIulRlyVoMSwKvHcUKW5VZ/vPgQgdxYTbwPBUJDFf+Ou8qpBqLt p/muqUZmnD0WdNJ8BZong7MR7k6QmEH7eoG+H+UTqpbGD6AoyCcFcHX/ki7o0/SAhTdW W+Jw== X-Gm-Message-State: ALoCoQmm8tkaLu8BtOcpGL/7d7Jv96HJXSlGOxlMH19qJIG6TEST3ul8IUBca2jrUQz3V45txtZz MIME-Version: 1.0 X-Received: by 10.236.230.4 with SMTP id i4mr4436291yhq.40.1420680004215; Wed, 07 Jan 2015 17:20:04 -0800 (PST) Received: by 10.170.57.196 with HTTP; Wed, 7 Jan 2015 17:20:04 -0800 (PST) In-Reply-To: <87egr6p0le.fsf@canonical.com> References: <54AC0154.7020700@linux.vnet.ibm.com> <54AD623E.9050109@linux.vnet.ibm.com> <54AD6C37.2060804@linux.vnet.ibm.com> <87egr6p0le.fsf@canonical.com> Date: Thu, 08 Jan 2015 01:20:00 -0000 Message-ID: Subject: Re: [gofrontend-dev] [PATCH 1/2, libgo] Add reflection support to gccgo for ppc64, ppc64le in gcc 4.9 From: Ian Lance Taylor To: Michael Hudson-Doyle Cc: "Lynn A. Boger" , gcc-patches , "gofrontend-dev@googlegroups.com" Content-Type: text/plain; charset=UTF-8 X-SW-Source: 2015-01/txt/msg00349.txt.bz2 On Wed, Jan 7, 2015 at 4:39 PM, Michael Hudson-Doyle wrote: > Ian Lance Taylor writes: > >> On Wed, Jan 7, 2015 at 9:26 AM, Lynn A. Boger >> wrote: >>> >>> In libgo/go/reflect/makefunc.go, calls to MakeFunc, makeMethodValue and >>> makeValueMethod will panic if called when GOARCH is ppc64 or ppc64le. >> >> Right, I'm just saying that almost no code actually does that. I just >> tried a web search and found no uses other than examples of how to use >> it. I'm sure there are a few, but not many. > > There is a somewhat hidden one in Docker: > > https://github.com/docker/docker/blob/master/api/client/cli.go#L64 > > (it is also possible to patch docker to do this differently, of course). Ah, so that is why it matters. Perhaps you could talk Docker into replace the return statement with return func(a ...string) error { return method.CallSlice([]reflect.Value{reflect.ValueOf(a)})[0].Interface().(error) }, true It would probably be just as efficient. Ian