From: Ian Lance Taylor <iant@golang.org>
To: gcc-patches <gcc-patches@gcc.gnu.org>, gofrontend-dev@googlegroups.com
Subject: Go patch committed: Ignore aliases in fieldtracking info
Date: Fri, 23 Feb 2018 21:39:00 -0000 [thread overview]
Message-ID: <CAOyqgcU2wQy2PBRsvrBi1SQyUWx_2J5G1WnGv=CyjSaH=17gJA@mail.gmail.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 260 bytes --]
This patch to the Go frontend ignores aliases when emitting
fieldtracking info. We want to track references to fields in the real
struct, not in some alias to the struct. Bootstrapped and ran Go
testsuite on x86_64-pc-linux-gnu. Committed to mainline.
Ian
[-- Attachment #2: patch.txt --]
[-- Type: text/plain, Size: 980 bytes --]
Index: gcc/go/gofrontend/MERGE
===================================================================
--- gcc/go/gofrontend/MERGE (revision 257914)
+++ gcc/go/gofrontend/MERGE (working copy)
@@ -1,4 +1,4 @@
-ed8647cc99652db2d689215c05f31ad038438a7e
+8b3d6091801d485c74a9c92740c69673e39160b0
The first line of this file holds the git revision number of the last
merge done from the gofrontend repository.
Index: gcc/go/gofrontend/expressions.cc
===================================================================
--- gcc/go/gofrontend/expressions.cc (revision 257914)
+++ gcc/go/gofrontend/expressions.cc (working copy)
@@ -11696,7 +11696,7 @@ Field_reference_expression::do_lower(Gog
Location loc = this->location();
std::string s = "fieldtrack \"";
- Named_type* nt = this->expr_->type()->named_type();
+ Named_type* nt = this->expr_->type()->unalias()->named_type();
if (nt == NULL || nt->named_object()->package() == NULL)
s.append(gogo->pkgpath());
else
reply other threads:[~2018-02-23 21:39 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOyqgcU2wQy2PBRsvrBi1SQyUWx_2J5G1WnGv=CyjSaH=17gJA@mail.gmail.com' \
--to=iant@golang.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=gofrontend-dev@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).