From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x1029.google.com (mail-pj1-x1029.google.com [IPv6:2607:f8b0:4864:20::1029]) by sourceware.org (Postfix) with ESMTPS id 463C03858D1E for ; Wed, 30 Nov 2022 00:10:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 463C03858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=golang.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=golang.org Received: by mail-pj1-x1029.google.com with SMTP id cm20so434702pjb.1 for ; Tue, 29 Nov 2022 16:10:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=golang-org.20210112.gappssmtp.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=Y0IlnVuSkSZegZY95AkQ90X09kyn5Cw2IErYpDcdwxk=; b=tiesumIP9EszaUugvMlpAQ+4OKARWQSxDM765gMdJxwHBnP0WiVUxDFHHItUJ6kQy0 DbmOHuT3Dq3HQ1LuMS2vZmb0ZdZze2W0caGaTDXrAtJz3g194ueJHNAdfZhGd90Bcalu Zs8lPY3kTUAkq4/63l6xE1AdE+Ofbm7PUAZAzw58IGLBjxBWJQ4JqBaMlOM4CtCVWKmV jUjwPslCMBSpXcm9ILnnU2fxAG19djaA5uFWu2X3Ii3KOHRO2VPmJcE1txnM5snkBPeQ MhpQPZIHj9D8y6pp6ts5xFaVHR3l2+/o3J5hYynCB61Lk9d4xzJPalKy7SnlW+IUisia WDEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Y0IlnVuSkSZegZY95AkQ90X09kyn5Cw2IErYpDcdwxk=; b=DswFK6QXgf35Eoxwak6UcHWcxyjOsWTWoTWvMHmti5emTXaUspmRnlRl7GZ+GOoE7T DRUBaZI7UuewewwwItTqBth9/z94j6Hjwrqqucm1yQodyP3+fpXMp3hLIR5rFfqYlscr Dv4w27//WrDp8hufWvHkbcKK1pNgpQOtackeKOS1Ywc0WrDpthy4FsvhFv43wu/yYx/b zH78ZE/jcxFdR6pxRERUXORYJ62O1taDynuOK0IdkPWu+Qy+jHSIVhDw/Eg24UcUNAhB JrCFC6V1dGvzJoaUbqoIj2kll7gradbxGJyfuTWuXDcQ2R9LmXMBS7odWsGVG3DL/Hd6 kMsQ== X-Gm-Message-State: ANoB5plLaYiWDgEuztaoQ+FklmLXZLMfrtw8HGQZBq6/JsEUDwvZ4kGV dyfVX1XgjDvze+NVDMVdGqDJIo79L4BgIb5lBerw7g== X-Google-Smtp-Source: AA0mqf5c7Tz1aHOn0vAyIqeW3ZnvB5NVSIaIuzic9rFMj0gSAM8S3Rsj1xR7MIxPMl2eRHeL+Yr1UzKXCpUtyanJsDM= X-Received: by 2002:a17:90b:394c:b0:213:1935:9744 with SMTP id oe12-20020a17090b394c00b0021319359744mr62567521pjb.207.1669767022754; Tue, 29 Nov 2022 16:10:22 -0800 (PST) MIME-Version: 1.0 References: <20221129174331.3124-1-soeren@soeren-tempel.net> <20221129175453.3644-1-soeren@soeren-tempel.net> In-Reply-To: <20221129175453.3644-1-soeren@soeren-tempel.net> From: Ian Lance Taylor Date: Tue, 29 Nov 2022 16:10:11 -0800 Message-ID: Subject: Re: [PATCH v2] libgo: Don't rely on GNU-specific strerror_r variant on Linux To: soeren@soeren-tempel.net Cc: gcc-patches@gcc.gnu.org, gofrontend-dev@googlegroups.com Content-Type: multipart/mixed; boundary="00000000000040121a05eea4eee1" X-Spam-Status: No, score=-10.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --00000000000040121a05eea4eee1 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, Nov 29, 2022 at 9:54 AM wrote: > > From: S=C3=B6ren Tempel > > On glibc, there are two versions of strerror_r: An XSI-compliant and a > GNU-specific version. The latter is only available on glibc. In order > to avoid duplicating the post-processing code of error messages, this > commit provides a separate strerror_go symbol which always refers to the > XSI-compliant version of strerror_r (even on glibc) by selectively > undefining the corresponding feature test macro. > > Previously, gofrontend assumed that the GNU-specific version of > strerror_r was always available on Linux (which isn't the case when > using a musl as a libc, for example). This commit thereby improves > compatibility with Linux systems that are not using glibc. > > Tested on x86_64 Alpine Linux Edge and Arch Linux (glibc 2.36). Thanks. I committed a version of this, as attached. Ian --00000000000040121a05eea4eee1 Content-Type: text/plain; charset="US-ASCII"; name="patch.txt" Content-Disposition: attachment; filename="patch.txt" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_lb2w5xmy0 YjZjNmEzZDY0ZjJlNGU5MzQ3NzMzMjkwYWNhM2M3NTg5OGM0NGIyZQpkaWZmIC0tZ2l0IGEvZ2Nj L2dvL2dvZnJvbnRlbmQvTUVSR0UgYi9nY2MvZ28vZ29mcm9udGVuZC9NRVJHRQppbmRleCA3ZTUz MWMzZjkwYi4uOTg0ZDgzMjQwMDQgMTAwNjQ0Ci0tLSBhL2djYy9nby9nb2Zyb250ZW5kL01FUkdF CisrKyBiL2djYy9nby9nb2Zyb250ZW5kL01FUkdFCkBAIC0xLDQgKzEsNCBAQAotNWU2NThmNDY1 OWM1NTEzMzBlYTY4ZjU2NjdlNGY5NTFiMjE4ZjMyZAorZmVmNmFhM2MxNjc4Y2RiZTdkY2E0NTRi MmNlYmIzNjlkOGJhODFiZgogCiBUaGUgZmlyc3QgbGluZSBvZiB0aGlzIGZpbGUgaG9sZHMgdGhl IGdpdCByZXZpc2lvbiBudW1iZXIgb2YgdGhlIGxhc3QKIG1lcmdlIGRvbmUgZnJvbSB0aGUgZ29m cm9udGVuZCByZXBvc2l0b3J5LgpkaWZmIC0tZ2l0IGEvbGliZ28vTWFrZWZpbGUuYW0gYi9saWJn by9NYWtlZmlsZS5hbQppbmRleCBiMDNlNjU1M2U5MC4uMjA3ZDVhOTgxMjcgMTAwNjQ0Ci0tLSBh L2xpYmdvL01ha2VmaWxlLmFtCisrKyBiL2xpYmdvL01ha2VmaWxlLmFtCkBAIC00NjUsNiArNDY1 LDcgQEAgcnVudGltZV9maWxlcyA9IFwKIAlydW50aW1lL2dvLW5hbm90aW1lLmMgXAogCXJ1bnRp bWUvZ28tbm93LmMgXAogCXJ1bnRpbWUvZ28tbm9zeXMuYyBcCisJcnVudGltZS9nby1zdHJlcnJv ci5jIFwKIAlydW50aW1lL2dvLXJlZmxlY3QtY2FsbC5jIFwKIAlydW50aW1lL2dvLXNldGVudi5j IFwKIAlydW50aW1lL2dvLXNpZ25hbC5jIFwKZGlmZiAtLWdpdCBhL2xpYmdvL2dvL3N5c2NhbGwv ZXJyc3RyLmdvIGIvbGliZ28vZ28vc3lzY2FsbC9lcnJzdHIuZ28KaW5kZXggNTlmN2E4MmM2ZDcu LjlmNjg4ZTJhMGM3IDEwMDY0NAotLS0gYS9saWJnby9nby9zeXNjYWxsL2VycnN0ci5nbworKysg Yi9saWJnby9nby9zeXNjYWxsL2VycnN0ci5nbwpAQCAtNCwyMyArNCwxOSBAQAogLy8gVXNlIG9m IHRoaXMgc291cmNlIGNvZGUgaXMgZ292ZXJuZWQgYnkgYSBCU0Qtc3R5bGUKIC8vIGxpY2Vuc2Ug dGhhdCBjYW4gYmUgZm91bmQgaW4gdGhlIExJQ0VOU0UgZmlsZS4KIAotLy9nbzpidWlsZCAhaHVy ZCAmJiAhbGludXgKLS8vICtidWlsZCAhaHVyZCwhbGludXgKLQogcGFja2FnZSBzeXNjYWxsCiAK LS8vc3lzbmIJc3RyZXJyb3JfcihlcnJudW0gaW50LCBidWYgW11ieXRlKSAoZXJyIEVycm5vKQot Ly9zdHJlcnJvcl9yKGVycm51bSBfQ19pbnQsIGJ1ZiAqYnl0ZSwgYnVmbGVuIFNpemVfdCkgX0Nf aW50CitpbXBvcnQgImludGVybmFsL2J5dGVhbGciCisKKy8vZXh0ZXJuIGdvX3N0cmVycm9yCitm dW5jIGdvX3N0cmVycm9yKF9DX2ludCwgKmJ5dGUsIFNpemVfdCkgX0NfaW50CiAKIGZ1bmMgRXJy c3RyKGVycm51bSBpbnQpIHN0cmluZyB7Ci0JZm9yIGxlbiA6PSAxMjg7IDsgbGVuICo9IDIgewot CQliIDo9IG1ha2UoW11ieXRlLCBsZW4pCi0JCWVycm5vIDo9IHN0cmVycm9yX3IoZXJybnVtLCBi KQorCWZvciBzaXplIDo9IDEyODsgOyBzaXplICo9IDIgeworCQliIDo9IG1ha2UoW11ieXRlLCBz aXplKQorCQllcnJubyA6PSBnb19zdHJlcnJvcihfQ19pbnQoZXJybnVtKSwgJmJbMF0sIFNpemVf dChsZW4oYikpKQogCQlpZiBlcnJubyA9PSAwIHsKLQkJCWkgOj0gMAotCQkJZm9yIGJbaV0gIT0g MCB7Ci0JCQkJaSsrCi0JCQl9CisJCQlpIDo9IGJ5dGVhbGcuSW5kZXhCeXRlKGIsIDApCiAJCQkv LyBMb3dlcmNhc2UgZmlyc3QgbGV0dGVyOiBCYWQgLT4gYmFkLCBidXQKIAkJCS8vIFNUUkVBTSAt PiBTVFJFQU0uCiAJCQlpZiBpID4gMSAmJiAnQScgPD0gYlswXSAmJiBiWzBdIDw9ICdaJyAmJiAn YScgPD0gYlsxXSAmJiBiWzFdIDw9ICd6JyB7CkBAIC0yOSw3ICsyNSw3IEBAIGZ1bmMgRXJyc3Ry KGVycm51bSBpbnQpIHN0cmluZyB7CiAJCQlyZXR1cm4gc3RyaW5nKGJbOmldKQogCQl9CiAJCWlm IGVycm5vICE9IEVSQU5HRSB7Ci0JCQlyZXR1cm4gImVycnN0ciBmYWlsdXJlIgorCQkJcmV0dXJu ICJzdHJlcnJvcl9yIGZhaWx1cmUiCiAJCX0KIAl9CiB9CmRpZmYgLS1naXQgYS9saWJnby9nby9z eXNjYWxsL2VycnN0cl9nbGliYy5nbyBiL2xpYmdvL2dvL3N5c2NhbGwvZXJyc3RyX2dsaWJjLmdv CmRlbGV0ZWQgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwM2EzMjdkYmM5MC4uMDAwMDAwMDAwMDAK LS0tIGEvbGliZ28vZ28vc3lzY2FsbC9lcnJzdHJfZ2xpYmMuZ28KKysrIC9kZXYvbnVsbApAQCAt MSwzNCArMCwwIEBACi0vLyBlcnJzdHJfZ2xpYmMuZ28gLS0gR05VL0xpbnV4IGFuZCBHTlUvSHVy ZCBzcGVjaWZpYyBlcnJvciBzdHJpbmdzLgotCi0vLyBDb3B5cmlnaHQgMjAxMCBUaGUgR28gQXV0 aG9ycy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KLS8vIFVzZSBvZiB0aGlzIHNvdXJjZSBjb2RlIGlz IGdvdmVybmVkIGJ5IGEgQlNELXN0eWxlCi0vLyBsaWNlbnNlIHRoYXQgY2FuIGJlIGZvdW5kIGlu IHRoZSBMSUNFTlNFIGZpbGUuCi0KLS8vIFdlIHVzZSB0aGlzIHJhdGhlciB0aGFuIGVycnN0ci5n byBiZWNhdXNlIG9uIEdOVS9MaW51eCBzdGVycm9yX3IKLS8vIHJldHVybnMgYSBwb2ludGVyIHRv IHRoZSBlcnJvciBtZXNzYWdlLCBhbmQgbWF5IG5vdCB1c2UgYnVmIGF0IGFsbC4KLQotLy9nbzpi dWlsZCBodXJkIHx8IGxpbnV4Ci0vLyArYnVpbGQgaHVyZCBsaW51eAotCi1wYWNrYWdlIHN5c2Nh bGwKLQotaW1wb3J0ICJ1bnNhZmUiCi0KLS8vc3lzbmIJc3RyZXJyb3JfcihlcnJudW0gaW50LCBi IFtdYnl0ZSkgKGVycnN0ciAqYnl0ZSkKLS8vc3RyZXJyb3JfcihlcnJudW0gX0NfaW50LCBiICpi eXRlLCBsZW4gU2l6ZV90KSAqYnl0ZQotCi1mdW5jIEVycnN0cihlcnJudW0gaW50KSBzdHJpbmcg ewotCWEgOj0gbWFrZShbXWJ5dGUsIDEyOCkKLQlwIDo9IHN0cmVycm9yX3IoZXJybnVtLCBhKQot CWIgOj0gKCpbMTAwMF1ieXRlKSh1bnNhZmUuUG9pbnRlcihwKSkKLQlpIDo9IDAKLQlmb3IgYltp XSAhPSAwIHsKLQkJaSsrCi0JfQotCS8vIExvd2VyY2FzZSBmaXJzdCBsZXR0ZXI6IEJhZCAtPiBi YWQsIGJ1dCBTVFJFQU0gLT4gU1RSRUFNLgotCWlmIGkgPiAxICYmICdBJyA8PSBiWzBdICYmIGJb MF0gPD0gJ1onICYmICdhJyA8PSBiWzFdICYmIGJbMV0gPD0gJ3onIHsKLQkJYyA6PSBiWzBdICsg J2EnIC0gJ0EnCi0JCXJldHVybiBzdHJpbmcoYykgKyBzdHJpbmcoYlsxOmldKQotCX0KLQlyZXR1 cm4gc3RyaW5nKGJbOmldKQotfQpkaWZmIC0tZ2l0IGEvbGliZ28vcnVudGltZS9nby1zdHJlcnJv ci5jIGIvbGliZ28vcnVudGltZS9nby1zdHJlcnJvci5jCm5ldyBmaWxlIG1vZGUgMTAwNjQ0Cmlu ZGV4IDAwMDAwMDAwMDAwLi4xM2QxZDkxZGY4NAotLS0gL2Rldi9udWxsCisrKyBiL2xpYmdvL3J1 bnRpbWUvZ28tc3RyZXJyb3IuYwpAQCAtMCwwICsxLDM3IEBACisvKiBnby1zdHJlcnJvci5jIC0t IHdyYXBwZXIgYXJvdW5kIFhTSS1jb21wbGlhbnQgc3RyZXJyb3Jfci4KKworICAgQ29weXJpZ2h0 IDIwMjIgVGhlIEdvIEF1dGhvcnMuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCisgICBVc2Ugb2YgdGhp cyBzb3VyY2UgY29kZSBpcyBnb3Zlcm5lZCBieSBhIEJTRC1zdHlsZQorICAgbGljZW5zZSB0aGF0 IGNhbiBiZSBmb3VuZCBpbiB0aGUgTElDRU5TRSBmaWxlLiAgKi8KKworLyogVGhlcmUgYXJlIHR3 byB2ZXJzaW9uIG9mIHN0cmVycm9yX3Igb24gR05VL0xpbnV4OiBhIEdOVS1zcGVjaWZpYworICAg YW5kIGFuIFhTSS1jb21wbGlhbnQgdmVyc2lvbi4gIFRoZSBmb3JtZXIgdmVyc2lvbiBpcyBvbmx5 IGF2YWlsYWJsZQorICAgb24gZ2xpYmMuICBTaW5jZSBnbGliYyAyLjEzLCB0aGUgWFNJLWNvbXBs aWFudCB2ZXJzaW9uIGlzIGFsc28KKyAgIHByb3ZpZGVkIGJ5IGdsaWJjIGlmIF9HTlVfU09VUkNF IGlzIG5vdCBkZWZpbmVkLiAgU2luY2UgdGhlCisgICBlbnRpcmV0eSBvZiBnb2Zyb250ZW5kIGlz IGNvbXBpbGVkIHdpdGggX0dOVV9TT1VSQ0UsIHRoaXMgZmlsZQorICAgZXhpc3RzIHRvIHNlbGVj dGl2ZWx5IHVuZGVmaW5lIGl0IGFuZCBwcm92aWRlcyBhbiBhbGlhcyB0byB0aGUKKyAgIFhTSS1j b21wbGlhbnQgdmVyc2lvbiBvZiBzdHJlcnJvcl9yKDMpLiAgKi8KKworI2lmZGVmIF9fbGludXhf XworCisvKiBGb3JjZSBzZWxlY3Rpb24gb2YgWFNJLWNvbXBsaWFudCBzdHJlcnJvcl9yIGJ5IGds aWJjLiAgKi8KKyN1bmRlZiBYT1BFTl9TT1VSQ0UKKyNkZWZpbmUgWE9QRU5fU09VUkNFIDYwMAor I3VuZGVmIF9QT1NJWF9DX1NPVVJDRQorI2RlZmluZSBfUE9TSVhfQ19TT1VSQ0UgMjAwMTEyTAor I3VuZGVmIF9HTlVfU09VUkNFCisKKyNlbmRpZiAvKiBfX2xpbnV4X18gKi8KKworI2luY2x1ZGUg PHN0cmluZy5oPgorCisjaWZuZGVmIEhBVkVfU1RSRVJST1JfUgorLy8gUHJvdmlkZWQgYnkgZ28t bm9zeXMuYyBpZiBub3QgcHJvdmlkZWQgYnkgbGliYyBpdHNlbGYuCitleHRlcm4gaW50IHN0cmVy cm9yX3IgKGludCwgY2hhciAqLCBzaXplX3QpOworI2VuZGlmCisKK2ludAorZ29fc3RyZXJyb3Ig KGludCBlcnJudW0sIGNoYXIgKmJ1Ziwgc2l6ZV90IGJ1ZmxlbikKK3sKKyAgcmV0dXJuIHN0cmVy cm9yX3IgKGVycm51bSwgYnVmLCBidWZsZW4pOworfQo= --00000000000040121a05eea4eee1--