From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oo1-xc2a.google.com (mail-oo1-xc2a.google.com [IPv6:2607:f8b0:4864:20::c2a]) by sourceware.org (Postfix) with ESMTPS id F12593858029 for ; Tue, 27 Sep 2022 16:31:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org F12593858029 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=golang.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=golang.org Received: by mail-oo1-xc2a.google.com with SMTP id m11-20020a4aab8b000000b00476743c0743so888868oon.10 for ; Tue, 27 Sep 2022 09:31:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=golang-org.20210112.gappssmtp.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=sYMq7TRKrsdY9Zb/HekQYBhtglznSBYOQF/BW97cRmM=; b=TU9bXhLUiR31Oui+gpgVj1efjXF7laMFUQtSfKm9vX27yOCLUv+rOtihK1vtjNXIWJ AqQRunI057mMTcqLfXoPYKD9dVHKG9+HwU3DUSX9vFbXgB+niqbpkoGbxMwqAKcAjAHz aWmOFtmbw3MTsd/0MvkT0VWCvDKb9Sg46WDpJ1+cMFPj1/hNw5zp75rsFMyGLmq/bHZf g/bmKTQ0k3TCeY8MJzUzbwBVypLUua0Zm2q8wtdyyCJqmp9ncjN0KJVkSCRLS5GtyKlU kpFbgfF7V1erSoh+SOA2GAYQX9mAFSFpmjHJQT45hLip8xHfWSsTgN4o8UnkO7Vx//5f 5YyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=sYMq7TRKrsdY9Zb/HekQYBhtglznSBYOQF/BW97cRmM=; b=sGvYUBsvyE6ETIIROELuBywpad1vOYoZ+qr9uF5wBCeOdoH++wHGIIgt9pGssONuPE +usgZx8I1irNe79FmbhAeSfcgG89iLbdMpYToo6y0OLHf31/DXfqYrYywdx6fFBaNhvJ 24c4LJxAKuppYgpL2uNsLhTDiBYbjY3ymq0C3EbvhYjleewySjyZvm0yRlAH3Zu4b0LL Lnd6TBteJBx4sgpBDQXNDCW2NEXcCXsMDyknXNkbWPo75v3j0tncefqa7DVfFfwIQMc+ PrBzIo7NTHjZgD6jv7JO/Y5htU+ThXoGBIpnhdpsZQ753uRe0vMt4oUn6kei1+V0w91C rX3g== X-Gm-Message-State: ACrzQf33ItVM7TAjC7LdZ/0B0iJKZl2uVeQHINXsePPvHE73ko0AZhnu e/hrZwftqVY6IKvpiFCIe1Dv82+jFYWHmIn/twnSLA== X-Google-Smtp-Source: AMsMyM6IUhTe0QzwZHJas7ZXa1YityeQZSKSCyuCieGnutaFTKNTb9FEMGNJ6xIN/9EEyF8xVcChsOySiL2jQPbFnLw= X-Received: by 2002:a4a:4847:0:b0:443:347d:6617 with SMTP id p68-20020a4a4847000000b00443347d6617mr10983137ooa.94.1664296289157; Tue, 27 Sep 2022 09:31:29 -0700 (PDT) MIME-Version: 1.0 References: <2D7KNXY512R77.2ELCGV3AMTY0A@8pit.net> <20220923135914.24219-1-soeren@soeren-tempel.net> In-Reply-To: <20220923135914.24219-1-soeren@soeren-tempel.net> From: Ian Lance Taylor Date: Tue, 27 Sep 2022 09:31:18 -0700 Message-ID: Subject: Re: [PATCH v2] libgo: Portable access to thread ID in struct sigevent To: soeren@soeren-tempel.net Cc: gcc-patches@gcc.gnu.org, gofrontend-dev@googlegroups.com Content-Type: multipart/mixed; boundary="0000000000001e09c205e9ab2d2f" X-Spam-Status: No, score=-9.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --0000000000001e09c205e9ab2d2f Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, Sep 23, 2022 at 6:59 AM wrote: > > From: S=C3=B6ren Tempel > > Tested on x86_64 Arch Linux (glibc) and Alpine Linux (musl libc). > > Previously, libgo relied on the _sigev_un implementation-specific > field in struct sigevent, which is only available on glibc. This > patch uses the sigev_notify_thread_id macro instead which is mandated > by timer_create(2). In theory, this should work with any libc > implementation for Linux. Unfortunately, there is an open glibc bug > as glibc does not define this macro. For this reason, a glibc-specific > workaround is required. Other libcs (such as musl) define the macro > and don't require the workaround. > > This makes go_signal compatible with musl libc. > > See: https://sourceware.org/bugzilla/show_bug.cgi?id=3D27417 Thanks. Committed with some changes, as appended. Sorry for the delay. Ian --0000000000001e09c205e9ab2d2f Content-Type: text/plain; charset="US-ASCII"; name="patch.txt" Content-Disposition: attachment; filename="patch.txt" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_l8kf0ukm0 ZTczZDlmY2FmYmQwN2JjMzcxNGZiYWY4YTgyZGI3MWQ1MDAxNWM5MgpkaWZmIC0tZ2l0IGEvZ2Nj L2dvL2dvZnJvbnRlbmQvTUVSR0UgYi9nY2MvZ28vZ29mcm9udGVuZC9NRVJHRQppbmRleCA3M2Fh NzEyZGJkZi4uNDc5M2M4MjFlYmEgMTAwNjQ0Ci0tLSBhL2djYy9nby9nb2Zyb250ZW5kL01FUkdF CisrKyBiL2djYy9nby9nb2Zyb250ZW5kL01FUkdFCkBAIC0xLDQgKzEsNCBAQAotMDE0MGNjYTli YzBmYWQxMTA4YzdlZDM2OTM3NmFjNzFjYzRiZmVjZgorOGYxYTkxYWVmZjQwMGQ1NzI4NTc4OTVi N2Y1ZTg2M2VjNWE0ZDkzZQogCiBUaGUgZmlyc3QgbGluZSBvZiB0aGlzIGZpbGUgaG9sZHMgdGhl IGdpdCByZXZpc2lvbiBudW1iZXIgb2YgdGhlIGxhc3QKIG1lcmdlIGRvbmUgZnJvbSB0aGUgZ29m cm9udGVuZCByZXBvc2l0b3J5LgpkaWZmIC0tZ2l0IGEvbGliZ28vZ28vcnVudGltZS9vc19saW51 eC5nbyBiL2xpYmdvL2dvL3J1bnRpbWUvb3NfbGludXguZ28KaW5kZXggOTZmYjE3ODg3MGUuLjJi MmQ4MjdjZWU4IDEwMDY0NAotLS0gYS9saWJnby9nby9ydW50aW1lL29zX2xpbnV4LmdvCisrKyBi L2xpYmdvL2dvL3J1bnRpbWUvb3NfbGludXguZ28KQEAgLTIyLDYgKzIyLDEyIEBAIHR5cGUgbU9T IHN0cnVjdCB7CiAJcHJvZmlsZVRpbWVyVmFsaWQgdWludDMyCiB9CiAKKy8vIHNldFNpZ2V2ZW50 VElEIGlzIHdyaXR0ZW4gaW4gQyB0byBzZXQgdGhlIHNpZ2V2X25vdGlmeV90aHJlYWRfaWQKKy8v IGZpZWxkIG9mIGEgc2lnZXZlbnQgc3RydWN0LgorLy8KKy8vZ286bm9lc2NhcGUKK2Z1bmMgc2V0 U2lnZXZlbnRUSUQoKl9zaWdldmVudCwgaW50MzIpCisKIGZ1bmMgZ2V0UHJvY0lEKCkgdWludDY0 IHsKIAlyZXR1cm4gdWludDY0KGdldHRpZCgpKQogfQpAQCAtNTIsOSArNTgsMTIgQEAgY29uc3Qg KAogKQogCiAvLyBBdG9taWNhbGx5LAorLy8KIC8vCWlmKCphZGRyID09IHZhbCkgc2xlZXAKKy8v CiAvLyBNaWdodCBiZSB3b2tlbiB1cCBzcHVyaW91c2x5OyB0aGF0J3MgYWxsb3dlZC4KIC8vIERv bid0IHNsZWVwIGxvbmdlciB0aGFuIG5zOyBucyA8IDAgbWVhbnMgZm9yZXZlci4KKy8vCiAvL2dv Om5vc3BsaXQKIGZ1bmMgZnV0ZXhzbGVlcChhZGRyICp1aW50MzIsIHZhbCB1aW50MzIsIG5zIGlu dDY0KSB7CiAJLy8gU29tZSBMaW51eCBrZXJuZWxzIGhhdmUgYSBidWcgd2hlcmUgZnV0ZXggb2YK QEAgLTczLDYgKzgyLDcgQEAgZnVuYyBmdXRleHNsZWVwKGFkZHIgKnVpbnQzMiwgdmFsIHVpbnQz MiwgbnMgaW50NjQpIHsKIH0KIAogLy8gSWYgYW55IHByb2NzIGFyZSBzbGVlcGluZyBvbiBhZGRy LCB3YWtlIHVwIGF0IG1vc3QgY250LgorLy8KIC8vZ286bm9zcGxpdAogZnVuYyBmdXRleHdha2V1 cChhZGRyICp1aW50MzIsIGNudCB1aW50MzIpIHsKIAlyZXQgOj0gZnV0ZXgodW5zYWZlLlBvaW50 ZXIoYWRkciksIF9GVVRFWF9XQUtFX1BSSVZBVEUsIGNudCwgbmlsLCBuaWwsIDApCkBAIC0zNjUs NyArMzc1LDcgQEAgZnVuYyBzZXRUaHJlYWRDUFVQcm9maWxlcihoeiBpbnQzMikgewogCXZhciBz ZXZwIF9zaWdldmVudAogCXNldnAuc2lnZXZfbm90aWZ5ID0gX1NJR0VWX1RIUkVBRF9JRAogCXNl dnAuc2lnZXZfc2lnbm8gPSBfU0lHUFJPRgotCSooKCppbnQzMikodW5zYWZlLlBvaW50ZXIoJnNl dnAuX3NpZ2V2X3VuKSkpID0gaW50MzIobXAucHJvY2lkKQorCXNldFNpZ2V2ZW50VElEKCZzZXZw LCBpbnQzMihtcC5wcm9jaWQpKQogCXJldCA6PSB0aW1lcl9jcmVhdGUoX0NMT0NLX1RIUkVBRF9D UFVUSU1FX0lELCAmc2V2cCwgJnRpbWVyaWQpCiAJaWYgcmV0ICE9IDAgewogCQkvLyBJZiB3ZSBj YW5ub3QgY3JlYXRlIGEgdGltZXIgZm9yIHRoaXMgTSwgbGVhdmUgcHJvZmlsZVRpbWVyVmFsaWQg ZmFsc2UKZGlmZiAtLWdpdCBhL2xpYmdvL3J1bnRpbWUvZ28tc2lnbmFsLmMgYi9saWJnby9ydW50 aW1lL2dvLXNpZ25hbC5jCmluZGV4IDUyOGQ5YjZkOWZlLi5hYTFiNjMwNWFkMCAxMDA2NDQKLS0t IGEvbGliZ28vcnVudGltZS9nby1zaWduYWwuYworKysgYi9saWJnby9ydW50aW1lL2dvLXNpZ25h bC5jCkBAIC0xODMsNiArMTgzLDI0IEBAIHNldFNpZ2FjdGlvbkhhbmRsZXIoc3RydWN0IHNpZ2Fj dGlvbiogc2EsIHVpbnRwdHIgaGFuZGxlcikKIAlzYS0+c2Ffc2lnYWN0aW9uID0gKHZvaWQqKSho YW5kbGVyKTsKIH0KIAorI2lmZGVmIF9fbGludXhfXworCisvLyBXb3JrYXJvdW5kIGZvciBodHRw czovL3NvdXJjZXdhcmUub3JnL2J1Z3ppbGxhL3Nob3dfYnVnLmNnaT9pZD0yNzQxNworI2lmbmRl ZiBzaWdldl9ub3RpZnlfdGhyZWFkX2lkCisgICNkZWZpbmUgc2lnZXZfbm90aWZ5X3RocmVhZF9p ZCBfc2lnZXZfdW4uX3RpZAorI2VuZGlmCisKK3ZvaWQgc2V0U2lnZXZlbnRUSUQoc3RydWN0IHNp Z2V2ZW50KiwgaW50MzJfdCkKKwlfX2FzbV9fIChHT1NZTV9QUkVGSVggInJ1bnRpbWUuc2V0U2ln ZXZlbnRUSUQiKTsKKwordm9pZAorc2V0U2lnZXZlbnRUSUQoc3RydWN0IHNpZ2V2ZW50ICpzZXYs IGludDMyX3QgdikKK3sKKwlzZXYtPnNpZ2V2X25vdGlmeV90aHJlYWRfaWQgPSB2OworfQorCisj ZW5kaWYgLy8gZGVmaW5lZChfX2xpbnV4X18pCisKIC8vIEMgY29kZSB0byBmZXRjaCB2YWx1ZXMg ZnJvbSB0aGUgc2lnaW5mb190IGFuZCB1Y29udGV4dF90IHBvaW50ZXJzCiAvLyBwYXNzZWQgdG8g YSBzaWduYWwgaGFuZGxlci4KIAo= --0000000000001e09c205e9ab2d2f--