From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 96018 invoked by alias); 14 Jul 2017 22:21:43 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 96008 invoked by uid 89); 14 Jul 2017 22:21:42 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy=Hx-languages-length:1715 X-HELO: mail-oi0-f43.google.com Received: from mail-oi0-f43.google.com (HELO mail-oi0-f43.google.com) (209.85.218.43) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 14 Jul 2017 22:21:40 +0000 Received: by mail-oi0-f43.google.com with SMTP id l130so82213796oib.1 for ; Fri, 14 Jul 2017 15:21:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=4lguPrYm/zZI304zM6TuKnm8wB7sw2s8f3r7Mbn3x2s=; b=X+iuSHiD8C6KSqeL5lZgZAY7BfhAcFDjbvcdAGca079T3+qT92USLTvsUDIFv2h7tM 9iKNN/nbERgeZajRu4vdFgWrb6KMXVSVBjufR603elO8Zk/PCve2Yx1wh7nZoY8tFxHD uTDcDtG37tYPHimsjCn1VV/fLIOW/lNOjLBBVHQz1wxC6WMTvxJ7SrEICMudux1Qy6Vr BqH/hcIDxRLMfH0oPEka7o78Q4yldAQPoEr4k413YtUDmYbGKh/L0R4gU1CO8WAErqZq dloHWtlRnM5Cgm52XuYa3/YIJQodBLN/6GMGQf20/DUdo7ESTeTpQtRaphJn/cqWU35j 74og== X-Gm-Message-State: AIVw112mrO+ZPUITppJqTuFQWEPOBhDt2edyzAVEyl9A8mLa/7yv1Dmf JRTwVX/GGWZLEZ9WbF8U+ljN/9EP9+JT X-Received: by 10.202.245.5 with SMTP id t5mr7790795oih.176.1500070899033; Fri, 14 Jul 2017 15:21:39 -0700 (PDT) MIME-Version: 1.0 Received: by 10.202.199.202 with HTTP; Fri, 14 Jul 2017 15:21:38 -0700 (PDT) In-Reply-To: References: From: Ian Lance Taylor Date: Fri, 14 Jul 2017 22:21:00 -0000 Message-ID: Subject: Re: gotools patch committed: Test runtime, misc/cgo/{test,testcarchive} To: Uros Bizjak Cc: "gcc-patches@gcc.gnu.org" , "gofrontend-dev@googlegroups.com" Content-Type: text/plain; charset="UTF-8" X-SW-Source: 2017-07/txt/msg00872.txt.bz2 On Fri, Jul 14, 2017 at 11:41 AM, Uros Bizjak wrote: > On Thu, Jul 13, 2017 at 9:56 PM, Ian Lance Taylor wrote: >> On Thu, Jun 29, 2017 at 11:40 PM, Uros Bizjak wrote: >>> >>>> This patch to the gotools Makefile adds tests to `make check`. We now >>>> test the runtime package using the newly built go tool, and test that >>>> cgo works by running the misc/cgo/test and misc/cgo/testcarchive >>>> tests. Bootstrapped and ran Go testsuite on x86_64-pc-linux-gnu. >>>> Committed to mainline. >>> >>> There are several failures on non-split targets, e.g.: >>> >>> FAIL: TestCgoHandlesWlORIGIN >>> go_test.go:267: running testgo [build origin] >>> go_test.go:286: standard error: >>> go_test.go:287: # origin >>> cc1: error: '-fsplit-stack' requires assembler support for CFI >>> directives >>> cc1: error: '-fsplit-stack' is not supported by this compiler >>> configuration >>> >>> and: >>> >>> FAIL: TestCgoCrashHandler >>> crash_test.go:70: building testprogcgo []: exit status 2 >>> # _/home/uros/git/gcc/libgo/go/runtime/testdata/testprogcgo >>> cc1: error: '-fsplit-stack' requires assembler support for CFI >>> directives >>> cc1: error: '-fsplit-stack' is not supported by this compiler >>> configuration >>> >>> As evident from TestBuildDryRunWithCgo dump, -fsplit-stack argument is >>> added unconditionally to the compile flags. >> >> Would you mind checking whether this patch fixes the problem on your >> system? Thanks. > > Yes, this patch correctly detects that the compiler doesn't support > -fsplit-stack. Thanks for checking. I've committed the patch to mainline. Ian