From: Ian Lance Taylor <iant@golang.org>
To: "Lynn A. Boger" <laboger@linux.vnet.ibm.com>
Cc: gcc-patches <gcc-patches@gcc.gnu.org>,
"gofrontend-dev@googlegroups.com"
<gofrontend-dev@googlegroups.com>,
Segher Boessenkool <segher@kernel.crashing.org>
Subject: Re: libgo patch committed: Change build procedure to use build tags
Date: Mon, 08 Aug 2016 20:34:00 -0000 [thread overview]
Message-ID: <CAOyqgcUjAd3Y2ecCw7LcwScmdytsR67bEkXk4czkEhfiP8=uog@mail.gmail.com> (raw)
In-Reply-To: <ae07f246-9ad2-e977-6bc1-05b8b676bcef@linux.vnet.ibm.com>
[-- Attachment #1: Type: text/plain, Size: 1521 bytes --]
On Mon, Aug 8, 2016 at 11:14 AM, Lynn A. Boger
<laboger@linux.vnet.ibm.com> wrote:
> The libgo tests on ppc64le and ppc64 have all been failing in
> gcc-testresults since this change went in and continues to fail after the
> recent fixes for failures on other platforms.
>
> Built myself and got the same failures. I set keep=true in gotest to save
> the test dirs. Just running a single package:
>
> make bufio/check
> file /home/boger/gccgo.work/trunk/bld/../src/libgo/go/bufio/bufio.go not
> found
> Keeping gotest9734
> FAIL: bufio
> Makefile:3645: recipe for target 'bufio/check' failed
> make: *** [bufio/check] Error 1
> boger@willow3:~/gccgo.work/trunk/bld/powerpc64le-linux/libgo$ ls
> /home/boger/gccgo.work/trunk/bld/../src/libgo/go/bufio/bufio.go
> /home/boger/gccgo.work/trunk/bld/../src/libgo/go/bufio/bufio.go
> boger@willow3:~/gccgo.work/trunk/bld/powerpc64le-linux/libgo$ file
> /home/boger/gccgo.work/trunk/bld/../src/libgo/go/bufio/bufio.go
> /home/boger/gccgo.work/trunk/bld/../src/libgo/go/bufio/bufio.go: ASCII text
I found the problem. I always configure with a relative srcdir. You
are using an absolute srcdir. The recent changes to use build tags
changed the libgo Makefile so that when invoked with with an absolute
srcdir it would pass absolute path names to the gotest script. That
never worked. This patch makes it work, and should fix your problem.
Bootstrapped and ran Go testsuite on x86_64-pc-linux-gnu with a
relative srcdir and an absolute srcdir. Committed to mainline.
Ian
[-- Attachment #2: patch.txt --]
[-- Type: text/plain, Size: 2390 bytes --]
Index: gcc/go/gofrontend/MERGE
===================================================================
--- gcc/go/gofrontend/MERGE (revision 239252)
+++ gcc/go/gofrontend/MERGE (working copy)
@@ -1,4 +1,4 @@
-5e4c16d4fea39835e16f17c3d2b2e85f5c81d815
+2c88d4871558f0451a0ad152a7052dcfaecb254f
The first line of this file holds the git revision number of the last
merge done from the gofrontend repository.
Index: libgo/testsuite/gotest
===================================================================
--- libgo/testsuite/gotest (revision 239225)
+++ libgo/testsuite/gotest (working copy)
@@ -217,18 +217,27 @@ x)
;;
*)
for f in $pkgfiles; do
- if test -f $basedir/$f; then
- b=`basename $f`
- rm -f $b
- cp $basedir/$f $b
- elif test -f ../../$f; then
- b=`basename $f`
- rm -f $b
- cp ../../$f $b
- else
- echo "file $f not found" 1>&2
- exit 1
- fi
+ case $f in
+ /*)
+ b=`basename $f`
+ rm -f $b
+ cp $f $b
+ ;;
+ *)
+ if test -f $basedir/$f; then
+ b=`basename $f`
+ rm -f $b
+ cp $basedir/$f $b
+ elif test -f ../../$f; then
+ b=`basename $f`
+ rm -f $b
+ cp ../../$f $b
+ else
+ echo "file $f not found" 1>&2
+ exit 1
+ fi
+ ;;
+ esac
done
for f in `cd $srcdir; ls *_test.go`; do
rm -f $f
@@ -252,18 +261,27 @@ x)
;;
*)
for f in $pkgfiles; do
- if test -f $basedir/$f; then
- b=`basename $f`
- rm -f $b
- cp $basedir/$f $b
- elif test -f ../../$f; then
- b=`basename $f`
- rm -f $b
- cp ../../$f $b
- else
- echo "file $f not found" 1>&2
- exit 1
- fi
+ case $f in
+ /*)
+ b=`basename $f`
+ rm -f $b
+ cp $f $b
+ ;;
+ *)
+ if test -f $basedir/$f; then
+ b=`basename $f`
+ rm -f $b
+ cp $basedir/$f $b
+ elif test -f ../../$f; then
+ b=`basename $f`
+ rm -f $b
+ cp ../../$f $b
+ else
+ echo "file $f not found" 1>&2
+ exit 1
+ fi
+ ;;
+ esac
done
;;
esac
next prev parent reply other threads:[~2016-08-08 20:34 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-06 0:36 Ian Lance Taylor
2016-08-07 12:14 ` Andreas Schwab
2016-08-07 15:18 ` Matthias Klose
2016-08-07 22:33 ` Ian Lance Taylor
2016-09-04 16:24 ` Matthias Klose
2016-09-23 21:53 ` Ian Lance Taylor
2016-08-08 18:15 ` Lynn A. Boger
2016-08-08 18:26 ` Ian Lance Taylor
2016-08-08 19:07 ` Lynn A. Boger
2016-08-08 20:34 ` Ian Lance Taylor [this message]
2016-08-09 15:46 ` Lynn A. Boger
2016-08-11 15:16 ` Rainer Orth
2016-08-11 21:36 ` Ian Lance Taylor
2016-08-12 9:15 ` Rainer Orth
2016-08-12 13:56 ` Rainer Orth
2016-08-13 2:53 ` Ian Lance Taylor
2016-08-13 0:14 ` Ian Lance Taylor
2016-08-12 11:20 ` Andreas Krebbel
2016-08-13 0:23 ` Ian Lance Taylor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOyqgcUjAd3Y2ecCw7LcwScmdytsR67bEkXk4czkEhfiP8=uog@mail.gmail.com' \
--to=iant@golang.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=gofrontend-dev@googlegroups.com \
--cc=laboger@linux.vnet.ibm.com \
--cc=segher@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).