From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 126661 invoked by alias); 8 Aug 2016 20:34:23 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 126643 invoked by uid 89); 8 Aug 2016 20:34:22 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=AWL,BAYES_00,KAM_ASCII_DIVIDERS,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=no version=3.3.2 spammy=esac, Hx-languages-length:3344, sk:5e4c16d X-HELO: mail-it0-f44.google.com Received: from mail-it0-f44.google.com (HELO mail-it0-f44.google.com) (209.85.214.44) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Mon, 08 Aug 2016 20:34:12 +0000 Received: by mail-it0-f44.google.com with SMTP id f6so93309244ith.0 for ; Mon, 08 Aug 2016 13:34:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=e+FHSRVWmynmGvNN2BYtzP1H75G08rR6wnfqSzMd+OY=; b=QQH29lFB7LXJeRYO1/Br7cV8oBAHtPTX7xybrIz/kymUYSIUfLZhTjHbaPAsAIcb0V TNCeWtlF84iUd4x+4M1Y8ei5lWbG8h8EodOM7H38X+m03aUwtkCXttSJrwDEANt5aRbO TBFDiloFVYW00sqq7XYOW4at0IqI+/S+siPk3/X58cvVb6yyOw1F6MztVYuDUz4kpO7c vcLZECPM4CKXOoSptu65z7GEruc4Q67xf9K8FFuZBEr3RZHmDsV/Y3bU+ue9y5eyY4Nu tR0ufnqxjBe4WswAv1mIvBJAJZxBa/b3s+qyMNDKm7QjUFxwfIYTvE+84j1BqEek7XGA u5BA== X-Gm-Message-State: AEkoousxH/oznofGEfmysRJDEPNpmBIKB0N2H4aUYx5lf5eZUCTyoiPpYShVHTFDDO3Lny4sUyMkzXSYuNBNsA== X-Received: by 10.36.142.129 with SMTP id h123mr21283587ite.66.1470688450496; Mon, 08 Aug 2016 13:34:10 -0700 (PDT) MIME-Version: 1.0 Received: by 10.79.35.199 with HTTP; Mon, 8 Aug 2016 13:34:09 -0700 (PDT) In-Reply-To: References: From: Ian Lance Taylor Date: Mon, 08 Aug 2016 20:34:00 -0000 Message-ID: Subject: Re: libgo patch committed: Change build procedure to use build tags To: "Lynn A. Boger" Cc: gcc-patches , "gofrontend-dev@googlegroups.com" , Segher Boessenkool Content-Type: multipart/mixed; boundary=94eb2c04a0d2ab1b660539955673 X-SW-Source: 2016-08/txt/msg00640.txt.bz2 --94eb2c04a0d2ab1b660539955673 Content-Type: text/plain; charset=UTF-8 Content-length: 1521 On Mon, Aug 8, 2016 at 11:14 AM, Lynn A. Boger wrote: > The libgo tests on ppc64le and ppc64 have all been failing in > gcc-testresults since this change went in and continues to fail after the > recent fixes for failures on other platforms. > > Built myself and got the same failures. I set keep=true in gotest to save > the test dirs. Just running a single package: > > make bufio/check > file /home/boger/gccgo.work/trunk/bld/../src/libgo/go/bufio/bufio.go not > found > Keeping gotest9734 > FAIL: bufio > Makefile:3645: recipe for target 'bufio/check' failed > make: *** [bufio/check] Error 1 > boger@willow3:~/gccgo.work/trunk/bld/powerpc64le-linux/libgo$ ls > /home/boger/gccgo.work/trunk/bld/../src/libgo/go/bufio/bufio.go > /home/boger/gccgo.work/trunk/bld/../src/libgo/go/bufio/bufio.go > boger@willow3:~/gccgo.work/trunk/bld/powerpc64le-linux/libgo$ file > /home/boger/gccgo.work/trunk/bld/../src/libgo/go/bufio/bufio.go > /home/boger/gccgo.work/trunk/bld/../src/libgo/go/bufio/bufio.go: ASCII text I found the problem. I always configure with a relative srcdir. You are using an absolute srcdir. The recent changes to use build tags changed the libgo Makefile so that when invoked with with an absolute srcdir it would pass absolute path names to the gotest script. That never worked. This patch makes it work, and should fix your problem. Bootstrapped and ran Go testsuite on x86_64-pc-linux-gnu with a relative srcdir and an absolute srcdir. Committed to mainline. Ian --94eb2c04a0d2ab1b660539955673 Content-Type: text/plain; charset=US-ASCII; name="patch.txt" Content-Disposition: attachment; filename="patch.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_irmhxfk70 Content-length: 3242 SW5kZXg6IGdjYy9nby9nb2Zyb250ZW5kL01FUkdFCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIGdjYy9nby9nb2Zyb250ZW5kL01FUkdFCShyZXZpc2lv biAyMzkyNTIpCisrKyBnY2MvZ28vZ29mcm9udGVuZC9NRVJHRQkod29ya2lu ZyBjb3B5KQpAQCAtMSw0ICsxLDQgQEAKLTVlNGMxNmQ0ZmVhMzk4MzVlMTZm MTdjM2QyYjJlODVmNWM4MWQ4MTUKKzJjODhkNDg3MTU1OGYwNDUxYTBhZDE1 MmE3MDUyZGNmYWVjYjI1NGYKIAogVGhlIGZpcnN0IGxpbmUgb2YgdGhpcyBm aWxlIGhvbGRzIHRoZSBnaXQgcmV2aXNpb24gbnVtYmVyIG9mIHRoZSBsYXN0 CiBtZXJnZSBkb25lIGZyb20gdGhlIGdvZnJvbnRlbmQgcmVwb3NpdG9yeS4K SW5kZXg6IGxpYmdvL3Rlc3RzdWl0ZS9nb3Rlc3QKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gbGliZ28vdGVzdHN1aXRlL2dvdGVzdAkocmV2aXNpb24g MjM5MjI1KQorKysgbGliZ28vdGVzdHN1aXRlL2dvdGVzdAkod29ya2luZyBj b3B5KQpAQCAtMjE3LDE4ICsyMTcsMjcgQEAgeCkKIAkJOzsKIAkqKQogCQlm b3IgZiBpbiAkcGtnZmlsZXM7IGRvCi0JCSAgICBpZiB0ZXN0IC1mICRiYXNl ZGlyLyRmOyB0aGVuCi0JCQliPWBiYXNlbmFtZSAkZmAKLQkJCXJtIC1mICRi Ci0JCQljcCAkYmFzZWRpci8kZiAkYgotCQkgICAgZWxpZiB0ZXN0IC1mIC4u Ly4uLyRmOyB0aGVuCi0JCQliPWBiYXNlbmFtZSAkZmAKLQkJCXJtIC1mICRi Ci0JCQljcCAuLi8uLi8kZiAkYgotCQkgICAgZWxzZQotCQkJZWNobyAiZmls ZSAkZiBub3QgZm91bmQiIDE+JjIKLQkJCWV4aXQgMQotCQkgICAgZmkKKyAg ICAgICAgICAgICAgICAgICAgY2FzZSAkZiBpbgorICAgICAgICAgICAgICAg ICAgICAvKikKKyAgICAgICAgICAgICAgICAgICAgICAgIGI9YGJhc2VuYW1l ICRmYAorICAgICAgICAgICAgICAgICAgICAgICAgcm0gLWYgJGIKKyAgICAg ICAgICAgICAgICAgICAgICAgIGNwICRmICRiCisgICAgICAgICAgICAgICAg ICAgICAgICA7OworICAgICAgICAgICAgICAgICAgICAqKQorCQkgICAgICAg IGlmIHRlc3QgLWYgJGJhc2VkaXIvJGY7IHRoZW4KKwkJCSAgYj1gYmFzZW5h bWUgJGZgCisJCQkgIHJtIC1mICRiCisJCQkgIGNwICRiYXNlZGlyLyRmICRi CisJCSAgICAgICAgZWxpZiB0ZXN0IC1mIC4uLy4uLyRmOyB0aGVuCisJCQkg IGI9YGJhc2VuYW1lICRmYAorCQkJICBybSAtZiAkYgorCQkJICBjcCAuLi8u Li8kZiAkYgorCQkgICAgICAgIGVsc2UKKwkJCSAgZWNobyAiZmlsZSAkZiBu b3QgZm91bmQiIDE+JjIKKwkJCSAgZXhpdCAxCisJCSAgICAgICAgZmkKKyAg ICAgICAgICAgICAgICAgICAgICAgIDs7CisgICAgICAgICAgICAgICAgICAg IGVzYWMKIAkJZG9uZQogCQlmb3IgZiBpbiBgY2QgJHNyY2RpcjsgbHMgKl90 ZXN0LmdvYDsgZG8KIAkJICAgIHJtIC1mICRmCkBAIC0yNTIsMTggKzI2MSwy NyBAQCB4KQogCQk7OwogCSopCiAJCWZvciBmIGluICRwa2dmaWxlczsgZG8K LQkJICAgIGlmIHRlc3QgLWYgJGJhc2VkaXIvJGY7IHRoZW4KLQkJCWI9YGJh c2VuYW1lICRmYAotCQkJcm0gLWYgJGIKLQkJCWNwICRiYXNlZGlyLyRmICRi Ci0JCSAgICBlbGlmIHRlc3QgLWYgLi4vLi4vJGY7IHRoZW4KLQkJCWI9YGJh c2VuYW1lICRmYAotCQkJcm0gLWYgJGIKLQkJCWNwIC4uLy4uLyRmICRiCi0J CSAgICBlbHNlCi0JCQllY2hvICJmaWxlICRmIG5vdCBmb3VuZCIgMT4mMgot CQkJZXhpdCAxCi0JCSAgICBmaQorICAgICAgICAgICAgICAgICAgICBjYXNl ICRmIGluCisgICAgICAgICAgICAgICAgICAgIC8qKQorICAgICAgICAgICAg ICAgICAgICAgICAgYj1gYmFzZW5hbWUgJGZgCisgICAgICAgICAgICAgICAg ICAgICAgICBybSAtZiAkYgorICAgICAgICAgICAgICAgICAgICAgICAgY3Ag JGYgJGIKKyAgICAgICAgICAgICAgICAgICAgICAgIDs7CisgICAgICAgICAg ICAgICAgICAgICopCisJCSAgICAgICAgaWYgdGVzdCAtZiAkYmFzZWRpci8k ZjsgdGhlbgorCQkJICBiPWBiYXNlbmFtZSAkZmAKKwkJCSAgcm0gLWYgJGIK KwkJCSAgY3AgJGJhc2VkaXIvJGYgJGIKKwkJICAgICAgICBlbGlmIHRlc3Qg LWYgLi4vLi4vJGY7IHRoZW4KKwkJCSAgYj1gYmFzZW5hbWUgJGZgCisJCQkg IHJtIC1mICRiCisJCQkgIGNwIC4uLy4uLyRmICRiCisJCSAgICAgICAgZWxz ZQorCQkJICBlY2hvICJmaWxlICRmIG5vdCBmb3VuZCIgMT4mMgorCQkJICBl eGl0IDEKKwkJICAgICAgICBmaQorICAgICAgICAgICAgICAgICAgICAgICAg OzsKKyAgICAgICAgICAgICAgICAgICAgZXNhYwogCQlkb25lCiAJCTs7CiAJ ZXNhYwo= --94eb2c04a0d2ab1b660539955673--