public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Ian Lance Taylor <iant@golang.org>
To: gcc-patches <gcc-patches@gcc.gnu.org>,
		"gofrontend-dev@googlegroups.com"
	<gofrontend-dev@googlegroups.com>
Subject: libgo patch committed: Change build procedure to use build tags
Date: Sat, 06 Aug 2016 00:36:00 -0000	[thread overview]
Message-ID: <CAOyqgcUzQ8Cv+Bx=7TrO5z-CNti2ED+qfXwxL6FNFLKrw4D-nA@mail.gmail.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 1672 bytes --]

Go packages use build tags (see the section on Build Constraints at
https://golang.org/pkg/go/build/) to select which files to build on
specific systems.

Previously the libgo Makefile explicitly listed the set of files to
compile for each package.  For packages that use build tags, this
required a lot of awkward automake conditionals in the Makefile.

This patch changes the build to look at the build tags in the files.
The new shell script libgo/match.sh does the matching.  This required
adjusting a lot of build tags, and removing some files that are never
used.  I verified that the exact same sets of files are compiled on
x86_64-pc-linux-gnu.  I also tested the build on i386-sun-solaris
(building for both 32-bit and 64-bit).

Writing match.sh revealed some bugs in the build tag handling that
already exists, in a slightly different form, in the gotest shell
script.  This patch fixes those problems as well.

The old code used automake conditionals to handle systems that were
missing strerror_r and wait4.  Rather than deal with those in Go,
those functions are now implemented in runtime/go-nosys.c when
necessary, so the Go code can simply assume that they exist.

The os testsuite looked for dir_unix.go, which was never built for
gccgo and has now been removed.  I changed the testsuite to look for
dir.go instead.

Note that if you have an existing build directory, you will have to
remove all the .dep files in TARGET/libgo after updating to this
patch.  There isn't anything that will force them to update
automatically.

Bootstrapped on x86_64-pc-linux-gnu and i386-sun-solaris.  Ran Go
testsuite on x86_64-pc-linux-gnu.  Committed to mainline.

Ian

[-- Attachment #2: patch.txt.bz2 --]
[-- Type: application/x-bzip2, Size: 38255 bytes --]

             reply	other threads:[~2016-08-06  0:36 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-06  0:36 Ian Lance Taylor [this message]
2016-08-07 12:14 ` Andreas Schwab
2016-08-07 15:18   ` Matthias Klose
2016-08-07 22:33     ` Ian Lance Taylor
2016-09-04 16:24     ` Matthias Klose
2016-09-23 21:53       ` Ian Lance Taylor
2016-08-08 18:15 ` Lynn A. Boger
2016-08-08 18:26   ` Ian Lance Taylor
2016-08-08 19:07     ` Lynn A. Boger
2016-08-08 20:34   ` Ian Lance Taylor
2016-08-09 15:46     ` Lynn A. Boger
2016-08-11 15:16 ` Rainer Orth
2016-08-11 21:36   ` Ian Lance Taylor
2016-08-12  9:15     ` Rainer Orth
2016-08-12 13:56       ` Rainer Orth
2016-08-13  2:53         ` Ian Lance Taylor
2016-08-13  0:14       ` Ian Lance Taylor
2016-08-12 11:20 ` Andreas Krebbel
2016-08-13  0:23   ` Ian Lance Taylor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAOyqgcUzQ8Cv+Bx=7TrO5z-CNti2ED+qfXwxL6FNFLKrw4D-nA@mail.gmail.com' \
    --to=iant@golang.org \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=gofrontend-dev@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).