From: Ian Lance Taylor <iant@golang.org>
To: gcc-patches <gcc-patches@gcc.gnu.org>,
"gofrontend-dev@googlegroups.com"
<gofrontend-dev@googlegroups.com>
Cc: mpolacek@redhat.com
Subject: Go patch committed
Date: Wed, 10 Aug 2016 18:56:00 -0000 [thread overview]
Message-ID: <CAOyqgcV+Km0CTSAJSebmXDokGisxhpYh7Rw9uQDokdQZUXmVHA@mail.gmail.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 206 bytes --]
This patch to the Go frontend by Marek Polacek fixes one missing break
statement and adds a couple of "fall through" comments to fix the Go
frontend for -Wimplicit-fallthrough. Committed to mainline.
Ian
[-- Attachment #2: patch.txt --]
[-- Type: text/plain, Size: 1473 bytes --]
Index: gcc/go/gofrontend/MERGE
===================================================================
--- gcc/go/gofrontend/MERGE (revision 239315)
+++ gcc/go/gofrontend/MERGE (working copy)
@@ -1,4 +1,4 @@
-8da2129a005cc1f44d4d993b0b7312b64c0d68a4
+5e05b7bc947231b4d5a8327bf63e2fa648e51dc7
The first line of this file holds the git revision number of the last
merge done from the gofrontend repository.
Index: gcc/go/gofrontend/escape.cc
===================================================================
--- gcc/go/gofrontend/escape.cc (revision 239140)
+++ gcc/go/gofrontend/escape.cc (working copy)
@@ -281,6 +281,7 @@ Node::op_format() const
{
case Runtime::PANIC:
op << "panic";
+ break;
case Runtime::APPEND:
op << "append";
@@ -1923,6 +1924,7 @@ Escape_analysis_assign::assign(Node* dst
if (!e->type()->has_pointer())
break;
}
+ // Fall through.
case Expression::EXPRESSION_CONVERSION:
case Expression::EXPRESSION_TYPE_GUARD:
Index: gcc/go/gofrontend/expressions.cc
===================================================================
--- gcc/go/gofrontend/expressions.cc (revision 239095)
+++ gcc/go/gofrontend/expressions.cc (working copy)
@@ -5767,6 +5767,7 @@ Binary_expression::do_get_backend(Transl
case OPERATOR_DIV:
if (left_type->float_type() != NULL || left_type->complex_type() != NULL)
break;
+ // Fall through.
case OPERATOR_MOD:
is_idiv_op = true;
break;
next reply other threads:[~2016-08-10 18:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-10 18:56 Ian Lance Taylor [this message]
-- strict thread matches above, loose matches on Subject: below --
2015-07-23 20:31 Ian Lance Taylor
2015-07-23 19:55 Ian Lance Taylor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOyqgcV+Km0CTSAJSebmXDokGisxhpYh7Rw9uQDokdQZUXmVHA@mail.gmail.com \
--to=iant@golang.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=gofrontend-dev@googlegroups.com \
--cc=mpolacek@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).