From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x62b.google.com (mail-ej1-x62b.google.com [IPv6:2a00:1450:4864:20::62b]) by sourceware.org (Postfix) with ESMTPS id 575103854808 for ; Fri, 18 Dec 2020 18:31:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 575103854808 Received: by mail-ej1-x62b.google.com with SMTP id n26so4594238eju.6 for ; Fri, 18 Dec 2020 10:31:06 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=xAjHxf6OZGiwdUhcOgqilCv39MJfyAKMtm0rI9COsH0=; b=Hxkso7m8ohz2XtKvYlNwttfGgJm6gQFmF9ZgxckpKVKPEiM/1FE6X/MP7WowvQudve nRRGwTiD1M1DLQzol+hNmvcRK29Qd0rP2KqVNk9nEnd91tvTYLPUpKyvZkjpw1PB+J4M ZLFKRougGhEhwi//1bkQfq/U8DtwXfOw9PWnzvqLkKil1B02j4oWm1B3CZ/z93nEnzj1 JP3sCuws0POXByNQcF0z9R6zUhnkyf9xexxWYlzHCOnkbv8SsNwkNNO2qyUatmEOupsc PfC5IPEtmD3bNi3LHAzY+0+bP1oujqSesezumFL2YOLixUGV1pwTgUlsV/0HU5hDnlyQ +Tbg== X-Gm-Message-State: AOAM533OW/cssMfykWOso4HU+DyqFA59RtrSW3LdfmvVQPNlyiMczp45 jF3ar4TeH8vJyALJD7PXPymO4fL9CBJx3iDeiRQ1Yg== X-Google-Smtp-Source: ABdhPJzT/RLVn9LADE4hnwMQIZgqxqMvEdLy2fTujKkVu84Cf+3OVjB52+LZ+RbclmJjZjkLXT5cD5AJCf+qnbZm2eQ= X-Received: by 2002:a17:906:4412:: with SMTP id x18mr5254365ejo.301.1608316265461; Fri, 18 Dec 2020 10:31:05 -0800 (PST) MIME-Version: 1.0 References: <2b8fc5da-0a7e-2feb-9d22-6fecc349d842@suse.cz> In-Reply-To: <2b8fc5da-0a7e-2feb-9d22-6fecc349d842@suse.cz> From: Ian Lance Taylor Date: Fri, 18 Dec 2020 10:30:54 -0800 Message-ID: Subject: Re: Patch RFA: Support non-ASCII file names in git-changelog To: =?UTF-8?Q?Martin_Li=C5=A1ka?= Cc: gcc-patches , Jakub Jelinek , Jonathan Wakely Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Dec 2020 18:31:09 -0000 On Fri, Dec 18, 2020 at 2:28 AM Martin Li=C5=A1ka wrote: > > On 12/17/20 5:26 AM, Ian Lance Taylor via Gcc-patches wrote: > > As discussed at > > https://gcc.gnu.org/pipermail/gcc-patches/2020-December/561995.html , > > the ChangeLog checker does not correctly handle files with non-ASCII > > file names. > > > > This patch fixes the problem. I have little experience with Python, > > so I may have made some foolish mistakes here. > > > > OK to commit? > > > > Thanks. > > > > Ian > > > > * gcc-changelog/git_repository.py: Ignore quotation marks added by git > > for non-ASCII file names. > > > > First, sorry for a slow response about the previous > thread (Change to gcc/testsuite/go.test/test rejected by ChangeLog checke= r). > > Well, the suggested change will not help us because we will not be able > to find a file with a given path (\xxx\yyy...). > > Proper solution is likely doing: > $ git config --global core.quotepath false > > both on server side (and client side). > > Having that, git properly displays non-ascii filenames: > Thoughts? I don't know the tradeoffs here. This approach sounds fine to me. Ian