From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x429.google.com (mail-pf1-x429.google.com [IPv6:2607:f8b0:4864:20::429]) by sourceware.org (Postfix) with ESMTPS id 7BB6E3858D35 for ; Mon, 6 Mar 2023 04:02:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7BB6E3858D35 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=golang.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=golang.org Received: by mail-pf1-x429.google.com with SMTP id n5so4878827pfv.11 for ; Sun, 05 Mar 2023 20:02:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=golang-org.20210112.gappssmtp.com; s=20210112; t=1678075348; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=KTFLxlbDi8XO7Q4RE7X4tM3a+XlFHqwKnGS7L/R+UWo=; b=jlz3I+daUtGakPmxB2K4p+QXzPHxrco6g4lDUhW4oZ5M+x3eD70tbkHwq61LvLOAt4 egq87OkhnI0A8aXLlmwztNj3kZi4en72Grvd0MGJMQQvwVuZ0ozjMivrwQWLdwmYLZwj D2g0ZSnt0gfr4EmgoVewD512Bn9o2sV2bMlXZo6YCeUE0nbwlw3Nj0qY8X/WiHQocdgX 0qZKRHIUxVcEzBtmolM/kANCFKFh6HqdMTIPaP6fYBFEPfKBd8Sbuvf8KsEqWolnA92o p3CJHR8/p81u2Gp17wkEs2odKXuwBUrN7/zG1LpgD0VfvT2TmIs5IGphIMXm2xoJTerS zmZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678075348; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=KTFLxlbDi8XO7Q4RE7X4tM3a+XlFHqwKnGS7L/R+UWo=; b=7BUBftHv88HSQBijzy5d5THKKfYUnCTAXBmrJKo2TdErQ7SblLF088IBzbuRj4T8a3 M/QExtdij+KNyXvIt2M1ssfPWn5nM17yQjppAao7LvonGorCzi/+liDtRtoebD9pZYJo +xgVOxrfqz+M+qGnZc3R/Pwy4wZqCYmB37V3TD/pyMQZpKym87d58JfW5TYEmB7z+jiO Jbk7uToc3nmxShIXGtE3hYy1Vy819h3RkH8vKkk4PCk5J1hoW0elLqbD2/JpiyvqNj0l 5zhFvHUBawJPiPJ8jJ+ynxBHQd/cgJYlmsJPbRIXFQOa23quypEvKpdh9mZeaNvXB0Mt C7ew== X-Gm-Message-State: AO0yUKXiEgD7lEvDcjjIucQzKh8tgjQB0jaUENfAKIFIt2j1KVW3AWIp K5JxSzFbDB7YblV98vaUiVcLtoGOby89Js/lD8U8iQ== X-Google-Smtp-Source: AK7set8hDtF1qOxGwgjEl9iPda83phJPd9OL/QXueRSryjWtHFhZuEKYqaCm7LFwp+/sfowSv3Lm/UhpDqXRBxHrxzI= X-Received: by 2002:a63:7512:0:b0:4fb:97bd:ac25 with SMTP id q18-20020a637512000000b004fb97bdac25mr3163295pgc.6.1678075348112; Sun, 05 Mar 2023 20:02:28 -0800 (PST) MIME-Version: 1.0 References: <31b70646-db39-d5c1-475b-67e9ed1f98bd@gmail.com> <7edb4e42526c2e410cf26bd078a4ad2eca0b8426.camel@xry111.site> In-Reply-To: <7edb4e42526c2e410cf26bd078a4ad2eca0b8426.camel@xry111.site> From: Ian Lance Taylor Date: Sun, 5 Mar 2023 20:02:16 -0800 Message-ID: Subject: Re: [PATCH] Always define `WIN32_LEAN_AND_MEAN` before To: Xi Ruoyao Cc: Jonathan Yong <10walls@gmail.com>, Jakub Jelinek , LIU Hao , gcc-patches@gcc.gnu.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Fri, Mar 3, 2023 at 10:47=E2=80=AFPM Xi Ruoyao wrot= e: > > On Sat, 2023-01-07 at 06:52 +0000, Jonathan Yong via Gcc-patches wrote: > > On 1/6/23 18:10, Jakub Jelinek wrote: > > > On Sat, Jan 07, 2023 at 02:01:05AM +0800, LIU Hao via Gcc-patches > > > wrote: > > > > libgomp/ > > > > > > > > PR middle-end/108300 > > > > * config/mingw32/proc.c: Define `WIN32_LEAN_AND_MEAN` > > > > before > > > > . > > > > > > This change is ok for trunk. > > > > > > Jakub > > > > > > > Pushed to master branch, thanks LH. > > The patch touches libgo (w/o mentioning it in the ChangeLog). I guess > you need to contribute the libgo part into the upstream Go runtime or > the change will be undone when Ian merges libgo next time. Thanks, I've reverted the part of the patch that applies to libgo. It's not worth changing upstream because gccgo doesn't support Windows anyhow, and because that change is gone in the even-more-upstream sources. Ian