Re: [gofrontend-dev] Re: Go patch committed: Fix error reporting for invalid builtin calls

[Ian Lance Taylor <iant@golang.org>]

[-- Attachment #1: Type: text/plain, Size: 596 bytes --]

On Mon, Aug 3, 2015 at 7:24 PM, Michael Hudson-Doyle
<michael.hudson@canonical.com> wrote:
>
> Now I get
>
> ../../../gcc/libgo/runtime/mprof.goc: In function ‘runtime_Stack’:
> ../../../gcc/libgo/runtime/mprof.goc:437:19: error: ‘enablegc’ may be
> used uninitialized in this function [-Werror=maybe-uninitialized]
>    mstats.enablegc = enablegc;
>                    ^
> ../../../gcc/libgo/runtime/mprof.goc:406:7: note: ‘enablegc’ was declared here
>   bool enablegc;

I don't know why I am not seeing this, but I've committed this patch
that should fix it.

Ian

[-- Attachment #2: patch.txt --]
[-- Type: text/plain, Size: 804 bytes --]

Index: gcc/go/gofrontend/MERGE
===================================================================
--- gcc/go/gofrontend/MERGE	(revision 226533)
+++ gcc/go/gofrontend/MERGE	(working copy)
@@ -1,4 +1,4 @@
-a850225433a66a58613c22185c3b09626f5545eb
+bdd98c601f2c8dbd0bf821548ba09c038f7645c4
 
 The first line of this file holds the git revision number of the last
 merge done from the gofrontend repository.
Index: libgo/runtime/mprof.goc
===================================================================
--- libgo/runtime/mprof.goc	(revision 226525)
+++ libgo/runtime/mprof.goc	(working copy)
@@ -403,7 +403,7 @@ func ThreadCreateProfile(p Slice) (n int
 
 func Stack(b Slice, all bool) (n int) {
 	byte *pc;
-	bool enablegc;
+	bool enablegc = false;
 	
 	pc = (byte*)(uintptr)runtime_getcallerpc(&b);