* [PATCH] gcc: handle double quotes in symbol name during stabstrings generation @ 2020-12-02 12:24 CHIGOT, CLEMENT 2020-12-02 15:55 ` Ian Lance Taylor 0 siblings, 1 reply; 7+ messages in thread From: CHIGOT, CLEMENT @ 2020-12-02 12:24 UTC (permalink / raw) To: gcc-patches, iant; +Cc: David Edelsohn [-- Attachment #1: Type: text/plain, Size: 785 bytes --] Hi Ian Since the new gccgo mangling scheme, libgo compilation is broken on AIX (or in Linux with -gstabs) because of a type symbol having a " in its name. I've made a patch (see attachment) in order to fix stabstring generation, because, IMO, it should be handled anyway. However, it happens only once in the whole libgo so I don't know if this " is intended or not. The problematic type is there: https://github.com/golang/go/blob/master/src/crypto/x509/x509.go#L2674. Other similar types don't trigger the bug though. I've a minimal test which might can be added if you wish, in Golang tests or in Gcc Go tests or in both ? If the patch is okay, could you please apply it for me ? Thanks, Clément Chigot ATOS Bull SAS 1 rue de Provence - 38432 Échirolles - France [-- Attachment #2: 0001-gcc-handle-double-quotes-in-symbol-name-during-stabs.patch --] [-- Type: application/octet-stream, Size: 1526 bytes --] From c2836614aa4309f2e5077de83eabedf5e867290d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Cl=C3=A9ment=20Chigot?= <clement.chigot@atos.net> Date: Wed, 2 Dec 2020 18:19:35 +0100 Subject: [PATCH] gcc: handle double quotes in symbol name during stabstrings generation MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit With the new gccgo mangling scheme, a type name might now have a double quotes in it. The current code doesn't escape these double quotes when writing .stabs pseudo-opcode in the assembly file. Changelog: 2020-12-02 Clément Chigot <clement.chigot@atosnet> * dbxout.c (dbxout_symbol_name): Handle double quotes. --- gcc/dbxout.c | 19 ++++++++++++++++++- 1 file changed, 18 insertions(+), 1 deletion(-) diff --git a/gcc/dbxout.c b/gcc/dbxout.c index eaee2f19ce0..d1ffd7f36d2 100644 --- a/gcc/dbxout.c +++ b/gcc/dbxout.c @@ -3274,7 +3274,24 @@ dbxout_symbol_name (tree decl, const char *suffix, int letter) added by ASM_FORMAT_PRIVATE_NAME. */ name = DECL_NAME (decl); - if (name) + if (name && strchr(IDENTIFIER_POINTER(name), '"')) + { + /* Make sure double quote characters are correctly handled. */ + const char *str = IDENTIFIER_POINTER(name); + char c; + while ((c = *(str)++) != 0) + { + if (c == '\"') +#ifdef XCOFF_DEBUGGING_INFO + stabstr_C ('\"'); +#else + stabstr_C ('\\'); +#endif + + stabstr_C (c); + } + } + else if (name) stabstr_I (name); else stabstr_S ("(anon)"); -- 2.25.0 ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] gcc: handle double quotes in symbol name during stabstrings generation 2020-12-02 12:24 [PATCH] gcc: handle double quotes in symbol name during stabstrings generation CHIGOT, CLEMENT @ 2020-12-02 15:55 ` Ian Lance Taylor 2020-12-02 16:14 ` CHIGOT, CLEMENT 0 siblings, 1 reply; 7+ messages in thread From: Ian Lance Taylor @ 2020-12-02 15:55 UTC (permalink / raw) To: CHIGOT, CLEMENT; +Cc: gcc-patches, David Edelsohn On Wed, Dec 2, 2020 at 4:24 AM CHIGOT, CLEMENT <clement.chigot@atos.net> wrote: > > Since the new gccgo mangling scheme, libgo compilation is broken on AIX (or in Linux with -gstabs) because of a type symbol having a " in its name. I've made a patch (see attachment) in order to fix stabstring generation, because, IMO, it should be handled anyway. > However, it happens only once in the whole libgo so I don't know if this " is intended or not. The problematic type is there: https://github.com/golang/go/blob/master/src/crypto/x509/x509.go#L2674. Other similar types don't trigger the bug though. > > I've a minimal test which might can be added if you wish, in Golang tests or in Gcc Go tests or in both ? > > If the patch is okay, could you please apply it for me ? Could you show me the small test case? I don't think I understand the problem. In DWARF I don't see any symbol names with quotation marks. I'm not yet sure that your patch is the right fix. Thanks. Ian ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] gcc: handle double quotes in symbol name during stabstrings generation 2020-12-02 15:55 ` Ian Lance Taylor @ 2020-12-02 16:14 ` CHIGOT, CLEMENT 2020-12-08 13:15 ` CHIGOT, CLEMENT 0 siblings, 1 reply; 7+ messages in thread From: CHIGOT, CLEMENT @ 2020-12-02 16:14 UTC (permalink / raw) To: Ian Lance Taylor; +Cc: gcc-patches, David Edelsohn [-- Attachment #1: Type: text/plain, Size: 2300 bytes --] Hi Ian, Here is the test case. If you're compiling with -gstabs you should have a line looking like: .stabs "type..struct{Type go.bug1.ObjectIdentifier;Value [][]go.bug1.Extension{asn1:"set"}}:G(0,7)=xsStructType:",32,0,0,0 As you can see the " around for "set" aren't escaped. I didn't try to reproduce it on linux/amd64, but I did on linux/ppc64le and I don't think it's a ppc-only bug. Clément ________________________________ From: Ian Lance Taylor <iant@golang.org> Sent: Wednesday, December 2, 2020 4:55 PM To: CHIGOT, CLEMENT <clement.chigot@atos.net> Cc: gcc-patches@gcc.gnu.org <gcc-patches@gcc.gnu.org>; David Edelsohn <dje.gcc@gmail.com> Subject: Re: [PATCH] gcc: handle double quotes in symbol name during stabstrings generation Caution! External email. Do not open attachments or click links, unless this email comes from a known sender and you know the content is safe. On Wed, Dec 2, 2020 at 4:24 AM CHIGOT, CLEMENT <clement.chigot@atos.net> wrote: > > Since the new gccgo mangling scheme, libgo compilation is broken on AIX (or in Linux with -gstabs) because of a type symbol having a " in its name. I've made a patch (see attachment) in order to fix stabstring generation, because, IMO, it should be handled anyway. > However, it happens only once in the whole libgo so I don't know if this " is intended or not. The problematic type is there: https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fgolang%2Fgo%2Fblob%2Fmaster%2Fsrc%2Fcrypto%2Fx509%2Fx509.go%23L2674&data=04%7C01%7Cclement.chigot%40atos.net%7Ce85b8b57669c47db583508d896db2fc2%7C33440fc6b7c7412cbb730e70b0198d5a%7C0%7C0%7C637425215428486700%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=aB6diiR9Tgo3FTKOm0vmqVVJ%2B5JlCwd9oM5WeUaTaF4%3D&reserved=0. Other similar types don't trigger the bug though. > > I've a minimal test which might can be added if you wish, in Golang tests or in Gcc Go tests or in both ? > > If the patch is okay, could you please apply it for me ? Could you show me the small test case? I don't think I understand the problem. In DWARF I don't see any symbol names with quotation marks. I'm not yet sure that your patch is the right fix. Thanks. Ian [-- Attachment #2: bug_stabs.go --] [-- Type: application/octet-stream, Size: 491 bytes --] package main import ( "encoding/asn1" ) type ObjectIdentifier []int type Extension struct { Id asn1.ObjectIdentifier Critical bool `asn1:"optional"` Value []byte } func func1(nothing bool, typ ObjectIdentifier, ext []Extension) { if nothing { return } attr := struct { Type ObjectIdentifier Value [][]Extension `asn1:"set"` }{ Type: typ, Value: [][]Extension{ext}, } b, _ := asn1.Marshal(attr) println(b) } func main() { func1(false, []int{1}, nil) } ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] gcc: handle double quotes in symbol name during stabstrings generation 2020-12-02 16:14 ` CHIGOT, CLEMENT @ 2020-12-08 13:15 ` CHIGOT, CLEMENT 2020-12-11 5:09 ` Ian Lance Taylor 0 siblings, 1 reply; 7+ messages in thread From: CHIGOT, CLEMENT @ 2020-12-08 13:15 UTC (permalink / raw) To: Ian Lance Taylor; +Cc: gcc-patches, David Edelsohn Hi Ian, Any news about this bug ? It's not urgent even if it's breaking gcc builds with Go language, but I just want to know if you need any inputs/help from me. Thanks, Clément ________________________________ From: CHIGOT, CLEMENT <clement.chigot@atos.net> Sent: Wednesday, December 2, 2020 5:14 PM To: Ian Lance Taylor <iant@golang.org> Cc: gcc-patches@gcc.gnu.org <gcc-patches@gcc.gnu.org>; David Edelsohn <dje.gcc@gmail.com> Subject: Re: [PATCH] gcc: handle double quotes in symbol name during stabstrings generation Hi Ian, Here is the test case. If you're compiling with -gstabs you should have a line looking like: .stabs "type..struct{Type go.bug1.ObjectIdentifier;Value [][]go.bug1.Extension{asn1:"set"}}:G(0,7)=xsStructType:",32,0,0,0 As you can see the " around for "set" aren't escaped. I didn't try to reproduce it on linux/amd64, but I did on linux/ppc64le and I don't think it's a ppc-only bug. Clément ________________________________ From: Ian Lance Taylor <iant@golang.org> Sent: Wednesday, December 2, 2020 4:55 PM To: CHIGOT, CLEMENT <clement.chigot@atos.net> Cc: gcc-patches@gcc.gnu.org <gcc-patches@gcc.gnu.org>; David Edelsohn <dje.gcc@gmail.com> Subject: Re: [PATCH] gcc: handle double quotes in symbol name during stabstrings generation Caution! External email. Do not open attachments or click links, unless this email comes from a known sender and you know the content is safe. On Wed, Dec 2, 2020 at 4:24 AM CHIGOT, CLEMENT <clement.chigot@atos.net> wrote: > > Since the new gccgo mangling scheme, libgo compilation is broken on AIX (or in Linux with -gstabs) because of a type symbol having a " in its name. I've made a patch (see attachment) in order to fix stabstring generation, because, IMO, it should be handled anyway. > However, it happens only once in the whole libgo so I don't know if this " is intended or not. The problematic type is there: https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fgolang%2Fgo%2Fblob%2Fmaster%2Fsrc%2Fcrypto%2Fx509%2Fx509.go%23L2674&data=04%7C01%7Cclement.chigot%40atos.net%7Ce85b8b57669c47db583508d896db2fc2%7C33440fc6b7c7412cbb730e70b0198d5a%7C0%7C0%7C637425215428486700%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=aB6diiR9Tgo3FTKOm0vmqVVJ%2B5JlCwd9oM5WeUaTaF4%3D&reserved=0. Other similar types don't trigger the bug though. > > I've a minimal test which might can be added if you wish, in Golang tests or in Gcc Go tests or in both ? > > If the patch is okay, could you please apply it for me ? Could you show me the small test case? I don't think I understand the problem. In DWARF I don't see any symbol names with quotation marks. I'm not yet sure that your patch is the right fix. Thanks. Ian ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] gcc: handle double quotes in symbol name during stabstrings generation 2020-12-08 13:15 ` CHIGOT, CLEMENT @ 2020-12-11 5:09 ` Ian Lance Taylor 2020-12-11 17:58 ` Ian Lance Taylor 0 siblings, 1 reply; 7+ messages in thread From: Ian Lance Taylor @ 2020-12-11 5:09 UTC (permalink / raw) To: CHIGOT, CLEMENT; +Cc: gcc-patches, David Edelsohn, gofrontend-dev On Tue, Dec 8, 2020 at 5:15 AM CHIGOT, CLEMENT <clement.chigot@atos.net> wrote: > > Any news about this bug ? It's not urgent even if it's breaking gcc builds with Go language, but I just want to know if you need any inputs/help from me. I sent https://golang.org/cl/277232 to fix this problem. Ian > ________________________________ > From: CHIGOT, CLEMENT <clement.chigot@atos.net> > Sent: Wednesday, December 2, 2020 5:14 PM > To: Ian Lance Taylor <iant@golang.org> > Cc: gcc-patches@gcc.gnu.org <gcc-patches@gcc.gnu.org>; David Edelsohn <dje.gcc@gmail.com> > Subject: Re: [PATCH] gcc: handle double quotes in symbol name during stabstrings generation > > Hi Ian, > > Here is the test case. > If you're compiling with -gstabs you should have a line looking like: > .stabs "type..struct{Type go.bug1.ObjectIdentifier;Value [][]go.bug1.Extension{asn1:"set"}}:G(0,7)=xsStructType:",32,0,0,0 > > As you can see the " around for "set" aren't escaped. > I didn't try to reproduce it on linux/amd64, but I did on linux/ppc64le and I don't think it's a ppc-only bug. > > Clément > ________________________________ > From: Ian Lance Taylor <iant@golang.org> > Sent: Wednesday, December 2, 2020 4:55 PM > To: CHIGOT, CLEMENT <clement.chigot@atos.net> > Cc: gcc-patches@gcc.gnu.org <gcc-patches@gcc.gnu.org>; David Edelsohn <dje.gcc@gmail.com> > Subject: Re: [PATCH] gcc: handle double quotes in symbol name during stabstrings generation > > Caution! External email. Do not open attachments or click links, unless this email comes from a known sender and you know the content is safe. > > On Wed, Dec 2, 2020 at 4:24 AM CHIGOT, CLEMENT <clement.chigot@atos.net> wrote: > > > > Since the new gccgo mangling scheme, libgo compilation is broken on AIX (or in Linux with -gstabs) because of a type symbol having a " in its name. I've made a patch (see attachment) in order to fix stabstring generation, because, IMO, it should be handled anyway. > > However, it happens only once in the whole libgo so I don't know if this " is intended or not. The problematic type is there: https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fgolang%2Fgo%2Fblob%2Fmaster%2Fsrc%2Fcrypto%2Fx509%2Fx509.go%23L2674&data=04%7C01%7Cclement.chigot%40atos.net%7Ce85b8b57669c47db583508d896db2fc2%7C33440fc6b7c7412cbb730e70b0198d5a%7C0%7C0%7C637425215428486700%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=aB6diiR9Tgo3FTKOm0vmqVVJ%2B5JlCwd9oM5WeUaTaF4%3D&reserved=0. Other similar types don't trigger the bug though. > > > > I've a minimal test which might can be added if you wish, in Golang tests or in Gcc Go tests or in both ? > > > > If the patch is okay, could you please apply it for me ? > > Could you show me the small test case? I don't think I understand the > problem. In DWARF I don't see any symbol names with quotation marks. > I'm not yet sure that your patch is the right fix. Thanks. > > Ian ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] gcc: handle double quotes in symbol name during stabstrings generation 2020-12-11 5:09 ` Ian Lance Taylor @ 2020-12-11 17:58 ` Ian Lance Taylor 2020-12-14 13:36 ` CHIGOT, CLEMENT 0 siblings, 1 reply; 7+ messages in thread From: Ian Lance Taylor @ 2020-12-11 17:58 UTC (permalink / raw) To: CHIGOT, CLEMENT; +Cc: gcc-patches, David Edelsohn, gofrontend-dev On Thu, Dec 10, 2020 at 9:09 PM Ian Lance Taylor <iant@golang.org> wrote: > > On Tue, Dec 8, 2020 at 5:15 AM CHIGOT, CLEMENT <clement.chigot@atos.net> wrote: > > > > Any news about this bug ? It's not urgent even if it's breaking gcc builds with Go language, but I just want to know if you need any inputs/help from me. > > I sent https://golang.org/cl/277232 to fix this problem. Should be fixed now. Ian > > ________________________________ > > From: CHIGOT, CLEMENT <clement.chigot@atos.net> > > Sent: Wednesday, December 2, 2020 5:14 PM > > To: Ian Lance Taylor <iant@golang.org> > > Cc: gcc-patches@gcc.gnu.org <gcc-patches@gcc.gnu.org>; David Edelsohn <dje.gcc@gmail.com> > > Subject: Re: [PATCH] gcc: handle double quotes in symbol name during stabstrings generation > > > > Hi Ian, > > > > Here is the test case. > > If you're compiling with -gstabs you should have a line looking like: > > .stabs "type..struct{Type go.bug1.ObjectIdentifier;Value [][]go.bug1.Extension{asn1:"set"}}:G(0,7)=xsStructType:",32,0,0,0 > > > > As you can see the " around for "set" aren't escaped. > > I didn't try to reproduce it on linux/amd64, but I did on linux/ppc64le and I don't think it's a ppc-only bug. > > > > Clément > > ________________________________ > > From: Ian Lance Taylor <iant@golang.org> > > Sent: Wednesday, December 2, 2020 4:55 PM > > To: CHIGOT, CLEMENT <clement.chigot@atos.net> > > Cc: gcc-patches@gcc.gnu.org <gcc-patches@gcc.gnu.org>; David Edelsohn <dje.gcc@gmail.com> > > Subject: Re: [PATCH] gcc: handle double quotes in symbol name during stabstrings generation > > > > Caution! External email. Do not open attachments or click links, unless this email comes from a known sender and you know the content is safe. > > > > On Wed, Dec 2, 2020 at 4:24 AM CHIGOT, CLEMENT <clement.chigot@atos.net> wrote: > > > > > > Since the new gccgo mangling scheme, libgo compilation is broken on AIX (or in Linux with -gstabs) because of a type symbol having a " in its name. I've made a patch (see attachment) in order to fix stabstring generation, because, IMO, it should be handled anyway. > > > However, it happens only once in the whole libgo so I don't know if this " is intended or not. The problematic type is there: https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fgolang%2Fgo%2Fblob%2Fmaster%2Fsrc%2Fcrypto%2Fx509%2Fx509.go%23L2674&data=04%7C01%7Cclement.chigot%40atos.net%7Ce85b8b57669c47db583508d896db2fc2%7C33440fc6b7c7412cbb730e70b0198d5a%7C0%7C0%7C637425215428486700%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=aB6diiR9Tgo3FTKOm0vmqVVJ%2B5JlCwd9oM5WeUaTaF4%3D&reserved=0. Other similar types don't trigger the bug though. > > > > > > I've a minimal test which might can be added if you wish, in Golang tests or in Gcc Go tests or in both ? > > > > > > If the patch is okay, could you please apply it for me ? > > > > Could you show me the small test case? I don't think I understand the > > problem. In DWARF I don't see any symbol names with quotation marks. > > I'm not yet sure that your patch is the right fix. Thanks. > > > > Ian ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] gcc: handle double quotes in symbol name during stabstrings generation 2020-12-11 17:58 ` Ian Lance Taylor @ 2020-12-14 13:36 ` CHIGOT, CLEMENT 0 siblings, 0 replies; 7+ messages in thread From: CHIGOT, CLEMENT @ 2020-12-14 13:36 UTC (permalink / raw) To: Ian Lance Taylor; +Cc: gcc-patches, David Edelsohn, gofrontend-dev Hi Ian, Yes it is. Thanks, Clément ________________________________ From: Ian Lance Taylor <iant@golang.org> Sent: Friday, December 11, 2020 6:58 PM To: CHIGOT, CLEMENT <clement.chigot@atos.net> Cc: gcc-patches@gcc.gnu.org <gcc-patches@gcc.gnu.org>; David Edelsohn <dje.gcc@gmail.com>; gofrontend-dev <gofrontend-dev@googlegroups.com> Subject: Re: [PATCH] gcc: handle double quotes in symbol name during stabstrings generation Caution! External email. Do not open attachments or click links, unless this email comes from a known sender and you know the content is safe. On Thu, Dec 10, 2020 at 9:09 PM Ian Lance Taylor <iant@golang.org> wrote: > > On Tue, Dec 8, 2020 at 5:15 AM CHIGOT, CLEMENT <clement.chigot@atos.net> wrote: > > > > Any news about this bug ? It's not urgent even if it's breaking gcc builds with Go language, but I just want to know if you need any inputs/help from me. > > I sent https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgolang.org%2Fcl%2F277232&data=04%7C01%7Cclement.chigot%40atos.net%7C237c1d4eb8f24966de6e08d89dfe60e2%7C33440fc6b7c7412cbb730e70b0198d5a%7C0%7C0%7C637433063155263771%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=NFRDFAbOGs%2FPqcYp%2BN4U80xXQctwoX3pUSY%2FVrca%2B4w%3D&reserved=0 to fix this problem. Should be fixed now. Ian > > ________________________________ > > From: CHIGOT, CLEMENT <clement.chigot@atos.net> > > Sent: Wednesday, December 2, 2020 5:14 PM > > To: Ian Lance Taylor <iant@golang.org> > > Cc: gcc-patches@gcc.gnu.org <gcc-patches@gcc.gnu.org>; David Edelsohn <dje.gcc@gmail.com> > > Subject: Re: [PATCH] gcc: handle double quotes in symbol name during stabstrings generation > > > > Hi Ian, > > > > Here is the test case. > > If you're compiling with -gstabs you should have a line looking like: > > .stabs "type..struct{Type go.bug1.ObjectIdentifier;Value [][]go.bug1.Extension{asn1:"set"}}:G(0,7)=xsStructType:",32,0,0,0 > > > > As you can see the " around for "set" aren't escaped. > > I didn't try to reproduce it on linux/amd64, but I did on linux/ppc64le and I don't think it's a ppc-only bug. > > > > Clément > > ________________________________ > > From: Ian Lance Taylor <iant@golang.org> > > Sent: Wednesday, December 2, 2020 4:55 PM > > To: CHIGOT, CLEMENT <clement.chigot@atos.net> > > Cc: gcc-patches@gcc.gnu.org <gcc-patches@gcc.gnu.org>; David Edelsohn <dje.gcc@gmail.com> > > Subject: Re: [PATCH] gcc: handle double quotes in symbol name during stabstrings generation > > > > Caution! External email. Do not open attachments or click links, unless this email comes from a known sender and you know the content is safe. > > > > On Wed, Dec 2, 2020 at 4:24 AM CHIGOT, CLEMENT <clement.chigot@atos.net> wrote: > > > > > > Since the new gccgo mangling scheme, libgo compilation is broken on AIX (or in Linux with -gstabs) because of a type symbol having a " in its name. I've made a patch (see attachment) in order to fix stabstring generation, because, IMO, it should be handled anyway. > > > However, it happens only once in the whole libgo so I don't know if this " is intended or not. The problematic type is there: https://github.com/golang/go/blob/master/src/crypto/x509/x509.go#L2674. Other similar types don't trigger the bug though. > > > > > > I've a minimal test which might can be added if you wish, in Golang tests or in Gcc Go tests or in both ? > > > > > > If the patch is okay, could you please apply it for me ? > > > > Could you show me the small test case? I don't think I understand the > > problem. In DWARF I don't see any symbol names with quotation marks. > > I'm not yet sure that your patch is the right fix. Thanks. > > > > Ian ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2020-12-14 13:38 UTC | newest] Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2020-12-02 12:24 [PATCH] gcc: handle double quotes in symbol name during stabstrings generation CHIGOT, CLEMENT 2020-12-02 15:55 ` Ian Lance Taylor 2020-12-02 16:14 ` CHIGOT, CLEMENT 2020-12-08 13:15 ` CHIGOT, CLEMENT 2020-12-11 5:09 ` Ian Lance Taylor 2020-12-11 17:58 ` Ian Lance Taylor 2020-12-14 13:36 ` CHIGOT, CLEMENT
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).