From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 79376 invoked by alias); 12 May 2017 12:49:50 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 79304 invoked by uid 89); 12 May 2017 12:49:49 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-10.1 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,GIT_PATCH_3,KAM_ASCII_DIVIDERS,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=ham version=3.3.2 spammy=1.8, concurrent X-HELO: mail-oi0-f52.google.com Received: from mail-oi0-f52.google.com (HELO mail-oi0-f52.google.com) (209.85.218.52) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 12 May 2017 12:49:47 +0000 Received: by mail-oi0-f52.google.com with SMTP id b204so64405781oii.1 for ; Fri, 12 May 2017 05:49:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=sJkMMXgL3NGZ5siBN3jsAKlCc3JS64YMjbcEaH+4l9E=; b=CkEqUOvC1zhA0hKX5S7Fg3SzxP3otyYalkPSW6ZVGr6+rfw+Hj++8szTkvU0uPfgHK C/vRdDESTgqEzPipptD7Y0AAYi+8jU3BCC2BLRJBQDYU0DMkOEh5dCSfRI9LKk373FOT CcBb0FG09cvBFVBtU0QmoPWmmWfu3d40w7tJ0i+UykAfbix8Y88gKecAibULnAQ2rDiO o6tg1yyqnuoHmRqPyDQ6ntYRRh3xaUr+HUDAFKufLgFYrXVAG9shhbG+OhdVjnW2FKZQ Ws7eeju9YyNbJGjdUlTQSkDAj1RennwIeZT2gR2nTfOzHHiMG5lbBvLbhyjLK9qsO0wJ bfBw== X-Gm-Message-State: AODbwcABZC3099CQwcoAWgOw55ADQpxHp8/fI84ykNfyad1nckYY5FYw hBfboKWuoo48I+IxylOC5yko6f4jSA== X-Received: by 10.157.49.68 with SMTP id v4mr1795166otd.131.1494593388744; Fri, 12 May 2017 05:49:48 -0700 (PDT) MIME-Version: 1.0 Received: by 10.202.102.11 with HTTP; Fri, 12 May 2017 05:49:48 -0700 (PDT) In-Reply-To: References: From: Ian Lance Taylor Date: Fri, 12 May 2017 12:54:00 -0000 Message-ID: Subject: Re: Go patches committed: merge recent changes to gofrontend To: Andrew Pinski Cc: gcc-patches , "gofrontend-dev@googlegroups.com" Content-Type: multipart/mixed; boundary="001a113d164e056575054f532482" X-SW-Source: 2017-05/txt/msg01030.txt.bz2 --001a113d164e056575054f532482 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Content-length: 2166 On Wed, May 10, 2017 at 5:37 PM, Andrew Pinski wrote: > On Wed, May 10, 2017 at 10:26 AM, Ian Lance Taylor wrot= e: >> I have committed a large patch to update the Go frontend and libgo to >> the recent changes in the gofrontend repository. I had postponed >> merging changes during the GCC 7 release process. I am now merging >> all the changes that were pending during that period. Although this >> is a merged patch, the changes can be seen individually in the >> gofrontend repo (https://go.googlesource.com/gofrontend). They are >> also listed below. >> >> This is a fairly significant patch that brings in the concurrent >> garbage collector used in the Go 1.8 runtime. This significantly >> reduces pauses due to garbage collection while running a Go program. >> >> This patch also brings in experimental support for AIX for gccgo, >> contributed by Matthieu Sarter and others at Atos Infog=C3=A9rance. >> >> The actual patch is too large for this e-mail patch, but I have >> attached all the changes to the gcc/go directory. >> >> Ian > > > This causes a build failure on aarch64-linux-gnu: > ../../../gcc/libgo/runtime/proc.c: In function =E2=80=98runtime_malg=E2= =80=99: > ../../../gcc/libgo/runtime/proc.c:729:43: warning: implicit > declaration of function =E2=80=98mstats=E2=80=99; did you mean =E2=80=98m= start1=E2=80=99? > [-Wimplicit-function-declaration] > void *p =3D runtime_sysAlloc(stacksize, &mstats()->other_sys); > ^~~~~~ > mstart1 > ../../../gcc/libgo/runtime/proc.c:729:51: error: invalid type argument > of =E2=80=98->=E2=80=99 (have =E2=80=98int=E2=80=99) > void *p =3D runtime_sysAlloc(stacksize, &mstats()->other_sys); Sorry about that. I intended to test on a non-split-stack system, but I forgot. This patch fixes the build problem and lets most of the testsuite pass. I still see two test failures on non-split-stack that I need to look into (index0-out and runtime on 32-bit systems). Patch tested on x86_64-pc-linux-gnu with and without split-stack enabled. Committed to mainline. Ian --001a113d164e056575054f532482 Content-Type: text/plain; charset="US-ASCII"; name="patch.txt" Content-Disposition: attachment; filename="patch.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_j2lub5hi0 Content-length: 3038 SW5kZXg6IGdjYy9nby9nb2Zyb250ZW5kL01FUkdFCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIGdjYy9nby9nb2Zyb250ZW5kL01FUkdFCShyZXZpc2lv biAyNDc5NDgpCisrKyBnY2MvZ28vZ29mcm9udGVuZC9NRVJHRQkod29ya2lu ZyBjb3B5KQpAQCAtMSw0ICsxLDQgQEAKLTNjMTI1ODE1NmEyYWU0ODNjNWNj NTIzY2I3YTNjMzM3NGNiZTdjMmMKK2Q1YmZhNmNlYmIxOWExNTRjYmZiYzUz ZjZlNjQ3ZDJjYTdhZGVmNjgKIAogVGhlIGZpcnN0IGxpbmUgb2YgdGhpcyBm aWxlIGhvbGRzIHRoZSBnaXQgcmV2aXNpb24gbnVtYmVyIG9mIHRoZSBsYXN0 CiBtZXJnZSBkb25lIGZyb20gdGhlIGdvZnJvbnRlbmQgcmVwb3NpdG9yeS4K SW5kZXg6IGxpYmdvL2dvL3J1bnRpbWUvcnVudGltZTIuZ28KPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gbGliZ28vZ28vcnVudGltZS9ydW50aW1lMi5n bwkocmV2aXNpb24gMjQ3OTMxKQorKysgbGliZ28vZ28vcnVudGltZS9ydW50 aW1lMi5nbwkod29ya2luZyBjb3B5KQpAQCAtNzkzLDMgKzc5MywxMCBAQCB0 eXBlIGdfdWNvbnRleHRfdCBbKF9zaXplb2ZfdWNvbnRleHRfdCArCiAvLyBz aWdzZXQgaXMgdGhlIEdvIHZlcnNpb24gb2YgdGhlIEMgdHlwZSBzaWdzZXRf dC4KIC8vIF9zaWdzZXRfdCBpcyBkZWZpbmVkIGJ5IHRoZSBNYWtlZmlsZSBm cm9tIDxzaWduYWwuaD4uCiB0eXBlIHNpZ3NldCBfc2lnc2V0X3QKKworLy8g Z2V0TWVtc3RhdHMgcmV0dXJucyBhIHBvaW50ZXIgdG8gdGhlIGludGVybmFs IG1lbXN0YXRzIHZhcmlhYmxlLAorLy8gZm9yIEMgY29kZS4KKy8vZ286bGlu a25hbWUgZ2V0TWVtc3RhdHMgcnVudGltZS5nZXRNZW1zdGF0cworZnVuYyBn ZXRNZW1zdGF0cygpICptc3RhdHMgeworCXJldHVybiAmbWVtc3RhdHMKK30K SW5kZXg6IGxpYmdvL3J1bnRpbWUvcHJvYy5jCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIGxpYmdvL3J1bnRpbWUvcHJvYy5jCShyZXZpc2lvbiAyNDc4 NDgpCisrKyBsaWJnby9ydW50aW1lL3Byb2MuYwkod29ya2luZyBjb3B5KQpA QCAtNDA2LDYgKzQwNiw4IEBAIGV4dGVybiB2b2lkIGdsb2JydW5xcHV0KEcq KQogICBfX2FzbV9fKEdPU1lNX1BSRUZJWCAicnVudGltZS5nbG9icnVucXB1 dCIpOwogZXh0ZXJuIFAqIHBpZGxlZ2V0KHZvaWQpCiAgIF9fYXNtX18oR09T WU1fUFJFRklYICJydW50aW1lLnBpZGxlZ2V0Iik7CitleHRlcm4gc3RydWN0 IG1zdGF0cyogZ2V0TWVtc3RhdHModm9pZCkKKyAgX19hc21fXyhHT1NZTV9Q UkVGSVggInJ1bnRpbWUuZ2V0TWVtc3RhdHMiKTsKIAogYm9vbCBydW50aW1l X2lzc3RhcnRlZDsKIApAQCAtNzI2LDcgKzcyOCw3IEBAIHJ1bnRpbWVfbWFs Zyhib29sIGFsbG9jYXRlc3RhY2ssIGJvb2wgc2kKICAgICAgICAgICAgICAg ICAvLyAzMi1iaXQgbW9kZSwgdGhlIEdvIGFsbG9jYXRpb24gc3BhY2UgaXMg YWxsIG9mCiAgICAgICAgICAgICAgICAgLy8gbWVtb3J5IGFueWhvdy4KIAkJ aWYoc2l6ZW9mKHZvaWQqKSA9PSA4KSB7Ci0JCQl2b2lkICpwID0gcnVudGlt ZV9zeXNBbGxvYyhzdGFja3NpemUsICZtc3RhdHMoKS0+b3RoZXJfc3lzKTsK KwkJCXZvaWQgKnAgPSBydW50aW1lX3N5c0FsbG9jKHN0YWNrc2l6ZSwgJmdl dE1lbXN0YXRzKCktPnN0YWNrc19zeXMpOwogCQkJaWYocCA9PSBuaWwpCiAJ CQkJcnVudGltZV90aHJvdygicnVudGltZTogY2Fubm90IGFsbG9jYXRlIG1l bW9yeSBmb3IgZ29yb3V0aW5lIHN0YWNrIik7CiAJCQkqcmV0X3N0YWNrID0g KGJ5dGUqKXA7CkluZGV4OiBsaWJnby9ydW50aW1lL3N0YWNrLmMKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gbGliZ28vcnVudGltZS9zdGFjay5jCShy ZXZpc2lvbiAyNDc4NDgpCisrKyBsaWJnby9ydW50aW1lL3N0YWNrLmMJKHdv cmtpbmcgY29weSkKQEAgLTgwLDcgKzgwLDYgQEAgc3RhdGljIHZvaWQgZG9z Y2Fuc3RhY2sxKEcgKmdwLCB2b2lkICpnYwogCQkJc2NhbnN0YWNrYmxvY2so c3AsICh1aW50cHRyKShzcHNpemUpLCBnY3cpOwogCX0KICNlbHNlCi0JTSAq bXA7CiAJYnl0ZSogYm90dG9tOwogCWJ5dGUqIHRvcDsKIAo= --001a113d164e056575054f532482--