From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x634.google.com (mail-ej1-x634.google.com [IPv6:2a00:1450:4864:20::634]) by sourceware.org (Postfix) with ESMTPS id 2A7283853814 for ; Tue, 3 Aug 2021 23:36:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 2A7283853814 Received: by mail-ej1-x634.google.com with SMTP id hw6so993485ejc.10 for ; Tue, 03 Aug 2021 16:36:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=aagum5qZgVOMiZWwKMfswXQBOEfFKat+VUiZm2APUxM=; b=uYT0HsPPV53YjsGxMT5Spt2bFHj3/I0Bs9xQ/51D95UuP8eGkg/O1wJl22mKfs1isN lYYralvF5aE9f1kW2Ut5yPFRQgOtFAkScP3KhJ3sUuwLGbUTH8g3APr7mV2LkFB8FMzE i6gAvn1/xOWgAHL/jYJyM6ASVFK/lk8xApXm9nS7/945VEQSJFx5NVDBQcUpxeL8CSof ZthFEKeCFolo4DVwsvMu0hJTgLwir1Qn7XbsVIJmiTR0w13XnALPMML6UWYAnWTT4D/U AsEsbCjmQWGciCrDoPusOUfQNWXcE/FV/vlP4vei+sOaUgug80Li2ut8rEqInLkgggeC ko0g== X-Gm-Message-State: AOAM533nS7KKYOy9kwgNlO+6a3NV3D2jhEAbSkPIIFCTJ0IZib0rF7oo KBQ8hycW1A5oNshNbciWBQhm54Bj6yY+gGUCF3Q46idNNKo= X-Google-Smtp-Source: ABdhPJxS0gmOEHRageV9IAdH7IyZ/16NpeQzebQ/G6OGOjrcVWt2eHLg5K9dcQzk6AE+waY8cr7A3nx+u04zcSCx0hM= X-Received: by 2002:a17:906:4751:: with SMTP id j17mr23395971ejs.39.1628033800045; Tue, 03 Aug 2021 16:36:40 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Ian Lance Taylor Date: Tue, 3 Aug 2021 16:36:29 -0700 Message-ID: Subject: Re: Go patch committed: Allow converting from slice to pointer-to-array To: gcc-patches , gofrontend-dev Content-Type: multipart/mixed; boundary="00000000000055dce105c8b02894" X-Spam-Status: No, score=-11.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Aug 2021 23:36:42 -0000 --00000000000055dce105c8b02894 Content-Type: text/plain; charset="UTF-8" On Mon, Aug 2, 2021 at 3:53 PM Ian Lance Taylor wrote: > > The upcoming Go 1.17 release has a new language feature: it permits > conversions from slice types to pointer-to-array types. If the slice > is too short, the conversion panics. This patch implements this new > feature in gccgo. Bootstrapped and ran Go testsuite on > x86_64-pc-linux-gnu. Committed to mainline. I didn't get the type checking right: I forgot to check that the element types of the slice and array are identical. Fixed with this patches. Bootstrapped and tested on x86_64-pc-linux-gnu. Committed to mainline. Ian --00000000000055dce105c8b02894 Content-Type: text/plain; charset="US-ASCII"; name="patch.txt" Content-Disposition: attachment; filename="patch.txt" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_krwp9rwj0 N2ZmMjc0MmVhY2VlOTNjN2U3ZDkyNjJkMDdjMjQ5NmY4N2Q4MDFhNwpkaWZmIC0tZ2l0IGEvZ2Nj L2dvL2dvZnJvbnRlbmQvTUVSR0UgYi9nY2MvZ28vZ29mcm9udGVuZC9NRVJHRQppbmRleCA5NWI5 MzQwYjQyZC4uODAxZTAzOWExNTUgMTAwNjQ0Ci0tLSBhL2djYy9nby9nb2Zyb250ZW5kL01FUkdF CisrKyBiL2djYy9nby9nb2Zyb250ZW5kL01FUkdFCkBAIC0xLDQgKzEsNCBAQAotMGE0ZDYxMmU2 YjIxMTc4MGIyOTQ3MTc1MDNmYzczOWJiZDFmNTA5YworNTQzNjE4MDViZDYxMWQ4OTYwNDJiODc5 ZWU3ZjZkMmQ0ZDA4ODUzNwogCiBUaGUgZmlyc3QgbGluZSBvZiB0aGlzIGZpbGUgaG9sZHMgdGhl IGdpdCByZXZpc2lvbiBudW1iZXIgb2YgdGhlIGxhc3QKIG1lcmdlIGRvbmUgZnJvbSB0aGUgZ29m cm9udGVuZCByZXBvc2l0b3J5LgpkaWZmIC0tZ2l0IGEvZ2NjL2dvL2dvZnJvbnRlbmQvZXhwcmVz c2lvbnMuY2MgYi9nY2MvZ28vZ29mcm9udGVuZC9leHByZXNzaW9ucy5jYwppbmRleCAxNWM5ZWFi YzZiZi4uNTFhOGI3ZTQzMjIgMTAwNjQ0Ci0tLSBhL2djYy9nby9nb2Zyb250ZW5kL2V4cHJlc3Np b25zLmNjCisrKyBiL2djYy9nby9nb2Zyb250ZW5kL2V4cHJlc3Npb25zLmNjCkBAIC0zOTYyLDcg KzM5NjIsMTAgQEAgVHlwZV9jb252ZXJzaW9uX2V4cHJlc3Npb246OmRvX2xvd2VyKEdvZ28qLCBO YW1lZF9vYmplY3QqLAogICBpZiAodHlwZS0+cG9pbnRzX3RvKCkgIT0gTlVMTAogICAgICAgJiYg dHlwZS0+cG9pbnRzX3RvKCktPmFycmF5X3R5cGUoKSAhPSBOVUxMCiAgICAgICAmJiAhdHlwZS0+ cG9pbnRzX3RvKCktPmlzX3NsaWNlX3R5cGUoKQotICAgICAgJiYgdmFsLT50eXBlKCktPmlzX3Ns aWNlX3R5cGUoKSkKKyAgICAgICYmIHZhbC0+dHlwZSgpLT5pc19zbGljZV90eXBlKCkKKyAgICAg ICYmIFR5cGU6OmFyZV9pZGVudGljYWwodHlwZS0+cG9pbnRzX3RvKCktPmFycmF5X3R5cGUoKS0+ ZWxlbWVudF90eXBlKCksCisJCQkgICAgIHZhbC0+dHlwZSgpLT5hcnJheV90eXBlKCktPmVsZW1l bnRfdHlwZSgpLAorCQkJICAgICAwLCBOVUxMKSkKICAgICB7CiAgICAgICBUZW1wb3Jhcnlfc3Rh dGVtZW50KiB2YWxfdGVtcCA9IE5VTEw7CiAgICAgICBpZiAoIXZhbC0+aXNfbXVsdGlfZXZhbF9z YWZlKCkpCmRpZmYgLS1naXQgYS9nY2MvZ28vZ29mcm9udGVuZC90eXBlcy5jYyBiL2djYy9nby9n b2Zyb250ZW5kL3R5cGVzLmNjCmluZGV4IDdjN2IyZWI4MjcxLi4wYzQ0MTg2ZjUwNyAxMDA2NDQK LS0tIGEvZ2NjL2dvL2dvZnJvbnRlbmQvdHlwZXMuY2MKKysrIGIvZ2NjL2dvL2dvZnJvbnRlbmQv dHlwZXMuY2MKQEAgLTg0Niw3ICs4NDYsOSBAQCBUeXBlOjphcmVfY29udmVydGlibGUoY29uc3Qg VHlwZSogbGhzLCBjb25zdCBUeXBlKiByaHMsIHN0ZDo6c3RyaW5nKiByZWFzb24pCiAgIGlmIChy aHMtPmlzX3NsaWNlX3R5cGUoKQogICAgICAgJiYgbGhzLT5wb2ludHNfdG8oKSAhPSBOVUxMCiAg ICAgICAmJiBsaHMtPnBvaW50c190bygpLT5hcnJheV90eXBlKCkgIT0gTlVMTAotICAgICAgJiYg IWxocy0+cG9pbnRzX3RvKCktPmlzX3NsaWNlX3R5cGUoKSkKKyAgICAgICYmICFsaHMtPnBvaW50 c190bygpLT5pc19zbGljZV90eXBlKCkKKyAgICAgICYmIFR5cGU6OmFyZV9pZGVudGljYWwobGhz LT5wb2ludHNfdG8oKS0+YXJyYXlfdHlwZSgpLT5lbGVtZW50X3R5cGUoKSwKKwkJCSAgICAgcmhz LT5hcnJheV90eXBlKCktPmVsZW1lbnRfdHlwZSgpLCAwLCByZWFzb24pKQogICAgIHJldHVybiB0 cnVlOwogCiAgIC8vIEFuIHVuc2FmZS5Qb2ludGVyIHR5cGUgbWF5IGJlIGNvbnZlcnRlZCB0byBh bnkgcG9pbnRlciB0eXBlIG9yIHRvCg== --00000000000055dce105c8b02894--