From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 76092 invoked by alias); 1 Nov 2015 20:46:53 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 76074 invoked by uid 89); 1 Nov 2015 20:46:52 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,KAM_ASCII_DIVIDERS,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=no version=3.3.2 X-HELO: mail-ig0-f180.google.com Received: from mail-ig0-f180.google.com (HELO mail-ig0-f180.google.com) (209.85.213.180) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Sun, 01 Nov 2015 20:46:51 +0000 Received: by igpw7 with SMTP id w7so44444825igp.0 for ; Sun, 01 Nov 2015 12:46:49 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:date:message-id:subject:from:to :content-type; bh=jFbkYh6zMRFAfu/IyRZCLfoYLAD9NBHrOsLAOim93Zk=; b=CAGsVuYQp/Ks0x1eJ2nBk+/Tqz1Xd3XpPaM9BcTeH3/UVTH0lVp/sq+bansmwMijLX JPqbMa/aT9deD0NNr2h6lXzvVOwE8t0+7K8sr2WPEX1h/uJ3qsi0Jw9StIBG77oWYYMR WKkEnCD0y/dEti3KmdOL1mDTnz03KpVPFCaYJG0jK1pXiE0h51/VLFW9cJZIkJLDGPOr QbuYtR4Gf1bwqGQnuF+jP/JwyYGtEdGDP0/8j6kb+OTBH2Vuk9mzpkZ1zYyyuRh1o4dL wXiKrFkb3TfR96oh2927XpqHUNQJeKBC22SNCCXhY4CvTHDLZ08Gg/CIUvesx0xtUEi6 mmuw== X-Gm-Message-State: ALoCoQmeqPJ2bi5KTmKUJSFZ8uLnjz7HYJdLB615Mi6HMd9VFhwzdG54vntNOVyiDR9MIBnXn6KJ MIME-Version: 1.0 X-Received: by 10.50.73.228 with SMTP id o4mr8310123igv.37.1446410809182; Sun, 01 Nov 2015 12:46:49 -0800 (PST) Received: by 10.107.162.201 with HTTP; Sun, 1 Nov 2015 12:46:49 -0800 (PST) Date: Sun, 01 Nov 2015 20:46:00 -0000 Message-ID: Subject: Go patch committed: Traverse types of call expression From: Ian Lance Taylor To: gcc-patches , "gofrontend-dev@googlegroups.com" Content-Type: multipart/mixed; boundary=089e013a25487bb2ee052380c26e X-SW-Source: 2015-11/txt/msg00012.txt.bz2 --089e013a25487bb2ee052380c26e Content-Type: text/plain; charset=UTF-8 Content-length: 636 GCC PR 67968 provides a test case that causes a gccgo crash. The crash is because the compiler failed to build the hash and equality functions required for a type descriptor. The descriptor is for an unnamed type that is being returned by a function imported from a different package. The unnamed type is being implicitly converted to an interface type by a return statement. The fix is to ensure that the type of a call expression is always traversed. Bootstrapped and ran Go testsuite on x86_64-pc-linux-gnu. Committed to mainline and 5 branch. Test case sent out for the master testsuite as https://golang.org/cl/16532 . Ian --089e013a25487bb2ee052380c26e Content-Type: text/plain; charset=US-ASCII; name="patch.txt" Content-Disposition: attachment; filename="patch.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_iggznaqi0 Content-length: 1863 SW5kZXg6IGdjYy9nby9nb2Zyb250ZW5kL01FUkdFCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIGdjYy9nby9nb2Zyb250ZW5kL01FUkdFCShyZXZpc2lv biAyMjk2MzYpCisrKyBnY2MvZ28vZ29mcm9udGVuZC9NRVJHRQkod29ya2lu ZyBjb3B5KQpAQCAtMSw0ICsxLDQgQEAKLTFjMWYyMjY2NjJhNmM4NGVhZTgz ZjhhYWVjM2Q0NTAzZTcwYmU4NDMKKzY1ZmYxZDVmYjU4MTcxNzIyOWU1YzAy Nzk2ZDcxOTY3MWExZTg2MjgKIAogVGhlIGZpcnN0IGxpbmUgb2YgdGhpcyBm aWxlIGhvbGRzIHRoZSBnaXQgcmV2aXNpb24gbnVtYmVyIG9mIHRoZSBsYXN0 CiBtZXJnZSBkb25lIGZyb20gdGhlIGdvZnJvbnRlbmQgcmVwb3NpdG9yeS4K SW5kZXg6IGdjYy9nby9nb2Zyb250ZW5kL2V4cHJlc3Npb25zLmNjCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIGdjYy9nby9nb2Zyb250ZW5kL2V4cHJl c3Npb25zLmNjCShyZXZpc2lvbiAyMjk1NDEpCisrKyBnY2MvZ28vZ29mcm9u dGVuZC9leHByZXNzaW9ucy5jYwkod29ya2luZyBjb3B5KQpAQCAtODYwOCw2 ICs4NjA4LDE2IEBAIEJ1aWx0aW5fY2FsbF9leHByZXNzaW9uOjpkb19leHBv cnQoRXhwb3IKIGludAogQ2FsbF9leHByZXNzaW9uOjpkb190cmF2ZXJzZShU cmF2ZXJzZSogdHJhdmVyc2UpCiB7CisgIC8vIElmIHdlIGFyZSBjYWxsaW5n IGEgZnVuY3Rpb24gaW4gYSBkaWZmZXJlbnQgcGFja2FnZSB0aGF0IHJldHVy bnMKKyAgLy8gYW4gdW5uYW1lZCB0eXBlLCB0aGlzIG1heSBiZSB0aGUgb25s eSBjaGFuY2Ugd2UgZ2V0IHRvIHRyYXZlcnNlCisgIC8vIHRoYXQgdHlwZS4g IFdlIGRvbid0IHRyYXZlcnNlIHRoaXMtPnR5cGVfIGJlY2F1c2UgaXQgbWF5 IGJlIGEKKyAgLy8gQ2FsbF9tdWx0aXBsZV9yZXN1bHRfdHlwZSB0aGF0IHdp bGwganVzdCBsZWFkIGJhY2sgaGVyZS4KKyAgaWYgKHRoaXMtPnR5cGVfICE9 IE5VTEwgJiYgIXRoaXMtPnR5cGVfLT5pc19lcnJvcl90eXBlKCkpCisgICAg eworICAgICAgRnVuY3Rpb25fdHlwZSAqZm50eXBlID0gdGhpcy0+Z2V0X2Z1 bmN0aW9uX3R5cGUoKTsKKyAgICAgIGlmIChmbnR5cGUgIT0gTlVMTCAmJiBU eXBlOjp0cmF2ZXJzZShmbnR5cGUsIHRyYXZlcnNlKSA9PSBUUkFWRVJTRV9F WElUKQorCXJldHVybiBUUkFWRVJTRV9FWElUOworICAgIH0KICAgaWYgKEV4 cHJlc3Npb246OnRyYXZlcnNlKCZ0aGlzLT5mbl8sIHRyYXZlcnNlKSA9PSBU UkFWRVJTRV9FWElUKQogICAgIHJldHVybiBUUkFWRVJTRV9FWElUOwogICBp ZiAodGhpcy0+YXJnc18gIT0gTlVMTCkK --089e013a25487bb2ee052380c26e--