From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 69538 invoked by alias); 13 Aug 2016 02:53:00 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 69519 invoked by uid 89); 13 Aug 2016 02:52:57 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=0.7 required=5.0 tests=AWL,BAYES_50,KAM_ASCII_DIVIDERS,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=no version=3.3.2 spammy=Neither, os.lo, sk:filedi, dir_regfilego X-HELO: mail-io0-f177.google.com Received: from mail-io0-f177.google.com (HELO mail-io0-f177.google.com) (209.85.223.177) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 13 Aug 2016 02:52:47 +0000 Received: by mail-io0-f177.google.com with SMTP id b62so40417713iod.3 for ; Fri, 12 Aug 2016 19:52:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=0c+3x8wUOCuIUPtcENEzj7NX3j1oaibDxt8YtQUy4CU=; b=gKfK0QNyM2MSBsVV+jVA+hLyN1VUfB9+E2sSk5CT8k7iueOzDOQDxPEj79LnZn0I+W iU43mliA9XikSXBkcMaksxB+9zfeLwVCXQwPxHwq0nTHlPAR1bb1jy3ATHUlg3NwC+gO UBEgFYMggTraALd9oMu91UUyjSTzHnaDyDwbbUbiXqhIV5OLBqMDUk/xdrAg+AuIO9RD OfdxB1Z8sFAALVfSCj3PdWJ7ZhWPYryO/urKuSMRMdM6+c94BLcG9fU7R2Kk9mObku+F Pnzy/Tu5Vlo4kp4v9KBtAxLP+xJCVw70XyKhu41FHSZ0bfuXHQpjGG5iMajYCjwdUGn/ Kzrg== X-Gm-Message-State: AEkoouuw4cq+NhElNlMeVymEjGlHtodZgS6ovFO99UMc4OZmx8170sv2kzLXRyt91YKb7w3Ve8QKCLn2C1nIaA== X-Received: by 10.107.181.13 with SMTP id e13mr24363349iof.88.1471056765550; Fri, 12 Aug 2016 19:52:45 -0700 (PDT) MIME-Version: 1.0 Received: by 10.79.35.199 with HTTP; Fri, 12 Aug 2016 19:52:44 -0700 (PDT) In-Reply-To: References: From: Ian Lance Taylor Date: Sat, 13 Aug 2016 02:53:00 -0000 Message-ID: Subject: Re: libgo patch committed: Change build procedure to use build tags To: Rainer Orth Cc: gcc-patches , "gofrontend-dev@googlegroups.com" Content-Type: multipart/mixed; boundary=001a11443c58f4b7400539eb17b3 X-SW-Source: 2016-08/txt/msg01066.txt.bz2 --001a11443c58f4b7400539eb17b3 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Content-length: 2425 On Fri, Aug 12, 2016 at 6:56 AM, Rainer Orth wrote: > Hi Ian, > >>>> this patch broke i386-pc-solaris2.12 and sparc-sun-solaris2.12 >>>> bootstrap, however: in both cases, the 64-bit build of os.lo fails lik= e this: >>>> >>>> /vol/gcc/src/hg/trunk/local/libgo/go/os/dir.go:82:8: error: reference = to undefined name 'libc_readdir_r' >>>> i :=3D libc_readdir_r(file.dirinfo.dir, entryDirent, pr) >>>> ^ >>>> >>>> Neither dir_largefile.go (which is correctly omitted, being 32-bit onl= y) >>>> nor dir_regfile.go (which is needed here) is included in the >>>> compilation. >>> >>> Sorry, I don't know what I messed up in my testing. I committed the >>> appended patch, which should fix the problem. >> >> I had found a different one to the same effect, but running match.sh >> with yours looked right, too. > > here's another issue found during wider testing: on Solaris 10 with > /bin/ksh as CONFIG_SHELL, the build aborts like this: > > objcopy: 'bufio.o': No such file > Makefile:5072: recipe for target 'bufio.gox' failed > make[4]: *** [bufio.gox] Error 1 > > It turns out that no bufio.o is created indeed: > > /vol/gcc/src/hg/trunk/local/libgo/../install-sh -c -d .; files=3D`echo |= sed -e 's/[^ ]*\.gox//g' -e 's/[^ ]*\.dep//'`; /bin/ksh ./libtool --tag GO= --mode=3Dcompile /var/gcc/regression/trunk/10-gcc/build/./gcc/gccgo -B/var= /gcc/regression/trunk/10-gcc/build/./gcc/ -B/vol/gcc/i386-pc-solaris2.10/bi= n/ -B/vol/gcc/i386-pc-solaris2.10/lib/ -isystem /vol/gcc/i386-pc-solaris2.1= 0/include -isystem /vol/gcc/i386-pc-solaris2.10/sys-include -minline-al= l-stringops -g -O2 -I . -c -fgo-pkgpath=3D`echo bufio.lo | sed -e 's/.lo$/= /' -e 's/-go$//'` -o bufio.lo $files > > The list of input files, output from the likes of > > /bin/ksh /vol/gcc/src/hg/trunk/local/libgo/match.sh --goarch=3D386 --goos= =3Dsolaris --srcdir=3D/vol/gcc/src/hg/trunk/local/libgo/go/bufio --extrafil= es=3D"" > > is empty. Running match.sh with /bin/ksh -x reveals > > + set -e > + unset LANG > > where the script aborts. It turns out that /bin/ksh errors out on an > unset of a variable that isn't set. > > Maybe one could explicitly set LANG=3DC here, or use the `portable unset' > used in configure? That is a shell portability problem I was not aware of. I took your LANG=3DC suggestion. Bootstrapped and ran Go testsuite on x86_64-pc-linux-gnu. Committed to mainline. Ian --001a11443c58f4b7400539eb17b3 Content-Type: text/plain; charset=US-ASCII; name="patch.txt" Content-Disposition: attachment; filename="patch.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_irsl7lh00 Content-length: 1619 SW5kZXg6IGdjYy9nby9nb2Zyb250ZW5kL01FUkdFCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIGdjYy9nby9nb2Zyb250ZW5kL01FUkdFCShyZXZpc2lv biAyMzk0NDIpCisrKyBnY2MvZ28vZ29mcm9udGVuZC9NRVJHRQkod29ya2lu ZyBjb3B5KQpAQCAtMSw0ICsxLDQgQEAKLWQ1MTg5MGRjOTZhMmEzMzQ4NDYy MzcyOGJkYzhhYzI1ODY0NWU5Y2MKKzI0ZTBjNGM5OGUwNjE0YjE4OTIzMTZh Y2E3ODdmMWM1NjRmMmQyNjkKIAogVGhlIGZpcnN0IGxpbmUgb2YgdGhpcyBm aWxlIGhvbGRzIHRoZSBnaXQgcmV2aXNpb24gbnVtYmVyIG9mIHRoZSBsYXN0 CiBtZXJnZSBkb25lIGZyb20gdGhlIGdvZnJvbnRlbmQgcmVwb3NpdG9yeS4K SW5kZXg6IGxpYmdvL21hdGNoLnNoCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIGxpYmdvL21hdGNoLnNoCShyZXZpc2lvbiAyMzkyMjUpCisrKyBsaWJn by9tYXRjaC5zaAkod29ya2luZyBjb3B5KQpAQCAtMTAsMTAgKzEwLDEwIEBA CiAKIHNldCAtZQogCi11bnNldCBMQU5HCitMQU5HPUMKIExDX0FMTD1DCiBM Q19DVFlQRT1DCi1leHBvcnQgTENfQUxMIExDX0NUWVBFCitleHBvcnQgTEFO RyBMQ19BTEwgTENfQ1RZUEUKIAogc3JjZGlyPSIiCiBnb2FyY2g9IiIKSW5k ZXg6IGxpYmdvL3Rlc3RzdWl0ZS9nb3Rlc3QKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gbGliZ28vdGVzdHN1aXRlL2dvdGVzdAkocmV2aXNpb24gMjM5 MjU2KQorKysgbGliZ28vdGVzdHN1aXRlL2dvdGVzdAkod29ya2luZyBjb3B5 KQpAQCAtMTAsOSArMTAsMTAgQEAKIAogIyBNYWtlcyBlZ3JlcCxncmVwIHdv cmsgYmV0dGVyIGluIGdlbmVyYWwgaWYgd2UgcHV0IHRoZW0KICMgaW4gb3Jk aW5hcnkgQyBtb2RlIGluc3RlYWQgb2Ygd2hhdCB0aGUgY3VycmVudCBsYW5n dWFnZSBpcy4KLXVuc2V0IExBTkcKLWV4cG9ydCBMQ19BTEw9QwotZXhwb3J0 IExDX0NUWVBFPUMKK0xBTkc9QworTENfQUxMPUMKK0xDX0NUWVBFPUMKK2V4 cG9ydCBMQU5HIExDX0FMTCBMQ19DVFlQRQogCiBHQz0ke0dDOi1nY2Nnb30K IEdMPSR7R0w6LSR7R0MtZ2NjZ299fQo= --001a11443c58f4b7400539eb17b3--