From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 63402 invoked by alias); 9 Aug 2017 21:24:59 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 63103 invoked by uid 89); 9 Aug 2017 21:24:34 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-9.7 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,GIT_PATCH_3,KAM_ASCII_DIVIDERS,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1420 X-HELO: mail-pg0-f51.google.com Received: from mail-pg0-f51.google.com (HELO mail-pg0-f51.google.com) (74.125.83.51) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 09 Aug 2017 21:24:23 +0000 Received: by mail-pg0-f51.google.com with SMTP id u185so32898448pgb.1 for ; Wed, 09 Aug 2017 14:24:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=fWjU0tWs/WidLG2v3N7jBncxLdZcLVMIQQz4ss4X/Yk=; b=Z5xUKDkRz+uwqOe7PKCmg+vwZKdiqZOyWJSeWdH386fx06ylDqm70Xh+LTWfadNNxx dEcRSEBge+71Y0zcHOHbytlDbjaOFYpgn6r4yHhLZ9xLFuF+d/wZQ3dBvch4SAyUyLkD v2Sz7MEPYTYxiUWIVBXSQWR6GGcMVlOgOtrS5m7uu/xmusdfFUNdmXAxfP9grQ+GbjtJ r+viSmTC0CTWye9pBktbsziSFbq5vhtn8p/4k6WuQoAk5K3eC6EmxJiLWT63YKYVqb6P xd7nUqgc+kBOdfBUec+tyPEymVwp4sK8knBNXM3sz/vy48RqcIvwOmvEZEng23HmU1V9 bNZA== X-Gm-Message-State: AHYfb5joxfZLApevJoDYhiElT8iS153LJOoOmyKdh9aoJfGMObosrJ1+ +M97EeMVV7q7UXvB8lOURGvR90ARdLKz/Hk= X-Received: by 10.98.4.2 with SMTP id 2mr9566678pfe.112.1502313861633; Wed, 09 Aug 2017 14:24:21 -0700 (PDT) MIME-Version: 1.0 Received: by 10.100.149.12 with HTTP; Wed, 9 Aug 2017 14:24:21 -0700 (PDT) From: Ian Lance Taylor Date: Wed, 09 Aug 2017 21:41:00 -0000 Message-ID: Subject: Go patch committed: Fix shift type determination To: gcc-patches , "gofrontend-dev@googlegroups.com" Content-Type: multipart/mixed; boundary="001a114b37041080a3055658b48e" X-SW-Source: 2017-08/txt/msg00705.txt.bz2 --001a114b37041080a3055658b48e Content-Type: text/plain; charset="UTF-8" Content-length: 529 In Go it's possible to construct an lshift expression using unsafe.Sizeof that is technically a compile-time constant but can't be evaluated without going through backend methods. This patch by Than McIntosh ensures that in this case Type::make_non_abstract_type is called on the numeric operand of the shift (as opposed to leaving as abstract), to avoid an assert later on in the compiler flow. This fixes https://golang.org/issue/21372. Bootstrapped and ran Go testsuite on x86_64-pc-linux-gnu. Committed to mainline. Ian --001a114b37041080a3055658b48e Content-Type: text/plain; charset="US-ASCII"; name="patch.txt" Content-Disposition: attachment; filename="patch.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_j65ivq470 Content-length: 1184 SW5kZXg6IGdjYy9nby9nb2Zyb250ZW5kL01FUkdFCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIGdjYy9nby9nb2Zyb250ZW5kL01FUkdFCShyZXZpc2lv biAyNTA5OTIpCisrKyBnY2MvZ28vZ29mcm9udGVuZC9NRVJHRQkod29ya2lu ZyBjb3B5KQpAQCAtMSw0ICsxLDQgQEAKLTVmZDExMmU1YzI5NjhlOTQ3NjFj NDE1MTljNDUxZDc4OWUyM2E5MmIKKzQ4MGZkZmE5ZGQ0MTZiZDE3MTE1YTk0 ZmE2MDIxYzRkZDgwNWZjMzkKIAogVGhlIGZpcnN0IGxpbmUgb2YgdGhpcyBm aWxlIGhvbGRzIHRoZSBnaXQgcmV2aXNpb24gbnVtYmVyIG9mIHRoZSBsYXN0 CiBtZXJnZSBkb25lIGZyb20gdGhlIGdvZnJvbnRlbmQgcmVwb3NpdG9yeS4K SW5kZXg6IGdjYy9nby9nb2Zyb250ZW5kL2V4cHJlc3Npb25zLmNjCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIGdjYy9nby9nb2Zyb250ZW5kL2V4cHJl c3Npb25zLmNjCShyZXZpc2lvbiAyNTA4NzMpCisrKyBnY2MvZ28vZ29mcm9u dGVuZC9leHByZXNzaW9ucy5jYwkod29ya2luZyBjb3B5KQpAQCAtNTY1NSw3 ICs1NjU1LDcgQEAgQmluYXJ5X2V4cHJlc3Npb246OmRvX2RldGVybWluZV90 eXBlKGNvbgogCiAgIFR5cGVfY29udGV4dCBzdWJjb250ZXh0KCpjb250ZXh0 KTsKIAotICBpZiAoaXNfY29uc3RhbnRfZXhwcikKKyAgaWYgKGlzX2NvbnN0 YW50X2V4cHIgJiYgIWlzX3NoaWZ0X29wKQogICAgIHsKICAgICAgIHN1YmNv bnRleHQudHlwZSA9IE5VTEw7CiAgICAgICBzdWJjb250ZXh0Lm1heV9iZV9h YnN0cmFjdCA9IHRydWU7Cg== --001a114b37041080a3055658b48e--