From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7671 invoked by alias); 13 Aug 2016 00:14:34 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 7662 invoked by uid 89); 13 Aug 2016 00:14:34 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=0.8 required=5.0 tests=AWL,BAYES_50,KAM_ASCII_DIVIDERS,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=no version=3.3.2 spammy=Neither, UD:dir.go, UD:match.sh, dirgo X-HELO: mail-it0-f45.google.com Received: from mail-it0-f45.google.com (HELO mail-it0-f45.google.com) (209.85.214.45) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 13 Aug 2016 00:14:24 +0000 Received: by mail-it0-f45.google.com with SMTP id f6so1293249ith.0 for ; Fri, 12 Aug 2016 17:14:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=Xt/5M3PDGgAuHYH0TgZ6PUxyxg9fSFi7J1S8PeZOAis=; b=Ax0cL+L+qUpw1kmpYBVG08WgD5vxDLrS5IYGHViGW1SR0g9TMuXr1dUGWBAxCL2dV0 Cgi5OP+1Jj/c7toNj/5OVCoqzY8O61e7jfzO6KUUkdlMqMaqTvSP+XeUUY1rxML+vgAb C8dQla/iJLIIabyGvPtSEAYwio0MNymyy4dwoaJNUD9nzXD/6YWQzXDSuXdy4gD/L94L qyY3A3ts9TSVFSlBHAiCXa47xUpPdbmfv/51Iu8elpkM6/q0zqet9pXDz2hJIu4iTKy9 vovzrBmACEzMTI7ybN0kQWNGum93vH4RK7EaFR1ELUTMjY5G6ylPxiJLAg8ChRYFsYgR vV/w== X-Gm-Message-State: AEkooutSlBJsZaUih4s5mZzVSA2EeR4aPLOXrGFy2AWubMT2860DqphJBTRhF/t/TUqAJZ9FJu08aHwWOalcLQ== X-Received: by 10.36.41.202 with SMTP id p193mr592235itp.66.1471047262568; Fri, 12 Aug 2016 17:14:22 -0700 (PDT) MIME-Version: 1.0 Received: by 10.79.35.199 with HTTP; Fri, 12 Aug 2016 17:14:21 -0700 (PDT) In-Reply-To: References: From: Ian Lance Taylor Date: Sat, 13 Aug 2016 00:14:00 -0000 Message-ID: Subject: Re: libgo patch committed: Change build procedure to use build tags To: Rainer Orth Cc: gcc-patches , "gofrontend-dev@googlegroups.com" Content-Type: multipart/mixed; boundary=001a113f6c0688bf6b0539e8e1d1 X-SW-Source: 2016-08/txt/msg01063.txt.bz2 --001a113f6c0688bf6b0539e8e1d1 Content-Type: text/plain; charset=UTF-8 Content-length: 2759 On Fri, Aug 12, 2016 at 2:15 AM, Rainer Orth wrote: > >>> this patch broke i386-pc-solaris2.12 and sparc-sun-solaris2.12 >>> bootstrap, however: in both cases, the 64-bit build of os.lo fails like this: >>> >>> /vol/gcc/src/hg/trunk/local/libgo/go/os/dir.go:82:8: error: reference to undefined name 'libc_readdir_r' >>> i := libc_readdir_r(file.dirinfo.dir, entryDirent, pr) >>> ^ >>> >>> Neither dir_largefile.go (which is correctly omitted, being 32-bit only) >>> nor dir_regfile.go (which is needed here) is included in the >>> compilation. >> >> Sorry, I don't know what I messed up in my testing. I committed the >> appended patch, which should fix the problem. > > I had found a different one to the same effect, but running match.sh > with yours looked right, too. > > There's now one new failure, 32 and 64-bit, sparc and x86: > > +FAIL: syscall > > libgo.log shows > > libcalls.go:825:1: error: redefinition of 'Getpgid' > func Getpgid(pid int) (pgid int, err error) { > ^ > exec_solaris_test.go:22:1: note: previous definition of 'Getpgid' was here > func Getpgid(pid int) (pgid int, err error) { > ^ > libcalls.go:843:1: error: redefinition of 'Getpgrp' > func Getpgrp() (pid int) { > ^ > exec_solaris_test.go:31:1: note: previous definition of 'Getpgrp' was here > func Getpgrp() (pgrp int) { > ^ > exec_solaris_test.go:14:3: error: libc_Getpgid is not a function; //go:linkname is only supported for functions > //go:linkname libc_Getpgid libc_Getpgid > ^ > exec_solaris_test.go:15:3: error: libc_Getpgrp is not a function; //go:linkname is only supported for functions > //go:linkname libc_Getpgrp libc_Getpgrp > ^ > exec_solaris_test.go:23:15: error: reference to undefined name 'sysvicall6' > r0, _, e1 := sysvicall6(uintptr(unsafe.Pointer(&libc_Getpgid)), 1, uintptr(pid), 0, 0, 0, 0, 0) > ^ > exec_solaris_test.go:32:14: error: reference to undefined name 'sysvicall6' > r0, _, _ := sysvicall6(uintptr(unsafe.Pointer(&libc_Getpgrp)), 0, 0, 0, 0, 0, 0, 0) > ^ > exec_solaris_test.go:37:13: error: reference to undefined name 'ioctl' > var Ioctl = ioctl > ^ > exec_solaris_test.go:19:15: error: use of undefined type 'libcFunc' > libc_Getpgrp libcFunc > ^ > > I've no idea what exec_solaris_test.go is about: e.g.I couldn't find any > other reference to sysvicall6 elsewhere in the gcc tree. The file syscall/exec_solaris_test.go is verifying that the somewhat unusual way that Solaris support is implemented in the gc toolchain works correctly. It is meaningless and unnecessary for gccgo. I removed it. Patch bootstrapped and tested on x86_64-pc-linux-gnu, which I admit means nothing. Committed to mainline. Ian --001a113f6c0688bf6b0539e8e1d1 Content-Type: text/plain; charset=US-ASCII; name="patch.txt" Content-Disposition: attachment; filename="patch.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_irsfjm7g0 Content-length: 2030 SW5kZXg6IGdjYy9nby9nb2Zyb250ZW5kL01FUkdFCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIGdjYy9nby9nb2Zyb250ZW5kL01FUkdFCShyZXZpc2lv biAyMzkzOTMpCisrKyBnY2MvZ28vZ29mcm9udGVuZC9NRVJHRQkod29ya2lu ZyBjb3B5KQpAQCAtMSw0ICsxLDQgQEAKLWZlMWU3N2Y4NDMyMjA1MDNmMWY4 ZDVlYTdkZDVlMzA3NTgwZTFkMzgKK2NmOTE3MjBjNjUwZjJjZGJkODE1M2E1 YTVmMDQ4NzkzY2ZhYjM5NjYKIAogVGhlIGZpcnN0IGxpbmUgb2YgdGhpcyBm aWxlIGhvbGRzIHRoZSBnaXQgcmV2aXNpb24gbnVtYmVyIG9mIHRoZSBsYXN0 CiBtZXJnZSBkb25lIGZyb20gdGhlIGdvZnJvbnRlbmQgcmVwb3NpdG9yeS4K SW5kZXg6IGxpYmdvL2dvL3N5c2NhbGwvZXhlY19zb2xhcmlzX3Rlc3QuZ28K PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gbGliZ28vZ28vc3lzY2FsbC9l eGVjX3NvbGFyaXNfdGVzdC5nbwkocmV2aXNpb24gMjM4NjUzKQorKysgbGli Z28vZ28vc3lzY2FsbC9leGVjX3NvbGFyaXNfdGVzdC5nbwkod29ya2luZyBj b3B5KQpAQCAtMSwzNyArMCwwIEBACi0vLyBDb3B5cmlnaHQgMjAxNSBUaGUg R28gQXV0aG9ycy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KLS8vIFVzZSBvZiB0 aGlzIHNvdXJjZSBjb2RlIGlzIGdvdmVybmVkIGJ5IGEgQlNELXN0eWxlCi0v LyBsaWNlbnNlIHRoYXQgY2FuIGJlIGZvdW5kIGluIHRoZSBMSUNFTlNFIGZp bGUuCi0KLS8vICtidWlsZCBzb2xhcmlzCi0KLXBhY2thZ2Ugc3lzY2FsbAot Ci1pbXBvcnQgInVuc2FmZSIKLQotLy9nbzpjZ29faW1wb3J0X2R5bmFtaWMg bGliY19HZXRwZ2lkIGdldHBnaWQgImxpYmMuc28iCi0vL2dvOmNnb19pbXBv cnRfZHluYW1pYyBsaWJjX0dldHBncnAgZ2V0cGdycCAibGliYy5zbyIKLQot Ly9nbzpsaW5rbmFtZSBsaWJjX0dldHBnaWQgbGliY19HZXRwZ2lkCi0vL2dv OmxpbmtuYW1lIGxpYmNfR2V0cGdycCBsaWJjX0dldHBncnAKLQotdmFyICgK LQlsaWJjX0dldHBnaWQsCi0JbGliY19HZXRwZ3JwIGxpYmNGdW5jCi0pCi0K LWZ1bmMgR2V0cGdpZChwaWQgaW50KSAocGdpZCBpbnQsIGVyciBlcnJvcikg ewotCXIwLCBfLCBlMSA6PSBzeXN2aWNhbGw2KHVpbnRwdHIodW5zYWZlLlBv aW50ZXIoJmxpYmNfR2V0cGdpZCkpLCAxLCB1aW50cHRyKHBpZCksIDAsIDAs IDAsIDAsIDApCi0JcGdpZCA9IGludChyMCkKLQlpZiBlMSAhPSAwIHsKLQkJ ZXJyID0gZTEKLQl9Ci0JcmV0dXJuCi19Ci0KLWZ1bmMgR2V0cGdycCgpIChw Z3JwIGludCkgewotCXIwLCBfLCBfIDo9IHN5c3ZpY2FsbDYodWludHB0cih1 bnNhZmUuUG9pbnRlcigmbGliY19HZXRwZ3JwKSksIDAsIDAsIDAsIDAsIDAs IDAsIDApCi0JcGdycCA9IGludChyMCkKLQlyZXR1cm4KLX0KLQotdmFyIElv Y3RsID0gaW9jdGwK --001a113f6c0688bf6b0539e8e1d1--