From: Ian Lance Taylor <iant@golang.org>
To: Andreas Schwab <schwab@linux-m68k.org>
Cc: gcc-patches <gcc-patches@gcc.gnu.org>,
gofrontend-dev <gofrontend-dev@googlegroups.com>
Subject: Re: Go patch committed: Provide index information on bounds check failure
Date: Sat, 31 Aug 2019 06:30:00 -0000 [thread overview]
Message-ID: <CAOyqgcVyDtsZsj5xQXjHQ9=THOiMbFz5mp1zzSipvWRy8C9dYw@mail.gmail.com> (raw)
In-Reply-To: <87mufrsnkv.fsf@igel.home>
[-- Attachment #1: Type: text/plain, Size: 884 bytes --]
On Thu, Aug 29, 2019 at 1:50 PM Andreas Schwab <schwab@linux-m68k.org> wrote:
>
> On Aug 28 2019, Ian Lance Taylor <iant@golang.org> wrote:
>
> > This patch to the Go frontend and libgo changes the panic message
> > reported for an out of bounds index or slice operation to include the
> > invalid values.
>
> This breaks aarch64/-mabi=ilp32.
>
> aarch64-suse-linux/ilp32/libgo/archive/tar/check-testlog:
>
> /usr/aarch64-suse-linux/bin/ld: _gotest_.o: in function `archive..z2ftar.Reader.next':
> /opt/gcc/gcc-20190829/Build/aarch64-suse-linux/ilp32/libgo/gotest1086/test/reader.go:72: undefined reference to `runtime.goPanicExtendSliceAlen'
We should probably use a different GOARCH value for that build, such
as arm64p32. But for now I'm committing this patch which will fix
both problems by just always building panic32.go. Bootstrapped and
tested on x86_64-pc-linux-gnu.
Ian
[-- Attachment #2: patch.txt --]
[-- Type: text/plain, Size: 847 bytes --]
Index: gcc/go/gofrontend/MERGE
===================================================================
--- gcc/go/gofrontend/MERGE (revision 275227)
+++ gcc/go/gofrontend/MERGE (working copy)
@@ -1,4 +1,4 @@
-11fd9208f8545e882f945d3ed86fcc33abf1a61b
+2444eb1e8c697531f8beb403679e4ab00b16dbf5
The first line of this file holds the git revision number of the last
merge done from the gofrontend repository.
Index: libgo/go/runtime/panic32.go
===================================================================
--- libgo/go/runtime/panic32.go (revision 274998)
+++ libgo/go/runtime/panic32.go (working copy)
@@ -2,8 +2,6 @@
// Use of this source code is governed by a BSD-style
// license that can be found in the LICENSE file.
-// +build 386 amd64p32 arm mips mipsle m68k nios2 sh shbe
-
package runtime
import _ "unsafe" // for go:linkname
prev parent reply other threads:[~2019-08-31 2:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-28 19:01 Ian Lance Taylor
2019-08-29 21:14 ` Rainer Orth
2019-08-29 22:36 ` Andreas Schwab
2019-08-31 6:30 ` Ian Lance Taylor [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOyqgcVyDtsZsj5xQXjHQ9=THOiMbFz5mp1zzSipvWRy8C9dYw@mail.gmail.com' \
--to=iant@golang.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=gofrontend-dev@googlegroups.com \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).