From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x634.google.com (mail-ej1-x634.google.com [IPv6:2a00:1450:4864:20::634]) by sourceware.org (Postfix) with ESMTPS id BCB043858D3C for ; Sun, 3 Apr 2022 02:02:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org BCB043858D3C Received: by mail-ej1-x634.google.com with SMTP id a6so2375482ejk.0 for ; Sat, 02 Apr 2022 19:02:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=ZWdED50qbzTE6blDUf88MFk4nnr8y68U7p4ZfUUK9hQ=; b=wSku7ZaavxdZ8vsZqi6qODm78/K+N7GDewQZlSu0DxH5azgBW8TGfVi44FCOIj4t52 VQ+OY2V0+qre64pcam1zMQ31789R9u3ZGNAZ3Cr7ceSjlJLrgiLbeP3VvZoBPrVjaEIY BZ97hZIzPV3qNfFyM3kJU3LO30D5VjiOIWq7GeXz2/AhQlkQA9L/Hucz21YAcQI2hFx6 tznl5xXOBwSyHFT+Z+3FOovIOLsPkreyh+leekJUCccnpKC7Sp5SGEBtKli90EqHw0PE 6l3CMIqGhJwMRZhPhoMt+5GzpnlnFIjnFD1TNs7Eojf+Uy4y5813GrUIeg/kKyb14ZuF PyCA== X-Gm-Message-State: AOAM531ofOM5XnMAVXcMM73YdjTNhw846A3T5da01hqopnwHm0jBfDYr RL6M3Ana0IH/ACgW5fe2jev7wMcG+sI1hu/zi06wGQ== X-Google-Smtp-Source: ABdhPJwbhcL5Sb8OY+7s8RF3Xj1MJUbCmASE1f8Oy90U+OSa+YNfkawSXtBKlY3sL9/kTTOZ4V+daVC5/cY28dfOy0k= X-Received: by 2002:a17:907:72d0:b0:6db:4788:66a9 with SMTP id du16-20020a17090772d000b006db478866a9mr5821301ejc.516.1648951375163; Sat, 02 Apr 2022 19:02:55 -0700 (PDT) MIME-Version: 1.0 References: <20220311073406.26722-1-soeren@soeren-tempel.net> <22SFHJJH9SLH2.2A2YD69UFEBGS@8pit.net> <28CKR3HNP3V6M.3J4T5E3ITVM1J@8pit.net> In-Reply-To: <28CKR3HNP3V6M.3J4T5E3ITVM1J@8pit.net> From: Ian Lance Taylor Date: Sat, 2 Apr 2022 19:02:44 -0700 Message-ID: Subject: Re: [PATCH v4] libgo: Don't use pt_regs member in mcontext_t To: =?UTF-8?Q?S=C3=B6ren_Tempel?= Cc: gcc-patches@gcc.gnu.org, gofrontend-dev@googlegroups.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 03 Apr 2022 02:02:59 -0000 On Sat, Apr 2, 2022 at 1:21 AM S=C3=B6ren Tempel = wrote: > > Thanks for committing a first fix! Unfortunately, your changes don't > work on ppc64le musl since you are now still using .regs on ppc64le the > include of asm/ptrace.h (as added in the v1 of my patch) is missing. > Hence, your patch fails to compile on ppc64le musl with the following > error message: > > go-signal.c:230:63: error: invalid use of undefined type 'struct = pt_regs' > 230 | ret.sigpc =3D ((ucontext_t*)(context))->uc_mconte= xt.regs->nip; > > If you want to continue using .regs on ppc64le an include of > asm/ptrace.h is needed since both glibc and musl declare `struct > pt_regs` as an incomplete type (with glibc asm/ptrace.h is included > indirectly by other headers used by go-signal.c it seems). > > See https://gcc.gnu.org/pipermail/gcc-patches/2022-January/587520.html > > Would be nice if this could be fixed :) Sorry, I guess I misread your patch. What is the right standalone code for the PPC64 musl case? Thanks. Ian