From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <iant@golang.org>
Received: from mail-ed1-x529.google.com (mail-ed1-x529.google.com
 [IPv6:2a00:1450:4864:20::529])
 by sourceware.org (Postfix) with ESMTPS id C9BDC385841D
 for <gcc-patches@gcc.gnu.org>; Mon,  7 Mar 2022 22:59:14 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C9BDC385841D
Received: by mail-ed1-x529.google.com with SMTP id q17so22089986edd.4
 for <gcc-patches@gcc.gnu.org>; Mon, 07 Mar 2022 14:59:14 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=EEGn5CmMbEN1qcrq6ikbVvzcnIgARuJLnSZg32bil40=;
 b=SszmDRy6VqYiujBMz7LE7p8ZTsl123+1eVH8VUM4iIrAZP281qXJ+W8yu6gQKLKRyB
 /+kZYmaGDFYZ6y2hM7GsftUAnWNbkxo52lECTNfQ12zioHB2teRZKj06A8Z3yLwnl6Vd
 7qAxpVuokBtfWIha/cyqrj5TakSd6E8/aWWkJKJqs6S/JHKDqktDK6bvCoN8y8Wq0hg3
 MgbQjj13LdLa8177y0/G4W5amMFS6mFHrmElPxlxw8cSuSAW4FTihNt/T+GfSvCo3pfp
 NQiwy+s8mAS6y8meVJCOBvg4RMPdcqHVBamEXdqw9QGrBr5L8ERLfLOnXBilxE6ewnpN
 EXnQ==
X-Gm-Message-State: AOAM533uLuJkwVeQcYRWMskM9HyTPafVT/EOUXwa9bJRPUxF6PYpE0ny
 Nx7hp2mC7JzzoIxKYIYPLeDx4+blitnpPev0m0T3Jg==
X-Google-Smtp-Source: ABdhPJzrZvvgLpMA68w/fdB38O3cDEU0X4QG8SgqlhM1w5ahbpJFKKDKJ/9aabgCKEHwNge5rtGPIfSreEti0xiFEiI=
X-Received: by 2002:a05:6402:d0d:b0:416:1d69:f23b with SMTP id
 eb13-20020a0564020d0d00b004161d69f23bmr13258014edb.141.1646693953578; Mon, 07
 Mar 2022 14:59:13 -0800 (PST)
MIME-Version: 1.0
References: <20220306212140.GI7074@brightrain.aerifal.cx>
 <20220307070957.27119-1-soeren@soeren-tempel.net>
In-Reply-To: <20220307070957.27119-1-soeren@soeren-tempel.net>
From: Ian Lance Taylor <iant@golang.org>
Date: Mon, 7 Mar 2022 14:59:02 -0800
Message-ID: <CAOyqgcW3Q=cjdBF=oRZ81hbDyijBMnW7cdDP6gEB42ddDaFcWg@mail.gmail.com>
Subject: Re: [PATCH v3] libgo: Don't use pt_regs member in mcontext_t
To: soeren@soeren-tempel.net
Cc: gcc-patches@gcc.gnu.org, gofrontend-dev@googlegroups.com, 
 schwab@linux-m68k.org, dalias@libc.org
Content-Type: text/plain; charset="UTF-8"
X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP,
 T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
 server2.sourceware.org
X-BeenThere: gcc-patches@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc-patches mailing list <gcc-patches.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-patches>,
 <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-patches>,
 <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 07 Mar 2022 22:59:16 -0000

On Sun, Mar 6, 2022 at 11:11 PM <soeren@soeren-tempel.net> wrote:
>
> +#ifdef __PPC64__
> +       ret.sigpc = ((ucontext_t*)(context))->uc_mcontext.gp_regs[32];
> +#else
> +       ret.sigpc = ((ucontext_t*)(context))->uc_mcontext.gregs[32];
> +#endif

Have you tested this in 32-bit mode?  It does not look correct based
on the glibc definitions.  Looking at glibc it seems that it ought to
be

reg.sigpc = ((ucontext_t*)(context))->uc_mcontext.uc_regs->gregs[32];

Ian