* Change to gcc/testsuite/go.test/test rejected by ChangeLog checker
@ 2020-12-15 23:43 Ian Lance Taylor
2020-12-15 23:51 ` Ian Lance Taylor
0 siblings, 1 reply; 8+ messages in thread
From: Ian Lance Taylor @ 2020-12-15 23:43 UTC (permalink / raw)
To: gcc-patches
I'm trying to commit a change that adds a bunch of new files to
gcc/testsuite/go.test/test. It's being rejected because the hook
can't deduce a ChangeLog file. But this directory has no ChangeLog
files. I've committed other changes to this directory without a
ChangeLog entry.
What is going wrong? What can I do to commit this change? What
information can I provide?
Thanks.
Ian
> git push
Enumerating objects: 854, done.
Counting objects: 100% (854/854), done.
Delta compression using up to 8 threads
Compressing objects: 100% (824/824), done.
Writing objects: 100% (847/847), 266.10 KiB | 2.25 MiB/s, done.
Total 847 (delta 167), reused 3 (delta 0), pack-reused 0
remote: Resolving deltas: 100% (167/167), completed with 4 local objects.
remote: *** The following commit was rejected by your
hooks.commit-extra-checker script (status: 1)
remote: *** commit: b09ac944e04a59af95a5767f6835edad7da4f152
remote: *** ChangeLog format failed:
remote: *** ERR: could not deduce ChangeLog file
remote: ***
remote: *** Please see: https://gcc.gnu.org/codingconventions.html#ChangeLogs
remote: ***
remote: error: hook declined to update refs/heads/master
To git+ssh://gcc.gnu.org/git/gcc
! [remote rejected] master -> master (hook declined)
error: failed to push some refs to 'git+ssh://gcc.gnu.org/git/gcc'
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: Change to gcc/testsuite/go.test/test rejected by ChangeLog checker
2020-12-15 23:43 Change to gcc/testsuite/go.test/test rejected by ChangeLog checker Ian Lance Taylor
@ 2020-12-15 23:51 ` Ian Lance Taylor
2020-12-15 23:53 ` Ian Lance Taylor
0 siblings, 1 reply; 8+ messages in thread
From: Ian Lance Taylor @ 2020-12-15 23:51 UTC (permalink / raw)
To: gcc-patches
On Tue, Dec 15, 2020 at 3:43 PM Ian Lance Taylor <iant@golang.org> wrote:
>
> I'm trying to commit a change that adds a bunch of new files to
> gcc/testsuite/go.test/test. It's being rejected because the hook
> can't deduce a ChangeLog file. But this directory has no ChangeLog
> files. I've committed other changes to this directory without a
> ChangeLog entry.
>
> What is going wrong? What can I do to commit this change? What
> information can I provide?
>
> Thanks.
>
> Ian
>
> > git push
> Enumerating objects: 854, done.
> Counting objects: 100% (854/854), done.
> Delta compression using up to 8 threads
> Compressing objects: 100% (824/824), done.
> Writing objects: 100% (847/847), 266.10 KiB | 2.25 MiB/s, done.
> Total 847 (delta 167), reused 3 (delta 0), pack-reused 0
> remote: Resolving deltas: 100% (167/167), completed with 4 local objects.
> remote: *** The following commit was rejected by your
> hooks.commit-extra-checker script (status: 1)
> remote: *** commit: b09ac944e04a59af95a5767f6835edad7da4f152
> remote: *** ChangeLog format failed:
> remote: *** ERR: could not deduce ChangeLog file
> remote: ***
> remote: *** Please see: https://gcc.gnu.org/codingconventions.html#ChangeLogs
> remote: ***
> remote: error: hook declined to update refs/heads/master
> To git+ssh://gcc.gnu.org/git/gcc
> ! [remote rejected] master -> master (hook declined)
> error: failed to push some refs to 'git+ssh://gcc.gnu.org/git/gcc'
One less common change I am trying to make is to delete a file. Could
that be the cause of this problem?
I'm going to try removing the deleted file from the change.
Ian
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: Change to gcc/testsuite/go.test/test rejected by ChangeLog checker
2020-12-15 23:51 ` Ian Lance Taylor
@ 2020-12-15 23:53 ` Ian Lance Taylor
2020-12-17 2:54 ` Kewen.Lin
0 siblings, 1 reply; 8+ messages in thread
From: Ian Lance Taylor @ 2020-12-15 23:53 UTC (permalink / raw)
To: gcc-patches
On Tue, Dec 15, 2020 at 3:51 PM Ian Lance Taylor <iant@golang.org> wrote:
>
> On Tue, Dec 15, 2020 at 3:43 PM Ian Lance Taylor <iant@golang.org> wrote:
> >
> > I'm trying to commit a change that adds a bunch of new files to
> > gcc/testsuite/go.test/test. It's being rejected because the hook
> > can't deduce a ChangeLog file. But this directory has no ChangeLog
> > files. I've committed other changes to this directory without a
> > ChangeLog entry.
> >
> > What is going wrong? What can I do to commit this change? What
> > information can I provide?
> >
> > Thanks.
> >
> > Ian
> >
> > > git push
> > Enumerating objects: 854, done.
> > Counting objects: 100% (854/854), done.
> > Delta compression using up to 8 threads
> > Compressing objects: 100% (824/824), done.
> > Writing objects: 100% (847/847), 266.10 KiB | 2.25 MiB/s, done.
> > Total 847 (delta 167), reused 3 (delta 0), pack-reused 0
> > remote: Resolving deltas: 100% (167/167), completed with 4 local objects.
> > remote: *** The following commit was rejected by your
> > hooks.commit-extra-checker script (status: 1)
> > remote: *** commit: b09ac944e04a59af95a5767f6835edad7da4f152
> > remote: *** ChangeLog format failed:
> > remote: *** ERR: could not deduce ChangeLog file
> > remote: ***
> > remote: *** Please see: https://gcc.gnu.org/codingconventions.html#ChangeLogs
> > remote: ***
> > remote: error: hook declined to update refs/heads/master
> > To git+ssh://gcc.gnu.org/git/gcc
> > ! [remote rejected] master -> master (hook declined)
> > error: failed to push some refs to 'git+ssh://gcc.gnu.org/git/gcc'
>
> One less common change I am trying to make is to delete a file. Could
> that be the cause of this problem?
>
> I'm going to try removing the deleted file from the change.
Nope, still failed, though the message is slightly different.
Ian
> git push
Enumerating objects: 854, done.
Counting objects: 100% (854/854), done.
Delta compression using up to 8 threads
Compressing objects: 100% (824/824), done.
Writing objects: 100% (847/847), 266.29 KiB | 2.36 MiB/s, done.
Total 847 (delta 166), reused 3 (delta 0), pack-reused 0
remote: Resolving deltas: 100% (166/166), completed with 4 local objects.
remote: *** The following commit was rejected by your
hooks.commit-extra-checker script (status: 1)
remote: *** commit: 741cd6e22ce6d587d3e8c5aba0f093644785f454
remote: *** ChangeLog format failed:
remote: *** ERR: cannot find a ChangeLog location in message
remote: ***
remote: *** Please see: https://gcc.gnu.org/codingconventions.html#ChangeLogs
remote: ***
remote: error: hook declined to update refs/heads/master
To git+ssh://gcc.gnu.org/git/gcc
! [remote rejected] master -> master (hook declined)
error: failed to push some refs to 'git+ssh://gcc.gnu.org/git/gcc'
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: Change to gcc/testsuite/go.test/test rejected by ChangeLog checker
2020-12-15 23:53 ` Ian Lance Taylor
@ 2020-12-17 2:54 ` Kewen.Lin
2020-12-17 3:26 ` Ian Lance Taylor
0 siblings, 1 reply; 8+ messages in thread
From: Kewen.Lin @ 2020-12-17 2:54 UTC (permalink / raw)
To: Ian Lance Taylor; +Cc: gcc-patches
Hi Ian,
on 2020/12/16 上午7:53, Ian Lance Taylor via Gcc-patches wrote:
> On Tue, Dec 15, 2020 at 3:51 PM Ian Lance Taylor <iant@golang.org> wrote:
>>
>> On Tue, Dec 15, 2020 at 3:43 PM Ian Lance Taylor <iant@golang.org> wrote:
>>>
>>> I'm trying to commit a change that adds a bunch of new files to
>>> gcc/testsuite/go.test/test. It's being rejected because the hook
>>> can't deduce a ChangeLog file. But this directory has no ChangeLog
>>> files. I've committed other changes to this directory without a
>>> ChangeLog entry.
>>>
>>> What is going wrong? What can I do to commit this change? What
>>> information can I provide?
>>>
>>> Thanks.
>>>
>>> Ian
>>>
>>>> git push
>>> Enumerating objects: 854, done.
>>> Counting objects: 100% (854/854), done.
>>> Delta compression using up to 8 threads
>>> Compressing objects: 100% (824/824), done.
>>> Writing objects: 100% (847/847), 266.10 KiB | 2.25 MiB/s, done.
>>> Total 847 (delta 167), reused 3 (delta 0), pack-reused 0
>>> remote: Resolving deltas: 100% (167/167), completed with 4 local objects.
>>> remote: *** The following commit was rejected by your
>>> hooks.commit-extra-checker script (status: 1)
>>> remote: *** commit: b09ac944e04a59af95a5767f6835edad7da4f152
>>> remote: *** ChangeLog format failed:
>>> remote: *** ERR: could not deduce ChangeLog file
>>> remote: ***
>>> remote: *** Please see: https://gcc.gnu.org/codingconventions.html#ChangeLogs
>>> remote: ***
>>> remote: error: hook declined to update refs/heads/master
>>> To git+ssh://gcc.gnu.org/git/gcc
>>> ! [remote rejected] master -> master (hook declined)
>>> error: failed to push some refs to 'git+ssh://gcc.gnu.org/git/gcc'
>>
>> One less common change I am trying to make is to delete a file. Could
>> that be the cause of this problem?
>>
>> I'm going to try removing the deleted file from the change.
>
> Nope, still failed, though the message is slightly different.
>
I'm not sure you have figured out the reason and made the push
successfully.
The files in gcc/testsuite/go.test/test seems still available to
have their changelog entries. Such as for your recent commit
e38c912700f001ea1c8a32533bedb4c802e38d3f.
git show e38c912700f001ea1c8a32533bedb4c802e38d3f | contrib/mklog.py
gcc/testsuite/ChangeLog:
* go.test/test/fixedbugs/bug13343.go: New test.
* go.test/test/fixedbugs/bug19403.go: New test.
* go.test/test/fixedbugs/bug369.dir/main.go: New test.
* go.test/test/fixedbugs/bug483.go: New test.
* go.test/test/fixedbugs/bug484.go: New test.
* go.test/test/fixedbugs/bug485.go: New test.
* go.test/test/fixedbugs/bug486.go: New test.
* go.test/test/fixedbugs/bug490.go: New test.
* go.test/test/fixedbugs/bug491.go: New test.
* go.test/test/fixedbugs/bug495.go: New test.
* go.test/test/fixedbugs/bug498.go: New test.
* go.test/test/fixedbugs/bug510.dir/a.go: New test.
* go.test/test/fixedbugs/bug510.dir/b.go: New test.
* go.test/test/fixedbugs/bug510.go: New test.
Probably the hook becomes stricter somehow recently and complains the
expected changelog entires missing there.
BR,
Kewen
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: Change to gcc/testsuite/go.test/test rejected by ChangeLog checker
2020-12-17 2:54 ` Kewen.Lin
@ 2020-12-17 3:26 ` Ian Lance Taylor
2020-12-17 3:38 ` Kewen.Lin
0 siblings, 1 reply; 8+ messages in thread
From: Ian Lance Taylor @ 2020-12-17 3:26 UTC (permalink / raw)
To: Kewen.Lin; +Cc: gcc-patches
On Wed, Dec 16, 2020 at 6:54 PM Kewen.Lin <linkw@linux.ibm.com> wrote:
>
> on 2020/12/16 上午7:53, Ian Lance Taylor via Gcc-patches wrote:
> > On Tue, Dec 15, 2020 at 3:51 PM Ian Lance Taylor <iant@golang.org> wrote:
> >>
> >> On Tue, Dec 15, 2020 at 3:43 PM Ian Lance Taylor <iant@golang.org> wrote:
> >>>
> >>> I'm trying to commit a change that adds a bunch of new files to
> >>> gcc/testsuite/go.test/test. It's being rejected because the hook
> >>> can't deduce a ChangeLog file. But this directory has no ChangeLog
> >>> files. I've committed other changes to this directory without a
> >>> ChangeLog entry.
> >>>
> >>> What is going wrong? What can I do to commit this change? What
> >>> information can I provide?
> >>>
> >>> Thanks.
> >>>
> >>> Ian
> >>>
> >>>> git push
> >>> Enumerating objects: 854, done.
> >>> Counting objects: 100% (854/854), done.
> >>> Delta compression using up to 8 threads
> >>> Compressing objects: 100% (824/824), done.
> >>> Writing objects: 100% (847/847), 266.10 KiB | 2.25 MiB/s, done.
> >>> Total 847 (delta 167), reused 3 (delta 0), pack-reused 0
> >>> remote: Resolving deltas: 100% (167/167), completed with 4 local objects.
> >>> remote: *** The following commit was rejected by your
> >>> hooks.commit-extra-checker script (status: 1)
> >>> remote: *** commit: b09ac944e04a59af95a5767f6835edad7da4f152
> >>> remote: *** ChangeLog format failed:
> >>> remote: *** ERR: could not deduce ChangeLog file
> >>> remote: ***
> >>> remote: *** Please see: https://gcc.gnu.org/codingconventions.html#ChangeLogs
> >>> remote: ***
> >>> remote: error: hook declined to update refs/heads/master
> >>> To git+ssh://gcc.gnu.org/git/gcc
> >>> ! [remote rejected] master -> master (hook declined)
> >>> error: failed to push some refs to 'git+ssh://gcc.gnu.org/git/gcc'
> >>
> >> One less common change I am trying to make is to delete a file. Could
> >> that be the cause of this problem?
> >>
> >> I'm going to try removing the deleted file from the change.
> >
> > Nope, still failed, though the message is slightly different.
> >
>
> I'm not sure you have figured out the reason and made the push
> successfully.
>
> The files in gcc/testsuite/go.test/test seems still available to
> have their changelog entries. Such as for your recent commit
> e38c912700f001ea1c8a32533bedb4c802e38d3f.
>
> git show e38c912700f001ea1c8a32533bedb4c802e38d3f | contrib/mklog.py
> gcc/testsuite/ChangeLog:
>
> * go.test/test/fixedbugs/bug13343.go: New test.
> * go.test/test/fixedbugs/bug19403.go: New test.
> * go.test/test/fixedbugs/bug369.dir/main.go: New test.
> * go.test/test/fixedbugs/bug483.go: New test.
> * go.test/test/fixedbugs/bug484.go: New test.
> * go.test/test/fixedbugs/bug485.go: New test.
> * go.test/test/fixedbugs/bug486.go: New test.
> * go.test/test/fixedbugs/bug490.go: New test.
> * go.test/test/fixedbugs/bug491.go: New test.
> * go.test/test/fixedbugs/bug495.go: New test.
> * go.test/test/fixedbugs/bug498.go: New test.
> * go.test/test/fixedbugs/bug510.dir/a.go: New test.
> * go.test/test/fixedbugs/bug510.dir/b.go: New test.
> * go.test/test/fixedbugs/bug510.go: New test.
>
> Probably the hook becomes stricter somehow recently and complains the
> expected changelog entires missing there.
I have not figured this out. I am going to try to submit smaller sets
of files. Perhaps the problem was the size of the change, or perhaps
it was some specific file.
Ian
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: Change to gcc/testsuite/go.test/test rejected by ChangeLog checker
2020-12-17 3:26 ` Ian Lance Taylor
@ 2020-12-17 3:38 ` Kewen.Lin
2020-12-17 4:01 ` Ian Lance Taylor
0 siblings, 1 reply; 8+ messages in thread
From: Kewen.Lin @ 2020-12-17 3:38 UTC (permalink / raw)
To: Ian Lance Taylor; +Cc: gcc-patches
on 2020/12/17 上午11:26, Ian Lance Taylor wrote:
> On Wed, Dec 16, 2020 at 6:54 PM Kewen.Lin <linkw@linux.ibm.com> wrote:
>>
>> on 2020/12/16 上午7:53, Ian Lance Taylor via Gcc-patches wrote:
>>> On Tue, Dec 15, 2020 at 3:51 PM Ian Lance Taylor <iant@golang.org> wrote:
>>>>
>>>> On Tue, Dec 15, 2020 at 3:43 PM Ian Lance Taylor <iant@golang.org> wrote:
>>>>>
>>>>> I'm trying to commit a change that adds a bunch of new files to
>>>>> gcc/testsuite/go.test/test. It's being rejected because the hook
>>>>> can't deduce a ChangeLog file. But this directory has no ChangeLog
>>>>> files. I've committed other changes to this directory without a
>>>>> ChangeLog entry.
>>>>>
>>>>> What is going wrong? What can I do to commit this change? What
>>>>> information can I provide?
>>>>>
>>>>> Thanks.
>>>>>
>>>>> Ian
>>>>>
>>>>>> git push
>>>>> Enumerating objects: 854, done.
>>>>> Counting objects: 100% (854/854), done.
>>>>> Delta compression using up to 8 threads
>>>>> Compressing objects: 100% (824/824), done.
>>>>> Writing objects: 100% (847/847), 266.10 KiB | 2.25 MiB/s, done.
>>>>> Total 847 (delta 167), reused 3 (delta 0), pack-reused 0
>>>>> remote: Resolving deltas: 100% (167/167), completed with 4 local objects.
>>>>> remote: *** The following commit was rejected by your
>>>>> hooks.commit-extra-checker script (status: 1)
>>>>> remote: *** commit: b09ac944e04a59af95a5767f6835edad7da4f152
>>>>> remote: *** ChangeLog format failed:
>>>>> remote: *** ERR: could not deduce ChangeLog file
>>>>> remote: ***
>>>>> remote: *** Please see: https://gcc.gnu.org/codingconventions.html#ChangeLogs
>>>>> remote: ***
>>>>> remote: error: hook declined to update refs/heads/master
>>>>> To git+ssh://gcc.gnu.org/git/gcc
>>>>> ! [remote rejected] master -> master (hook declined)
>>>>> error: failed to push some refs to 'git+ssh://gcc.gnu.org/git/gcc'
>>>>
>>>> One less common change I am trying to make is to delete a file. Could
>>>> that be the cause of this problem?
>>>>
>>>> I'm going to try removing the deleted file from the change.
>>>
>>> Nope, still failed, though the message is slightly different.
>>>
>>
>> I'm not sure you have figured out the reason and made the push
>> successfully.
>>
>> The files in gcc/testsuite/go.test/test seems still available to
>> have their changelog entries. Such as for your recent commit
>> e38c912700f001ea1c8a32533bedb4c802e38d3f.
>>
>> git show e38c912700f001ea1c8a32533bedb4c802e38d3f | contrib/mklog.py
>> gcc/testsuite/ChangeLog:
>>
>> * go.test/test/fixedbugs/bug13343.go: New test.
>> * go.test/test/fixedbugs/bug19403.go: New test.
>> * go.test/test/fixedbugs/bug369.dir/main.go: New test.
>> * go.test/test/fixedbugs/bug483.go: New test.
>> * go.test/test/fixedbugs/bug484.go: New test.
>> * go.test/test/fixedbugs/bug485.go: New test.
>> * go.test/test/fixedbugs/bug486.go: New test.
>> * go.test/test/fixedbugs/bug490.go: New test.
>> * go.test/test/fixedbugs/bug491.go: New test.
>> * go.test/test/fixedbugs/bug495.go: New test.
>> * go.test/test/fixedbugs/bug498.go: New test.
>> * go.test/test/fixedbugs/bug510.dir/a.go: New test.
>> * go.test/test/fixedbugs/bug510.dir/b.go: New test.
>> * go.test/test/fixedbugs/bug510.go: New test.
>>
>> Probably the hook becomes stricter somehow recently and complains the
>> expected changelog entires missing there.
>
>
> I have not figured this out. I am going to try to submit smaller sets
> of files. Perhaps the problem was the size of the change, or perhaps
> it was some specific file.
With the helper gcc-verify from contrib/gcc-git-customization.sh [1],
you can verify your local commit to meet required ChangeLog formats.
Does gcc-verify claim that it's ok locally?
If no, probably you can amend the commit message with those entries
suggested from contrib/mklog.py, to see there are any differences.
BR,
Kewen
[1] https://gcc.gnu.org/gitwrite.html
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: Change to gcc/testsuite/go.test/test rejected by ChangeLog checker
2020-12-17 3:38 ` Kewen.Lin
@ 2020-12-17 4:01 ` Ian Lance Taylor
2020-12-17 4:05 ` Ian Lance Taylor
0 siblings, 1 reply; 8+ messages in thread
From: Ian Lance Taylor @ 2020-12-17 4:01 UTC (permalink / raw)
To: Kewen.Lin; +Cc: gcc-patches
On Wed, Dec 16, 2020 at 7:38 PM Kewen.Lin <linkw@linux.ibm.com> wrote:
>
> With the helper gcc-verify from contrib/gcc-git-customization.sh [1],
> you can verify your local commit to meet required ChangeLog formats.
> Does gcc-verify claim that it's ok locally?
>
> If no, probably you can amend the commit message with those entries
> suggested from contrib/mklog.py, to see there are any differences.
I figured it out. The problem is a couple of files in the testsuite
whose names are not ASCII:
gcc/testsuite/go.test/test/fixedbugs/issue27836.dir/Äfoo.go
gcc/testsuite/go.test/test/fixedbugs/issue27836.dir/Ämain.go
Trying to commit those files triggers the error on "git push".
Thanks for the pointer to git-verify. It also fails. It looks like
when the file name contains a non-ASCII character, it comes back with
quotation marks around it. That causes the test "if
path.startswith(ignored):" in git_commit.py to fail when checking
whether the file is an ignored directory.
Ian
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: Change to gcc/testsuite/go.test/test rejected by ChangeLog checker
2020-12-17 4:01 ` Ian Lance Taylor
@ 2020-12-17 4:05 ` Ian Lance Taylor
0 siblings, 0 replies; 8+ messages in thread
From: Ian Lance Taylor @ 2020-12-17 4:05 UTC (permalink / raw)
To: Kewen.Lin; +Cc: gcc-patches
On Wed, Dec 16, 2020 at 8:01 PM Ian Lance Taylor <iant@golang.org> wrote:
>
> Thanks for the pointer to git-verify. It also fails. It looks like
> when the file name contains a non-ASCII character, it comes back with
> quotation marks around it. That causes the test "if
> path.startswith(ignored):" in git_commit.py to fail when checking
> whether the file is an ignored directory.
Looks like the quotation marks come from git itself. This is the
output of git status.
On branch master
Your branch is up to date with 'origin/master'.
Changes to be committed:
(use "git restore --staged <file>..." to unstage)
new file: "gcc/testsuite/go.test/test/fixedbugs/issue27836.dir/\303\204foo.go"
new file: "gcc/testsuite/go.test/test/fixedbugs/issue27836.dir/\303\204main.go"
new file: gcc/testsuite/go.test/test/fixedbugs/issue27836.go
Ian
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2020-12-17 4:05 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-15 23:43 Change to gcc/testsuite/go.test/test rejected by ChangeLog checker Ian Lance Taylor
2020-12-15 23:51 ` Ian Lance Taylor
2020-12-15 23:53 ` Ian Lance Taylor
2020-12-17 2:54 ` Kewen.Lin
2020-12-17 3:26 ` Ian Lance Taylor
2020-12-17 3:38 ` Kewen.Lin
2020-12-17 4:01 ` Ian Lance Taylor
2020-12-17 4:05 ` Ian Lance Taylor
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).