From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 117031 invoked by alias); 26 Oct 2017 23:04:24 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 117020 invoked by uid 89); 26 Oct 2017 23:04:24 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-10.7 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,GIT_PATCH_3,KAM_ASCII_DIVIDERS,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=ham version=3.3.2 spammy=HX-Received:10.80.221.11, HX-Received:sk:t11mr29 X-HELO: mail-wm0-f51.google.com Received: from mail-wm0-f51.google.com (HELO mail-wm0-f51.google.com) (74.125.82.51) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 26 Oct 2017 23:04:21 +0000 Received: by mail-wm0-f51.google.com with SMTP id z3so383235wme.5 for ; Thu, 26 Oct 2017 16:04:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=n8nIVHCvTlaT7dXenag0WTfXuaUPnzsMzLw02Go4cY4=; b=OLEF24JgYi6dVM85iJZmoGZxesqz/ZeknCxMGU0jG2kkmMt0h7ncGJx8bi5JOOeTuc Jk/muUHUCGsraJCd5iKprnS3xX1JlvLn1w+cakX6XE6g4KJXuvA7MlNmNSaDkU4lE8p/ wRxXHaJme/IIl1Ahdlw76b8fGMaGAgYc5zxKN7pdo+hJR9f+r3Ij64+VmBQlU0brT9Ng l3r3y0zZtzp/GHhz1e+ru0ESPOCVqntUPzqVFPiHIH9aUh36COZDXHjehPriRGsDOoo4 vr7N8S+82kJgS6LUm2j7ZixQ9CLQ5HqMMTxh/nxa/zvIQwJsolWJXaP6L2HLel7duOTr +ZbQ== X-Gm-Message-State: AMCzsaVBTV0XVmSwa6BockVlrkKv9nCcapAEHcXT81apKCBkWjcj/Svj frJiEtVJj6zmwo4kFoLdhTQqtMV25Z7nv0PYsdG75Egg X-Google-Smtp-Source: ABhQp+QEPwQ0CjNTf4GG7MijcO/6dgZ9hDGQDc0KVNRbazix455YGQZxRI/bhlVD6W2gpMi1DEUDxhNklA9Gmu5WR5I= X-Received: by 10.80.221.11 with SMTP id t11mr29720707edk.84.1509059059464; Thu, 26 Oct 2017 16:04:19 -0700 (PDT) MIME-Version: 1.0 Received: by 10.80.179.240 with HTTP; Thu, 26 Oct 2017 16:04:18 -0700 (PDT) From: Ian Lance Taylor Date: Thu, 26 Oct 2017 23:29:00 -0000 Message-ID: Subject: Go patch committed: Explicitly convert between type aliases To: gcc-patches , "gofrontend-dev@googlegroups.com" Content-Type: multipart/mixed; boundary="f403043e5cbc2f6552055c7b31db" X-SW-Source: 2017-10/txt/msg02015.txt.bz2 --f403043e5cbc2f6552055c7b31db Content-Type: text/plain; charset="UTF-8" Content-length: 421 This patch adds an explicit conversion between type aliases. Otherwise we can get a crash in the backend when GCC sees a fold_convert_loc between two record types that the GCC backend appear to be different. Adding the explicit conversion will insert a VIEW_CONVERT_EXPR where needed. The test case is https://golang.org/cl/73790. Bootstrapped and ran Go testsuite on x86_64-pc-linux-gnu. Committed to mainline. Ian --f403043e5cbc2f6552055c7b31db Content-Type: text/plain; charset="US-ASCII"; name="patch.txt" Content-Disposition: attachment; filename="patch.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_j992sqs70 Content-length: 3018 SW5kZXg6IGdjYy9nby9nb2Zyb250ZW5kL01FUkdFCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIGdjYy9nby9nb2Zyb250ZW5kL01FUkdFCShyZXZpc2lv biAyNTQwOTApCisrKyBnY2MvZ28vZ29mcm9udGVuZC9NRVJHRQkod29ya2lu ZyBjb3B5KQpAQCAtMSw0ICsxLDQgQEAKLWE0MDlhYzJjNzg4OTllNjM4YTAx NGM5Nzg5MTkyNWJlYzkzY2IzYWQKKzY0ZDU3MGM1OTBhNzY5MjFjYmRjYTRl ZmIyMmU0Njc1ZTE5Y2M4MDkKIAogVGhlIGZpcnN0IGxpbmUgb2YgdGhpcyBm aWxlIGhvbGRzIHRoZSBnaXQgcmV2aXNpb24gbnVtYmVyIG9mIHRoZSBsYXN0 CiBtZXJnZSBkb25lIGZyb20gdGhlIGdvZnJvbnRlbmQgcmVwb3NpdG9yeS4K SW5kZXg6IGdjYy9nby9nb2Zyb250ZW5kL2V4cHJlc3Npb25zLmNjCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIGdjYy9nby9nb2Zyb250ZW5kL2V4cHJl c3Npb25zLmNjCShyZXZpc2lvbiAyNTQwOTApCisrKyBnY2MvZ28vZ29mcm9u dGVuZC9leHByZXNzaW9ucy5jYwkod29ya2luZyBjb3B5KQpAQCAtMTQ0LDgg KzE0NCw4IEBAIEV4cHJlc3Npb246OmNvbnZlcnRfZm9yX2Fzc2lnbm1lbnQo R29nbyoKICAgICAgIHx8IHJocy0+aXNfZXJyb3JfZXhwcmVzc2lvbigpKQog ICAgIHJldHVybiBFeHByZXNzaW9uOjptYWtlX2Vycm9yKGxvY2F0aW9uKTsK IAotICBpZiAobGhzX3R5cGUtPmZvcndhcmRlZCgpICE9IHJoc190eXBlLT5m b3J3YXJkZWQoKQotICAgICAgJiYgbGhzX3R5cGUtPmludGVyZmFjZV90eXBl KCkgIT0gTlVMTCkKKyAgYm9vbCBhcmVfaWRlbnRpY2FsID0gVHlwZTo6YXJl X2lkZW50aWNhbChsaHNfdHlwZSwgcmhzX3R5cGUsIGZhbHNlLCBOVUxMKTsK KyAgaWYgKCFhcmVfaWRlbnRpY2FsICYmIGxoc190eXBlLT5pbnRlcmZhY2Vf dHlwZSgpICE9IE5VTEwpCiAgICAgewogICAgICAgaWYgKHJoc190eXBlLT5p bnRlcmZhY2VfdHlwZSgpID09IE5VTEwpCiAgICAgICAgIHJldHVybiBFeHBy ZXNzaW9uOjpjb252ZXJ0X3R5cGVfdG9faW50ZXJmYWNlKGxoc190eXBlLCBy aHMsIGxvY2F0aW9uKTsKQEAgLTE1Myw4ICsxNTMsNyBAQCBFeHByZXNzaW9u Ojpjb252ZXJ0X2Zvcl9hc3NpZ25tZW50KEdvZ28qCiAgICAgICAgIHJldHVy biBFeHByZXNzaW9uOjpjb252ZXJ0X2ludGVyZmFjZV90b19pbnRlcmZhY2Uo bGhzX3R5cGUsIHJocywgZmFsc2UsCiAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgbG9jYXRpb24p OwogICAgIH0KLSAgZWxzZSBpZiAobGhzX3R5cGUtPmZvcndhcmRlZCgpICE9 IHJoc190eXBlLT5mb3J3YXJkZWQoKQotCSAgICYmIHJoc190eXBlLT5pbnRl cmZhY2VfdHlwZSgpICE9IE5VTEwpCisgIGVsc2UgaWYgKCFhcmVfaWRlbnRp Y2FsICYmIHJoc190eXBlLT5pbnRlcmZhY2VfdHlwZSgpICE9IE5VTEwpCiAg ICAgcmV0dXJuIEV4cHJlc3Npb246OmNvbnZlcnRfaW50ZXJmYWNlX3RvX3R5 cGUobGhzX3R5cGUsIHJocywgbG9jYXRpb24pOwogICBlbHNlIGlmIChsaHNf dHlwZS0+aXNfc2xpY2VfdHlwZSgpICYmIHJoc190eXBlLT5pc19uaWxfdHlw ZSgpKQogICAgIHsKQEAgLTE2NSw4ICsxNjQsMTUgQEAgRXhwcmVzc2lvbjo6 Y29udmVydF9mb3JfYXNzaWdubWVudChHb2dvKgogICAgIH0KICAgZWxzZSBp ZiAocmhzX3R5cGUtPmlzX25pbF90eXBlKCkpCiAgICAgcmV0dXJuIEV4cHJl c3Npb246Om1ha2VfbmlsKGxvY2F0aW9uKTsKLSAgZWxzZSBpZiAoVHlwZTo6 YXJlX2lkZW50aWNhbChsaHNfdHlwZSwgcmhzX3R5cGUsIGZhbHNlLCBOVUxM KSkKKyAgZWxzZSBpZiAoYXJlX2lkZW50aWNhbCkKICAgICB7CisgICAgICBp ZiAobGhzX3R5cGUtPmZvcndhcmRlZCgpICE9IHJoc190eXBlLT5mb3J3YXJk ZWQoKSkKKwl7CisJICAvLyBEaWZmZXJlbnQgYnV0IGlkZW50aWNhbCB0eXBl cyByZXF1aXJlIGFuIGV4cGxpY2l0CisJICAvLyBjb252ZXJzaW9uLiAgVGhp cyBoYXBwZW5zIHdpdGggdHlwZSBhbGlhc2VzLgorCSAgcmV0dXJuIEV4cHJl c3Npb246Om1ha2VfY2FzdChsaHNfdHlwZSwgcmhzLCBsb2NhdGlvbik7CisJ fQorCiAgICAgICAvLyBObyBjb252ZXJzaW9uIGlzIG5lZWRlZC4KICAgICAg IHJldHVybiByaHM7CiAgICAgfQo= --f403043e5cbc2f6552055c7b31db--